- Use self.add() rather than self.add_prefix(); this adds the toggle button to the end of the event widget rather than the beginning - Add Sebastian Crane to the list of authors in the about window --- Hello Fabio! I'm a great fan of Confy; I have found it most useful. This is a UX-related patch, regarding the placement of the 'toggle starred' button on events. Typically, primary actions are near the left of the screen and secondary actions are to the right (at least for languages that are read from left to right). For each event widget in the list, the primary action is opening the event's details. Since starring an event is secondary to this action, I think it'd make sense to move the 'toggle starred' button to the right of the event widget. Whilst watching a relative use Confy, I noticed that he accidentally starred a few talks due to an expectation that the button would lead to the details page. Clearly this isn't much of a usability study, but hopefully it illustrates the possible benefit of this rearrangement! Please let me know what you think of the changes :) Best wishes, Sebastian src/widgets.py | 2 +- src/window.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/widgets.py b/src/widgets.py index 77cdaba..26e0781 100644 --- a/src/widgets.py +++ b/src/widgets.py @@ -111,7 +111,7 @@ class EventActionRow(Handy.ActionRow): icon_name = "starred-symbolic" if obj.starred else "non-starred-symbolic" self.toggle_btn = Gtk.Button.new_from_icon_name(icon_name, Gtk.IconSize.BUTTON) self.toggle_btn.connect("clicked", self.toggle_starred) - self.add_prefix(self.toggle_btn) + self.add(self.toggle_btn) Gio.Application.get_default().connect( "tick", lambda *_: self.queue_draw() diff --git a/src/window.py b/src/window.py index b6bf563..3424538 100644 --- a/src/window.py +++ b/src/window.py @@ -684,7 +684,7 @@ class ConfyWindow(Gtk.ApplicationWindow): version=APP_VERSION, copyright="© 2020 Fabio Comuni", website="https://confy.kirgroup.net/", - authors=["Fabio Comuni", "Evangelos Ribeiro Tzaras"], + authors=["Fabio Comuni", "Evangelos Ribeiro Tzaras", "Sebastian Crane"], comments=_("Conference schedules viewer"), license_type=Gtk.License.GPL_3_0 ).show() -- 2.25.4
Hi Sebastian Thank you for your patch, your reasoning about primary and secondary actions sounds very correct (and looks like 100% of the users interviewed agree :) ) Unfortunately some days ago my laptop died, so I can't test and merge right now. Thinking about this, I could try to setup the dev env on the pinephone directly... mmmh...
Dear Fabio, > your reasoning about primary and secondary actions sounds very correct > (and looks like 100% of the users interviewed agree :) ) > > ... > > The pinepone setup is better than I tought... your patch has been > merged, thank you! Thank you for merging; I'm glad I could help with Confy. In my latest study, I have even better results - 100% of the users interviewed are satisfied with the changes! :) I noticed that you updated the changelog and added a little of my explanatory email to the Git commit message. Is this something that you would like me to do in future patches that I send in, or would you prefer to take care of this yourself? It's great to hear that the toolchains are working well on ARM - I must admit that I'm at the more modest stage of attempting to update u-boot-tools on my PostmarketOS installation! Best wishes, Sebastian