Hi Sebastian and fabbrixxm!
Patch makes sense to me.
Maybe a tiny suggestion bellow (because i stumbled upon it while looking at
Debian packaging [1][2]
But feel free to disregard it.
Otherwise this my signed-off :P
On Mon, 2023-08-07 at 17:49 +0100, Sebastian Crane wrote:
> Bring the description, build requirements and instructions in> README.md up to date with the GTK4 port.> ---> README.md | 8 ++++----> 1 file changed, 4 insertions(+), 4 deletions(-)> > diff --git a/README.md b/README.md> index 73006ac..5b3056e 100644> --- a/README.md> +++ b/README.md> @@ -6,7 +6,7 @@ Conferences schedule viewer for GNOME
<snip>
> Requirements> > -- Gtk3> -- libhandy 1> +- GTK4> +- Libadwaita> - Python3> - python-gobjects> - python-icalendar
maybe also add the blueprintcompiler (which currently needs 0.10.0 I believe)
[1]
[2]
--
Cheers,
Evangelos
PGP: B938 6554 B7DD 266B CB8E 29A9 90F0 C9B1 8A6B 4A19
Il giorno mar, 08/08/2023 alle 20.38 +0200, Evangelos Ribeiro Tzaras ha
scritto:
> maybe also add the blueprintcompiler (which currently needs 0.10.0 I> believe)
Yes,
It used to be a subproject in meson but it doesn't build in flathub's
sandboxed builder, so I had to remove it from meson and add it to
flatpack manifest.
This means that blueprint is required to be installed to build outside
flatpack.
Version 0.8.1 is used in flatpak, so that should do.
Sebastian: do you want to update the patch or should I merge this and
do the update afterwards?
> Yes,> It used to be a subproject in meson but it doesn't build in flathub's> sandboxed builder, so I had to remove it from meson and add it to> flatpack manifest.> This means that blueprint is required to be installed to build outside> flatpack.> Version 0.8.1 is used in flatpak, so that should do.>> Sebastian: do you want to update the patch or should I merge this and> do the update afterwards?
Yes, please do merge this patch and update it for blueprint :)
Since blueprint is fairly well packaged in various distributions now,
and could probably be brought up to version >0.8.1 for all those
packages, do you think the vendored copy of blueprint in subprojects/
could be removed entirely now? I would imagine that could allow
Evangelos to simplify the Debian package for future Confy releases.
Il giorno mer, 09/08/2023 alle 14.59 +0100, Sebastian Crane ha scritto:
> > Yes, please do merge this patch and update it for blueprint :)
merged
> Since blueprint is fairly well packaged in various distributions now,> and could probably be brought up to version >0.8.1 for all those> packages, do you think the vendored copy of blueprint in subprojects/> could be removed entirely now? I would imagine that could allow> Evangelos to simplify the Debian package for future Confy releases.
yes, sounds good.
I've updated the README and removed the subproject
...tbh I was sure I had already removed it ... 👀️
Hi,
On Wed, 2023-08-09 at 16:37 +0200, Fabio wrote:
> Il giorno mer, 09/08/2023 alle 14.59 +0100, Sebastian Crane ha> scritto:> > > > Yes, please do merge this patch and update it for blueprint :)> > merged > > > Since blueprint is fairly well packaged in various distributions> > now,> > and could probably be brought up to version >0.8.1 for all those> > packages, do you think the vendored copy of blueprint in> > subprojects/> > could be removed entirely now? I would imagine that could allow> > Evangelos to simplify the Debian package for future Confy releases.> > yes, sounds good.> I've updated the README and removed the subproject> > ...tbh I was sure I had already removed it ... 👀️
v0.7.0 (e78a3d5826708b8f4b28ca34e1fc2cbf1df1443d)
has a wrap file thing, not a git submodule,
so all is good from my PoV.
In my packaging tree:
> $ ls .git*
[±debian/master ✓▴]
.gitignore
.git:
branches config FETCH_HEAD HEAD index logs
ORIG_HEAD refs
COMMIT_EDITMSG description gbp_index hooks info objects
packed-refs
> $ ls subprojects
[±debian/master ✓▴]
blueprint-compiler.wrap
--
Cheers,
Evangelos
PGP: B938 6554 B7DD 266B CB8E 29A9 90F0 C9B1 8A6B 4A19