~fabrixxm/confy-dev

Modify primary menu to better fit GNOME guidelines v1 APPLIED

Sebastian Crane: 1
 Modify primary menu to better fit GNOME guidelines

 2 files changed, 2 insertions(+), 4 deletions(-)
I'm glad you liked the patch! Thank you for merging :)

Best wishes,

Sebastian
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~fabrixxm/confy-dev/patches/22568/mbox | git am -3
Learn more about email & git
View this thread in the archives

[PATCH] Modify primary menu to better fit GNOME guidelines Export this patch

- Remove 'Quit' item
- Move 'Keyboard shortcuts' item to below 'Preferences' item

Please see https://developer.gnome.org/hig/stable/primary-menus.html
for the relevant GNOME design guidelines.
---
Dear Fabio,

I'm back with another little UX patch for Confy!

The first change removes the 'Quit' item from the primary 'hamburger'
menu; the reasoning for this is explained in the GNOME Human Interface
Guidelines page linked to in the commit message.

The second change is to rearrange the menu items. Whilst using GNOME
recently, I noticed that all of the applications seemed to have a
specific ordering to their menu items. I asked about this on the
gnome-design Matrix channel, and there doesn't seem to have been any
original decision to use this ordering; apparently it just evolved to be
this way over time. That said, I don't see any reason not to keep with
GNOME conventions :)

I've taken some inspiration from your previous email, and have compiled
and tested the patch on my PinePhone - the build system is pretty nifty
on PostmarketOS just as it is on Mobian! Plus, this time I updated the
changelog ;)

As before, I'd love to hear your feedback about this patch!

Best wishes,

Sebastian

 CHANGELOG     | 1 +
 src/window.py | 5 +----
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/CHANGELOG b/CHANGELOG
index e7552a5..6c878db 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -2,6 +2,7 @@

## [unreleased]
### Changed
- Modify primary menu to better fit GNOME guidelines (seabass)
- Move 'star event' button to end of event widget (seabass)

## [0.5.5] - 2020-04-06
diff --git a/src/window.py b/src/window.py
index 3424538..a02fc93 100644
--- a/src/window.py
+++ b/src/window.py
@@ -669,13 +669,10 @@ class ConfyWindow(Gtk.ApplicationWindow):

    def pop_menu(self, menu):
        s = Gio.Menu()
        s.append(_("Keyboard shortcuts"), "app.shortcuts")
        s.append(_("Preferences"), "win.show-preferences")
        s.append(_("Keyboard shortcuts"), "app.shortcuts")
        s.append(_("About {}").format(APP_NAME), "win.about")
        menu.append_section(None, s)
        s = Gio.Menu()
        s.append(_("Quit").format(APP_NAME), "app.quit")
        menu.append_section(None, s)

    def show_about(self, *args):
        Gtk.AboutDialog(
--
2.25.4
Il 07/05/21 16:45, Sebastian Crane ha scritto:
Merged! Thank you!