Fix division by zero for events with zero duration v2 SUPERSEDED

Evangelos Ribeiro Tzaras: 1
 Fix division by zero for events with zero duration

 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH v2] Fix division by zero for events with zero duration Export this patch

When a event has duration zero because the start and end times are identical,
ZeroDivisionError's are raised:

```
Traceback (most recent call last):
  File "/home/fortysixandtwo/install/lib/python3.9/site-packages/confy/widgets.py", line 130, in _on_draw
    prc = min(max(pos/dur, 0.0), 1.0)
ZeroDivisionError: float division by zero
```

This patch ensures that prc is either 0 if the event is in the future
or 1, if it's in the past.

Closes #18
---
Forgot to reference the raised issue (and I've wanted to try sending a v2 patch :)

 src/widgets.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/widgets.py b/src/widgets.py
index 528244d..03b4458 100644
--- a/src/widgets.py
+++ b/src/widgets.py
@@ -127,7 +127,7 @@ class EventActionRow(Handy.ActionRow):
 
         dur = (obj.end.timestamp() - obj.start.timestamp())
         pos = (now.timestamp() - obj.start.timestamp())
-        prc = min(max(pos/dur, 0.0), 1.0)
+        prc = min(max(pos/dur, 0.0), 1.0) if dur > 0 else int(pos >= 0)

Fabio <fabrixxm@kirgroup.net>

1 year, 11 months ago

While it's correct (and more correct than the code I was writting to
fix this), it's a little to difficult to read.
I would prefer an explicit if/else, with some comments, something like

```
if dur > 0:
	prc = min(max(pos/dur, 0.0), 1.0)
else:
	# not a valid event duration, 
	# set prc  0 if the event is in the future or 1 if passed
	prc = int(pos >= 0)
```

And same patch should be added to `src/pages.py:510`

         y = h * prc
 
         cr.set_source_rgb(0, 0, 0)
-- 
2.30.2

Fabio <fabrixxm@kirgroup.net>

1 year, 11 months ago

Il giorno dom, 13/06/2021 alle 02.38 +0200, Evangelos Ribeiro Tzaras ha
scritto: