On Mon Sep 25, 2023 at 22:15, Coutinho de Souza wrote:
> Built it from source and can attest that on master[0] the problem
> does not occur.
>
> [0]: https://git.sr.ht/~rjarry/aerc/commit/37d5fc691aff24e5e41d5775bb6777b7cb4818c5

great! :)

--
+36305425054
bence.ferdinandy.com

Although git commit titles can be a lot longer that 72 characters it
sensible to limit it somewhere. Many people recommend a maximum of 50
characters, other places allow for slightly longer, github for examples
truncates titles at 72, our benevolent maintainer tries to aim for 60.
Considering the above 72 seems like a comfortable hard limit.

Signed-off-by: Bence Ferdinandy <bence@ferdinandy.com>
---
 contrib/check-patches | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/contrib/check-patches b/contrib/check-patches
index 3ae2e83..88e60a3 100755
--- a/contrib/check-patches
[message trimmed]

On Mon Sep 25, 2023 at 16:03, Coutinho de Souza wrote:
> Whenever aerc is given a mailto argument -- e. g.,
> `~rjarry/aerc-discuss@lists.sr.ht` -- and there's no instance already
> opened, it freezes on the `compose` page with the `To` and `From` fields
> filled.
>
> My aerc's version (`aerc -v`) is `aerc 0.15.2 +notmuch (go1.20.8 amd64 linux)`,
> running on Arch Linux.

I don't see this on latest master. I vaguely remember a patch about this. Could
you try this with aerc built from source?

thanks,

2023. szept. 23. 18:18:28 Moritz Poldrack <moritz@poldrack.dev>:

> On Sat Sep 23, 2023 at 6:12 PM CEST, Xavier Maillard wrote:
>> I want to do it the aerc's way :) but I just do not want to store my
>> password in clear plain text.
>
> This way msmtp does not store your password in plain text.
>
>     account default
>     host mail.moritz.sh
>     port 587
>     from moritz@poldrack.dev
>     user moritz@poldrack.dev
>     passwordeval secret-tool lookup Title Mailserver

2023. szept. 23. 11:28:54 inwit <inwit@sindominio.net>:

>
> On 23/09/2023, 10:44, Xavier Maillard wrote:
>> Is there anything I can do to have this in aerc too ?
> I think you're looking for outgoing-cred-cmd. Try :help accounts.

You can also keep using msmtp if you'd like.

On Tue Sep 19, 2023 at 01:07, Robin Jarry wrote:
> This style object was not documented. Make it so.
>
> Fixes: 995dfc15a806 ("styles: add style for folded threads")
> Signed-off-by: Robin Jarry <robin@jarry.cc>
> ---

I was thinking about the order of the commands in the global parts in the man
page, seems not totally but somewhat random, but that does not concern this
patch. Otherwise for all the doc patches:

Acked-by: Bence Ferdinandy <bence@ferdinandy.com>

On Tue Sep 19, 2023 at 01:07, Robin Jarry wrote:
> Add a new shell script to check that all commands are documented in man
> pages and that the man pages do not contain non-existent commands. Also
> check that all explicitly parsed options with ini reflection are
> documented as well. It is not possible to check if the man pages do
> reference non-existent options since some of the options are parsed
> lazily in workers and some of them are also declared with placeholders
> (e.g. *column-<name>*).
>
> Run the script in the lint target.
>
> Signed-off-by: Robin Jarry <robin@jarry.cc>
> ---

When giving advice on commands to run the colon is often included to
signify that the snippet is needs to be run as an aerc command.
Unfortunately, copying this into the command prompt of aerc leads to an
error. Copy the behaviour of vim and strip any number of leading colons
from command names.
---
 main.go | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/main.go b/main.go
index e0c4f89..4ae8831 100644
--- a/main.go
+++ b/main.go
@@ -72,8 +72,7 @@ func expandAbbreviations(cmd []string, sets []*commands.Commands) []string {
[message trimmed]

On Sun Sep 17, 2023 at 22:06, Vitaly Ovchinnikov wrote:
> Check if the command entered after : is the abbreviation of an existing
> command and run that instead. This is only done if there is no complete
> name matching first-hand and if the abbreviation matches just one
> command.
>
> Signed-off-by: Vitaly Ovchinnikov <v@postbox.nz>
> ---

I don't think I sent it yet:

Tested-by: Bence Ferdinandy <bence@ferdinandy.com>

On Sun Sep 17, 2023 at 20:21, Vitaly Ovchinnikov wrote:
> > I see an FTP error, so maybe a download didn't happen?
>
> Is it possible to restart the build without re-sending the patch?

I don't think so, we've had patches resent for that before I think ...

--
+36305425054
bence.ferdinandy.com