~ferdinandyb

Budapest

https://bence.ferdinandy.com

~ferdinandyb/throttle-devel

Last active 2 days ago

~ferdinandyb/throttle-announce

Last active a month ago

~ferdinandyb/ket-discuss

Last active 2 months ago

~ferdinandyb/ket-devel

Last active 2 months ago

~ferdinandyb/ket-announce

Last active 2 months ago
View more

Recent activity

Re: [PATCH aerc v3 2/2] notmuch: add completions for :cf, :filter and :search 2 days ago

From Bence Ferdinandy to ~rjarry/aerc-devel

2024. ápr. 14. 5:35:22 Julio B <julio.bacel@gmail.com>:

> Works as expected for all of :{query,cf,filter,search} commands.
> The 'tag:' completion is really useful!
>
> The only thing i found interesting is this:
> If you type for example  folder:Inbox/<TAB> then aerc completes
>   folder:Inbox/{cur,tmp,new}
> but the notmuch command in bash shell completes just
>   folder:Inbox/
> so cur,tmp and new are not expanded. But i don't think that this is an
> issue at all.

Yeah, I was lazy and decided that people can just stop completing before

[PATCH aerc v1] open: create a file even if filename is empty 2 days ago

From Bence Ferdinandy to ~rjarry/aerc-devel

Without a filename, aerc tries to open a directory. In this case, create
a random filename.

Fixes: d99c49de2fc12b64a7cd79044a8b042e7e59d02b
Signed-off-by: Bence Ferdinandy <bence@ferdinandy.com>
---
 commands/msgview/open.go | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/commands/msgview/open.go b/commands/msgview/open.go
index 55d085f6..1361b15e 100644
--- a/commands/msgview/open.go
+++ b/commands/msgview/open.go
@@ -3,6 +3,7 @@ package msgview
[message trimmed]

Re: [PATCH aerc v2] open: preserve the original filename 2 days ago

From Bence Ferdinandy to ~rjarry/aerc-devel

On Sat Apr 13, 2024 at 22:02, Robin Jarry <robin@jarry.cc> wrote:
> Maarten Aertsen, Apr 13, 2024 at 09:10:
> > Change the name of the temporary file that is :open'ed using the system
> > handler from `aerc-<randint>.ext` to
> > `aerc-<randint>/<actual-filename.ext>`.  This preserves the original
> > filename, while retaining collision avoidance and the current base
> > location (os.TempDir()).
> >
> > Changelog-changed: `:open` commands now preserve the original filename.
> > Signed-off-by: Maarten Aertsen <maarten@nlnetlabs.nl>
> > Tested-by: Bence Ferdinandy <bence@ferdinandy.com>
> > ---
> > v1->v2:

Re: [PATCH aerc v2] compose,viewer: do not always wrap people names in quotes 2 days ago

From Bence Ferdinandy to ~rjarry/aerc-devel

On Mon Mar 11, 2024 at 21:48, Robin Jarry <robin@jarry.cc> wrote:
> Currently, names of recipients in From, To, Cc and Bcc headers are
> (almost) always wrapped in quotes. Even if they are pure ASCII and
> contain one upper case letter. E.g.:
>
> 	From: "Foo" <foo@baz.org>
>
> There is no valid reason to add these quotes unless the name contains
> special characters as specified by RFC 5322, section 3.2.3:
>
>    specials        =   "(" / ")" /        ; Special characters that do
>                        "<" / ">" /        ;  not appear in atext
>                        "[" / "]" /

Re: [PATCH aerc] sendemail-validate: add fallback for older git 2 days ago

From Bence Ferdinandy to ~rjarry/aerc-devel

On Sun Mar 10, 2024 at 17:35, Robin Jarry <robin@jarry.cc> wrote:
> Before version 2.41, the sendemail-validate script can only be used to
> validate patches one by one, even when sending patch series.
>
> Set both GIT_SENDEMAIL_FILE_{COUNTER,TOTAL} to 1 in case they are not
> defined to avoid obscure errors. At least with older git versions,
> single patch validation should be possible.
>
> Signed-off-by: Robin Jarry <robin@jarry.cc>
> ---
>  contrib/sendemail-validate | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>

[PATCH aerc v3 2/2] notmuch: add completions for :cf, :filter and :search 2 days ago

From Bence Ferdinandy to ~rjarry/aerc-devel

Add completion of notmuch search-terms for cf, filter and search.

Implements: https://todo.sr.ht/~rjarry/aerc/244
Changelog-added: Add notmuch completions for cf, filter and search.
Signed-off-by: Bence Ferdinandy <bence@ferdinandy.com>
---

Notes:
    v3:
        - fixed cf not triggering

 commands/account/cf.go     | 19 ++++++++++++++++---
 commands/account/search.go | 16 +++++++++++++++-
 2 files changed, 31 insertions(+), 4 deletions(-)
[message trimmed]

[PATCH aerc v3 1/2] query: add completions for notmuch search-terms 2 days ago

From Bence Ferdinandy to ~rjarry/aerc-devel

Add completions to :query for the notmuch search terms. Most search
terms that seemed valid for interactive use in aerc are listed as
options. Some of them (from, to, tag, path, and folder) get actual
completions. The function was designed, so later patches can reuse it to
add completions to :cf, :filter and :search for notmuch accounts.

References: https://todo.sr.ht/~rjarry/aerc/244
Changelog-added: Added notmuch search-term completions to query.
Signed-off-by: Bence Ferdinandy <bence@ferdinandy.com>
---

Notes:
    v2:
     - moved list of search-terms to a variable for reference in other
[message trimmed]

Re: [PATCH aerc] send: prevent sending if multipart conversion failed 2 days ago

From Bence Ferdinandy to ~rjarry/aerc-devel

On Sat Apr 13, 2024 at 20:20, Moritz Poldrack <moritz@poldrack.dev> wrote:
> On Sat 13 Apr 2024 20:15:54, inwit wrote:
> > Unfortunately, this patch breaks my workflow: I used to :accept calendar invitations and, in the review screen, I used to get an error in red saying "text/calendar error: no command defined for mime/type", but still I was able to send the message (and thus accept the invitation).
> >
> > After this patch, I can't :accept invitations anymore. :(
>
> A send-now option could probably solve that :)

I tried doing a quick and dirty but got into an import cycle when trying to
just call :send from code :(


--

Re: [PATCH aerc] send: prevent sending if multipart conversion failed 2 days ago

From Bence Ferdinandy to ~rjarry/aerc-devel

On Sat Apr 13, 2024 at 21:00, Robin Jarry <robin@jarry.cc> wrote:
> Bence Ferdinandy, Apr 13, 2024 at 20:55:
> >
> > On Sat Apr 13, 2024 at 20:51, Vitaly Ovchinnikov <v@ovch.ru> wrote:
> > > > After this patch, I can't :accept invitations anymore. :(
> > >
> > > Could you send me such an invitation privately along with some
> > > instructions on how to reproduce the problem? I never used :accept, so
> > > not sure what to do.
> > >
> > > Overall, we could probably make this behavior optional this or that way,
> > > yet I am not sure if this is the right thing... I'd personally wait for
> > > Robin's decision here.

Re: [PATCH aerc] send: prevent sending if multipart conversion failed 2 days ago

From Bence Ferdinandy to ~rjarry/aerc-devel

On Sat Apr 13, 2024 at 20:51, Vitaly Ovchinnikov <v@ovch.ru> wrote:
> > After this patch, I can't :accept invitations anymore. :(
>
> Could you send me such an invitation privately along with some
> instructions on how to reproduce the problem? I never used :accept, so
> not sure what to do.
>
> Overall, we could probably make this behavior optional this or that way,
> yet I am not sure if this is the right thing... I'd personally wait for
> Robin's decision here.
>
> -- Vitaly