~fhs

Recent activity

Re: [PATCH] Don't initialize /env with host env variables 24 days ago

From Fazlul Shahriar to ~sircmpwn/public-inbox

Ok, now I'm getting "Error: Settle timed out after 120 attempts".
https://builds.sr.ht/~fhs/job/251047

On Thu, Jul 9, 2020 at 9:18 AM Drew DeVault <sir@cmpwn.com> wrote:
>
> Yeah, it's live. This was an unrelated problem, which is solved now.

Re: [PATCH] Don't initialize /env with host env variables 25 days ago

From Fazlul Shahriar to ~sircmpwn/public-inbox

Is this live on builds.sr.ht now? I tried to run something and it
failed with "Unknown image 9front":
https://builds.sr.ht/~fhs/job/250663

On Wed, Jul 8, 2020 at 1:10 PM Drew DeVault <sir@cmpwn.com> wrote:
>
> Thanks! Pushing these upstream now.

[PATCH] Don't initialize /env with host env variables 27 days ago

From Fazlul Shahriar to ~sircmpwn/public-inbox

# HG changeset patch
# User Fazlul Shahriar <fshahriar@gmail.com>
# Date 1594056181 14400
#      Mon Jul 06 13:23:01 2020 -0400
# Node ID 7afe16f1fa6a66a31eeab8032ee47c29489f423d
# Parent  c657240ae8ff48e87ecba552a4c56c6c241eaa57
Don't initialize /env with host env variables

This prevents builds.sr.ht guests from accessing host environment
variables.

diff --git a/kern/devenv.c b/kern/devenv.c
--- a/kern/devenv.c
+++ b/kern/devenv.c
[message trimmed]

Re: [PATCH 3 of 3] cpu: remove /env/PASS to avoid leaking password to the remote system 27 days ago

From Fazlul Shahriar to ~sircmpwn/public-inbox

It needs to be mounted because that's how we get the exit status from
Plan 9 to drawterm. We can however start off with an empty /env by
removing the call to initunix() in kern/devenv.c:/^envattach/, but
that also means drawterm won't have access to environment variables
such as $cpu, $auth, $USER, $PASS, etc. when calling getenv(). That
might be ok depending how drawterm is being used in builds.sr.ht.

On Mon, Jul 6, 2020 at 12:00 PM Drew DeVault <sir@cmpwn.com> wrote:
>
> Can we just totally unmount the host env for the builds.sr.ht drawterm
> fork? I don't want to give guests anything at all by mistake.

[PATCH 3 of 3] cpu: remove /env/PASS to avoid leaking password to the remote system 28 days ago

From Fazlul Shahriar to ~sircmpwn/public-inbox

# HG changeset patch
# User cinap_lenrek@felloff.net
# Date 1593016961 -7200
#      Wed Jun 24 18:42:41 2020 +0200
# Node ID c657240ae8ff48e87ecba552a4c56c6c241eaa57
# Parent  96b769e0caffd7b3d60d2714c8309d86b400525f
cpu: remove /env/PASS to avoid leaking password to the remote system

diff --git a/cpu.c b/cpu.c
--- a/cpu.c
+++ b/cpu.c
@@ -110,7 +110,8 @@
	char *s;

[message trimmed]

[PATCH 2 of 3] Add devenv to provide exit status for rcpu (thanks Fazlul) 28 days ago

From Fazlul Shahriar to ~sircmpwn/public-inbox

# HG changeset patch
# User cinap_lenrek@felloff.net
# Date 1592601495 -7200
#      Fri Jun 19 23:18:15 2020 +0200
# Node ID 96b769e0caffd7b3d60d2714c8309d86b400525f
# Parent  00923ffa8d7863471df5426d3bcc79baac7c252e
Add devenv to provide exit status for rcpu (thanks Fazlul)

Original change applied, but with different handling
of $rstatus using atexit() handler instead of modifying
exportfs read loop.

Also importing plan9 libc getenv().

[PATCH 1 of 3] fix drawterm compiles using gcc 10 28 days ago

From Fazlul Shahriar to ~sircmpwn/public-inbox

# HG changeset patch
# User Ori Bernstein <ori@eigenstate.org>'
# Date 1588022377 25200
#      Mon Apr 27 14:19:37 2020 -0700
# Node ID 00923ffa8d7863471df5426d3bcc79baac7c252e
# Parent  b87549edc3d740dcb6bd35228cffa47f5384dcd6
fix drawterm compiles using gcc 10

-fno-common became the default, and and kmesg was relying
on common symbols being merged.

diff --git a/kern/dat.h b/kern/dat.h
--- a/kern/dat.h
+++ b/kern/dat.h
[message trimmed]

[PATCH 0 of 3] [drawterm] fix exit status for -G flag 28 days ago

From Fazlul Shahriar to ~sircmpwn/public-inbox

Hi,

This copies the following revisions from upstream:

	- 393:8fd96772eb02
	- 398:8d5dee197436
	- 399:9807ebf9d580

Fixes https://todo.sr.ht/~sircmpwn/builds.sr.ht/287