~fintohaps

Recent activity

Release Cycle 2022-09-06 2 months ago

From Fintan Halpenny to ~radicle-link/dev

= Release Cycle 2022-09-06

Tagged-as: e61068b418e008fe567527274221e102a88072db

Long time, no see.

Development has slowed down on radicle-link and more development from
this current team will be focused on two other repositories in the
future as we switch tact slightly:
* https://github.com/radicle-dev/radicle-git
* Soon to be created `radicle` repository

We will still accept changes for fixes and improvments here :)

Release Cycle 2022-09-06 2 months ago

From Fintan Halpenny to ~radicle-link/announce

= Release Cycle 2022-09-06

Tagged-as: e61068b418e008fe567527274221e102a88072db

Long time, no see.

Development has slowed down on radicle-link and more development from
this current team will be focused on two other repositories in the
future as we switch tact slightly:
* https://github.com/radicle-dev/radicle-git
* Soon to be created `radicle` repository

We will still accept changes for fixes and improvments here :)

Re: [PATCH radicle-link v9 0/3] Add integration test for bins and fix bugs found 2 months ago

From Fintan Halpenny to ~radicle-link/dev

LGTM! Can you publish the tag? :)

Re: [PATCH radicle-link v4 0/1] lnk-identities: optionally use initial branch on git clone 2 months ago

From Fintan Halpenny to ~radicle-link/dev

Thanks! Merged :)

Master-at: 904250f533a6482ebfa4bfb7e3660a4982f07ed8

Re: [PATCH radicle-link v6 0/2] Add integration test for bins and fix bugs found 2 months ago

From Fintan Halpenny to ~radicle-link/dev

Also, I noticed that your commits are missing your sign-off, ie. name
and email, as per our DCO policy[0].

[0]: https://github.com/radicle-dev/radicle-link/blob/master/CONTRIBUTING.md#certificate-of-origin

Re: [PATCH radicle-link v3 0/1] lnk-identities: optionally use initial branch on git clone 2 months ago

From Fintan Halpenny to ~radicle-link/dev

Looks good, I had to make a couple of changes to appease clippy and
also noticed that a `Result` was not needed anymore. I amended those
locally.

One last thing I need from you is your sign-off, ie. name and email,
per our DCO policy[0].

[0]: https://github.com/radicle-dev/radicle-link/blob/master/CONTRIBUTING.md#certificate-of-origin

Re: [PATCH radicle-link v8 0/3] Add integration test for bins and fix bugs found 2 months ago

From Fintan Halpenny to ~radicle-link/dev

On Thu Sep 1, 2022 at 7:07 PM IST, Han Xu wrote:
> This is the 8th version (re-rolling) patch to add an integration test for `bins` package.
> It was refactored the patch into 3 commits so that it is clearer to understand the changes.
>
> The test case scenario follows the steps in https://github.com/alexjg/linkd-playground ,
> except it is in Rust now and we can just run `cargo test`. To see a more helpful output,
> please run `cargo test -- --nocapture` from the `bins/tests` directory.
>
> We also found two bugs along the way: 
>
> 1. Git version checks are off. In our testing, it shows that
> git 2.25.1 on Ubuntu 20.04 and git 2.30.2 on Debian 11 do not need the workaround that
> adds "namespaces" manually. Hence fixing the git version check in ls-refs.

Re: [PATCH radicle-link v2 1/1] lnk-identities: optionally use initial branch on git clone 3 months ago

From Fintan Halpenny to ~radicle-link/dev

You need to run `cargo fmt` over `git.rs` :)

On Thu Sep 1, 2022 at 5:46 PM IST, Slack Coder wrote:
> Better follow git's command line behavior by setting one local branch, the
> projects default head, on clone.  It is assumed to be the project
> identities 'default_branch' field.
>
> Implement the new clone argument as optional to keep backward
> compatibility.
> ---
>  cli/lnk-identities/src/git.rs                 | 74 +++++++++++++------
>  cli/lnk-identities/src/git/checkout.rs        | 30 ++++++--
>  .../t/src/tests/git/checkout.rs               |  2 +-
>  3 files changed, 75 insertions(+), 31 deletions(-)

Re: [PATCH radicle-link v6 0/2] Add integration test for bins and fix bugs found 3 months ago

From Fintan Halpenny to ~radicle-link/dev

On Thu Sep 1, 2022 at 11:36 AM IST, Fintan Halpenny wrote:
> On Thu Sep 1, 2022 at 10:34 AM IST, Fintan Halpenny wrote:
> > On Wed Aug 31, 2022 at 6:32 PM IST, Han wrote:
> > > On Wed, Aug 31, 2022 at 9:46 AM Han <keepsimple@gmail.com> wrote:
> > > >
> > > > On Tue, Aug 30, 2022 at 9:38 AM Fintan Halpenny
> > > > <fintan.halpenny@gmail.com> wrote:
> > > > >
> > > > > On Tue Aug 30, 2022 at 1:56 PM IST, Han wrote:
> > > > > > Here it is: https://github.com/keepsimple1/radicle-link/releases/tag/patches%2Fintegration-test-bins%2Fv6
> > > > > >
> > > > > > Sorry I forgot it.
> > > > > >
> > > > > > Han

Re: [PATCH radicle-link v6 0/2] Add integration test for bins and fix bugs found 3 months ago

From Fintan Halpenny to ~radicle-link/dev

On Thu Sep 1, 2022 at 10:34 AM IST, Fintan Halpenny wrote:
> On Wed Aug 31, 2022 at 6:32 PM IST, Han wrote:
> > On Wed, Aug 31, 2022 at 9:46 AM Han <keepsimple@gmail.com> wrote:
> > >
> > > On Tue, Aug 30, 2022 at 9:38 AM Fintan Halpenny
> > > <fintan.halpenny@gmail.com> wrote:
> > > >
> > > > On Tue Aug 30, 2022 at 1:56 PM IST, Han wrote:
> > > > > Here it is: https://github.com/keepsimple1/radicle-link/releases/tag/patches%2Fintegration-test-bins%2Fv6
> > > > >
> > > > > Sorry I forgot it.
> > > > >
> > > > > Han
> > > >