From Fintan Halpenny to ~radicle-link/dev
On Wed Aug 17, 2022 at 1:12 PM IST, Slack Coder wrote: > > This cloning command is to essentially "clone" what's represented in > > the monorepo for that project and make an exact working copy in the > > directory you're cloning to. I suppose it can be thought of as a clone > > and fetch. > Would following git-clones behavior not be better or more accurate? > > Git-clone does the same thing, except the view is different (unless the > --mirror option is used). All local branches on the remote are copied > to the cloned project as remote tracking branches listed under 'git > branch -r'. Keeping these as remote branches would reduce duplication > and is more in line with expectations of people coming from git. > > I am working on radicle-cli, and we're relying on clone via the
From Fintan Halpenny to ~radicle-link/dev
On Tue Aug 16, 2022 at 5:03 PM IST, Slack Coder wrote: > Hi, > > I noticed lnk-identities' git::clone function creates a repository with > multiple local branches. Should this be the case? > > My expectation is to mirror git-clone's behavior which by default > creates one local branch for the project's default branch i.e. 'master'. > > Thanks, > > SlackCoder This cloning command is to essentially "clone" what's represented in
From Fintan Halpenny to ~radicle-link/dev
I'm happy with this :)
From Fintan Halpenny to ~radicle-link/dev
LGTM I'll just note that this is being caused by gitoxide under the hood due to some signal handler shenanigans.
From Fintan Halpenny to ~radicle-link/dev
Could you remove the trailing whitespace that's showing up? :) Something I think we're missing here is the use of server options. Should we mention that they MAY be used in the future to allow for custom gitd behaviour? On Fri Jul 29, 2022 at 10:47 AM IST, Alex Good wrote: > Signed-off-by: Alex Good <alex@memoryandthought.me> > --- > docs/rfc/0704-gitd.adoc | 470 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 470 insertions(+) > create mode 100644 docs/rfc/0704-gitd.adoc > > diff --git a/docs/rfc/0704-gitd.adoc b/docs/rfc/0704-gitd.adoc
From Fintan Halpenny to ~radicle-link/dev
Makes sense to me :) I've rolled it into seen. I'll push to master by EOD and push out a cycle email.
From Fintan Halpenny to ~radicle-link/dev
Remembering file modes and entering them into a text editor is error
prone when a compiler does not check you have done it
correctly. Unfortunately, there was a missing `0` for the file mode
for writing a tree entry.
Use the `FileMode` enum instead and its instance for `Into<i32>`.
The tracked_reference test that is using `quick_commit` was altered to
test that a tree with sub directories can be written.
Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
---
Published-as: https://github.com/FintanH/radicle-link/tree/patches/fix%2Ftree-write%2Fv1
[message trimmed]
From Fintan Halpenny to ~radicle-link/dev
On Thu Jul 14, 2022 at 10:02 PM IST, Alex Good wrote: > Signed-off-by: Alex Good <alex@memoryandthought.me> > --- > docs/rfc/0704-gitd.adoc | 444 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 444 insertions(+) > create mode 100644 docs/rfc/0704-gitd.adoc > > diff --git a/docs/rfc/0704-gitd.adoc b/docs/rfc/0704-gitd.adoc > new file mode 100644 > index 00000000..29ce9821 > --- /dev/null > +++ b/docs/rfc/0704-gitd.adoc > @@ -0,0 +1,444 @@ > += RFC: Gitd
From Fintan Halpenny to ~radicle-link/dev
On Thu Jul 14, 2022 at 10:36 AM IST, Alex Good wrote: > On 12/07/22 02:42pm, Fintan Halpenny wrote: > > diff --git a/cli/lnk-identities/src/person.rs b/cli/lnk-identities/src/person.rs > > index 7e409018..f00d58a1 100644 > > --- a/cli/lnk-identities/src/person.rs > > +++ b/cli/lnk-identities/src/person.rs > > @@ -217,3 +217,15 @@ where > > let _guard = get(storage, urn)?.ok_or_else(|| identities::Error::NotFound(urn.clone()))?; > > Ok(identities::relations::tracked(storage, urn)?) > > } > > + > > +pub fn delegates<S, P>(storage: &S, urn: &Urn, peer: P) -> Result<Vec<PublicKey>, Error> > > +where > > + S: AsRef<ReadOnly>,
From Fintan Halpenny to ~radicle-link/dev
Whoops, missed all the important details! Mirrors: - github.com:FintanH/radicle-link.git - git.sr.ht:~fintohaps/radicle-link - rad:git:hnrkxafojjsz4m55qxbwigh1z8sdt7mai81gy Master-At: 541a8161cb24c3b7b10d44f958cc5c5ed05cf443 Seen-At: cd43dfb203c9f457179a3ae4722dfa8bde3f897e