On Thu Jan 14, 2021 at 7:19 AM CET, Reto wrote:
> Time appropriate greetings,
> Thanks for the patch.
>
> On Tue, Jan 12, 2021 at 09:58:54PM +0100, Robin Opletal wrote:
> > +	// Used to handle "/", "." and ".." in filenames correctly
>
> When I said add a comment explaining why I meant something a bit more
> descriptive ;)
> Anyhow, fixed it up locally and merged it.
> I also took the liberty to change the if chain to a switch statement,
> which
> hopefully helps the reader a bit.
>

On Tue Jan 12, 2021 at 9:55 PM CET, Reto wrote:

> Maybe https://git-send-email.io/ helps?

Thanks - went through it once, should probably rinse and repeat.

> If you mean some other feature, you need to send that as a separate
> patch.
> The way patch sets work is that they should bundle commits of a single
> "feature"

It's the same patch, with a fix in a second commit which, instead of
ammending to the previous commit I have made another commit.

---
 commands/msgview/save.go | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/commands/msgview/save.go b/commands/msgview/save.go
index ef6bba8..375be96 100644
--- a/commands/msgview/save.go
+++ b/commands/msgview/save.go
@@ -182,7 +182,10 @@ func generateFilename(part *models.BodyStructure) string {
 		filename = fn
 	} else if fn, ok := part.Params["name"]; ok {
 		filename = fn
-	} else {
+	}
[message trimmed]

On Tue Jan 12, 2021 at 9:31 PM CET, Reto wrote:
> Hi Robin,
> Thanks for the patch.
> However it does not seem to apply for me... is this the latest patch?
> There were some hiccups along the way I think, care to resend?

Hi Reto, thank you for reviewing the patch.

Yeah, I am not quite used to using git-send-email yet. Have to spend
some more time with it to get comfortable.

I am thinking what the best way would be to send both of the commits
that I have made as a single patch? Probably send it as a "new" patch
without any annotate?

On Thu Jan 7, 2021 at 11:58 AM CET, Robin Opletal wrote:
> On Thu Jan 7, 2021 at 11:38 AM CET, Simon Ser wrote:
> > This fixes up the wrong line -- now there are two lines with spaces
> > instead of tabs.
> >
> > You can use `go fmt ./...` to fix everything.
>
> Thanks for letting me know. Fixed in another patch.

It would also be good if I started using git commit --ammend, huh....

On Thu Jan 7, 2021 at 11:38 AM CET, Simon Ser wrote:
> This fixes up the wrong line -- now there are two lines with spaces
> instead of tabs.
>
> You can use `go fmt ./...` to fix everything.

Thanks for letting me know. Fixed in another patch.

---
 commands/msgview/save.go | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/commands/msgview/save.go b/commands/msgview/save.go
index 7649a5f..375be96 100644
--- a/commands/msgview/save.go
+++ b/commands/msgview/save.go
@@ -181,10 +181,10 @@ func generateFilename(part *models.BodyStructure) string {
 	if fn, ok := part.DispositionParams["filename"]; ok {
 		filename = fn
 	} else if fn, ok := part.Params["name"]; ok {
-                filename = fn
-        }
[message trimmed]

---
 commands/msgview/save.go | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/commands/msgview/save.go b/commands/msgview/save.go
index ef6bba8..7649a5f 100644
--- a/commands/msgview/save.go
+++ b/commands/msgview/save.go
@@ -181,8 +181,11 @@ func generateFilename(part *models.BodyStructure) string {
 	if fn, ok := part.DispositionParams["filename"]; ok {
 		filename = fn
 	} else if fn, ok := part.Params["name"]; ok {
-		filename = fn
-	} else {
[message trimmed]

---
 commands/msgview/save.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/msgview/save.go b/commands/msgview/save.go
index 014c204..dd09f19 100644
--- a/commands/msgview/save.go
+++ b/commands/msgview/save.go
@@ -181,7 +181,7 @@ func generateFilename(part *models.BodyStructure) string {
 	if fn, ok := part.DispositionParams["filename"]; ok {
                 filename = filepath.Base(fn)
 	} else if fn, ok := part.Params["name"]; ok {
-		filename = filepath.Base(fn)
+                filename = filepath.Base(fn)
[message trimmed]

---
 commands/msgview/save.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/commands/msgview/save.go b/commands/msgview/save.go
index ef6bba8..014c204 100644
--- a/commands/msgview/save.go
+++ b/commands/msgview/save.go
@@ -179,9 +179,9 @@ func isAbsPath(path string) bool {
 func generateFilename(part *models.BodyStructure) string {
 	var filename string
 	if fn, ok := part.DispositionParams["filename"]; ok {
-		filename = fn
+                filename = filepath.Base(fn)
[message trimmed]