[PATCH libtags] Don't null-terminate already null-terminated strings

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

[PATCH libtags] Don't null-terminate already null-terminated strings

jacqueline <me@jacqueline.id.au>

Details

Message ID: <20230731022844.5205-1-me@jacqueline.id.au>
DKIM signature: missing

Download raw message

1 year, 7 months ago

Patch: +2 -1

This was causing issues with genre tags sourced from id3genres (I think
all m4a files with genres might be affected?). id3genres is const, so
even when the write is a no-op, attempting it caused a segfault
---
 tags.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tags.c b/tags.c
index 6c6b2b5..815a3e4 100644
--- a/tags.c
+++ b/tags.c
@@ -46,7 +46,8 @@ tagscallcb(Tagctx *ctx, int type, const char *k, char *s, int offset, int size,
 		e = s + strlen(s);
 		while(e != s && (uchar)e[-1] <= ' ')
 			e--;
-		*e = 0;
+		if (*e != 0)
+		  *e = 0;
 	}
 	if(*s){
 		ctx->tag(ctx, type, k, s, offset, size, f);
-- 
2.40.1

~ft/public-inbox

[PATCH libtags] Don't null-terminate already null-terminated strings