I also checked mercury and after this patch, it also needs the same
inversion in its loader [1].
 Gilles

[1]: https://git.sr.ht/~sircmpwn/mercury/tree/master/item/cmd/sysinit/loader.ha#L135

Hi Drew,
Yes, i have tested that `make check` still works as much as before
those changes.
On aarch64, all tests pass except

task::pagefault................. Abort: helios/endpoint.ha:84:22:
assertion failed

At least for me this fails on master as well. I have not checked what
this is about.

Note that i also tested that with this patch, the X flag handling in
x86_64's arch_flags [1] can also be uncommented and it works.
Before this patch, uncommenting that would cause a fault. I wasn't

See https://git.sr.ht/~sircmpwn/harec/commit/d31057140ed3975dc258e9e25fca8105d3eec1de
---
I've seen this fail the automated build when submitting some other patch

 boot/+x86_64/rt.ha             | 2 --
 encoding/utf8/decode.ha        | 1 -
 log/fmt.ha                     | 1 -
 vulcan/encoding/utf8/decode.ha | 1 -
 vulcan/log/fmt.ha              | 1 -
 5 files changed, 6 deletions(-)

diff --git a/boot/+x86_64/rt.ha b/boot/+x86_64/rt.ha
index 4136401..5489783 100644
--- a/boot/+x86_64/rt.ha
[message trimmed]

OK, thanks. I have sent a patch to do that.
 Gilles

Use that definition in init::phdr_load and flip usage in aarch64's
objects::arch_flags.
---
 init/load.ha                    | 2 +-
 objects/+aarch64/arch_vspace.ha | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/init/load.ha b/init/load.ha
index b485b6c..1d407ab 100644
--- a/init/load.ha
+++ b/init/load.ha
@@ -63,7 +63,7 @@ fn phdr_load(task: *task, image: *elf::header64, ph: *elf::phdr64) void = {
 	assert(npage <= types::UINT_MAX);
 
[message trimmed]

Hi,

I'm a bit unsure about the current meaning of map_flags::X.
Code in init::phdr_load [1] and aarch64's objects::arch_flags [2] seem
to imply that when this flag is set, execution should _not_ be
permitted. However, both some commented out code in x86_64's
objects::arch_flags [3] and common *nix convention would point at "X"
meaning execution should be permitted.
Could anyone clarify the intention?

Thanks,
 Gilles

[1]: https://git.sr.ht/~sircmpwn/helios/tree/b42edc26a6da70ef93f46b0a0461d51f2b3b1a3a/item/init/load.ha#L66-68

---
Fix the issue raised by the bot.

 gdub | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 gdub

diff --git a/gdub b/gdub
new file mode 100644
index 0000000..66cb3d4
--- /dev/null
+++ b/gdub
@@ -0,0 +1 @@
+I have successfully used git send-email!
[message trimmed]

On Sun, 10 Dec 2023 at 19:20, git-send-email.io <devnull@sr.ht> wrote:
> Thanks for the patch! Needs a minor fix, though:

OK, i'm on it
 Gilles

---
 gdub | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 gdub

diff --git a/gdub b/gdub
new file mode 100644
index 0000000..6d0ecfd
--- /dev/null
+++ b/gdub
@@ -0,0 +1 @@
+I'm about to try git send-email
-- 
2.43.0
[message trimmed]