~gjnoonan

England

https://gjnoonan.co.uk

~gjnoonan/public-inbox

Last active 6 months ago

~gjnoonan/test

Last active 7 months ago

~gjnoonan/emacs-pagerduty

Last active 5 years ago
View more

Recent activity

Re: [PATCH gcli] cmd: Add a way to disable mardown rendering when built with lowdown support 3 months ago

From Gavin-John Noonan to ~herrhotzenplotz/gcli-devel

On Sat Oct 19, 2024 at 9:33 PM UTC, Nico Sonack wrote:
> Fixes #240
240 where? please provide a link, also the trailer format is invalid, it 
needs to be in the form of `Key: value`

Fixes: https://gitlab.com/herrhotzenplotz/gcli/issues/240

> @@ -479,6 +480,9 @@ readenv(struct gcli_config *cfg)
>  	if ((tmp = getenv("GCLI_NOSPINNER")))
>  		cfg->no_spinner = check_yes(tmp);
>  
> +	if ((tmp = getenv("GCLI_RENDER_MARKDOWN")))
> +		cfg->no_markdown = !check_yes(tmp);
The logic here always takes me a second to think through, since we want

Re: [PATCH gcli] Makefile.in: fix makefile installation yet again 5 months ago

From Gavin-John Noonan to ~herrhotzenplotz/gcli-devel

Nico Sonack, Aug 22, 2024 at 14:52:
> BSD Make removes newlines in macros. The call to read was not
> producing the expected result for this reason.
>
> Change it to a shell for-loop which will split on words.
>
> Fixes: dea88294 (docs: Install manual pages into the correct directory, 2024-08-16)
> Signed-off-by: Nico Sonack <nsonack@herrhotzenplotz.de>

Applied. Thanks!

-g

Re: [PATCH gcli 1/3] Makefile: Fix dependencies of test programs 5 months ago

From Gavin-John Noonan to ~herrhotzenplotz/gcli-devel

Applied and pushed the whole series. Thanks!

-g

Re: [PATCH gcli] Fix compilation with GCC 14 5 months ago

From Gavin-John Noonan to ~herrhotzenplotz/gcli-devel

Nico Sonack, Aug 19, 2024 at 18:47:
> gcc 14 introduced a new silly warning flag -Wcalloc-transposed-args
> that is enabled by default.
>
> Fix by swapping all the arguments to calloc causing trouble by this
> new warning.
>
> Signed-off-by: Nico Sonack <nsonack@herrhotzenplotz.de>

Applied. Thanks!

Re: [PATCH gcli v2 1/3] Bump required C Language Standard to C11 5 months ago

From Gavin-John Noonan to ~herrhotzenplotz/gcli-devel

Nico Sonack, Aug 16, 2024 at 19:17:
> We have made this decision after thinking and discussing. Reasons are:
>
>  - C99 is now 25 years old and one can safely assume that any modern system
>    supports it - C11 is now 13 years old and all platforms that we have
>    tested so far have been supporting C11 for years now. This also applies
>    to all the compilers we have been using to build gcli so far.
>  - Compatibility with more optional libraries
>    I plan to integrate the lowdown library for Markdown rendering. It requires
>    C11. I have previously encountered such a case too.
>  - More modern language features:
>    We can now use anonymous unions and static assertions.
>  - gcli is a tool for a modern development workflow:
>    Thus we can assume a reasonably modern system - where C11 is supported.

Re: [PATCH gcli 2/2] Integrate lowdown for Markdown rendering 5 months ago

From Gavin-John Noonan to ~herrhotzenplotz/gcli-devel

On Fri Aug 16, 2024 at 4:46 PM UTC, Nico Sonack wrote:
> This optionally integrates the lowdown Markdown library.
>
> It is used for rendering Markdown on the terminal. Colour handling
> has been integrated - for that reason I had to move the pretty_print
> routine into the main gcli code and also removed the test because
> the results would now be different when printed with lowdown.
>
> diff --git a/Makefile.in b/Makefile.in

Can we split this patch up and separate moving the pretty_print code 
and removing the test, from the adding of lowdown support.

What do you think about adding some config for this too,

Re: [PATCH patchbot] main: correct module name 6 months ago

From Gavin-John Noonan to ~gjnoonan/public-inbox

On Sat Jul 20, 2024 at 3:57 AM UTC, Oliver Lowe wrote:
> -module git.sr.ht~/gjnoonan/patchbot
> +module git.sr.ht/~gjnoonan/patchbot

Thanks for the patch, I have already fixed this locally. I am mid-way 
through rebasing a stack of patches, then got distracted and have not 
pushed up the newer changes.

-g

Re: [PATCH] pcap: implement decoding 6 months ago

From Gavin-John Noonan to ~otl/untangledco

On Fri Jul 19, 2024 at 10:25 AM UTC, Joshua Callary wrote:
> From: Joshua Callary <62225867+Rinzler1011@users.noreply.github.com>

> +type PcapHeader struct {
We are within the PCAP package, so we can avoid possible stuttering and 
name things as they are here, thus this can become `Header`. This 
comment applies throughout.

> +func ReadPcapFile(filePath string) (*PcapFile, error) {
This func isn't needed, readPcap (as it is currently called) takes 
an io.Reader. It is more idiomatic to open the file then pass to the 
Reader, without a helper.

> +func readPcap(reader io.Reader) (*PcapFile, error) {

Re: [PATCH v2 1/3] cmdconfig: simplify checkyes 6 months ago

From Gavin-John Noonan to ~herrhotzenplotz/gcli-devel

On Thu Jul 18, 2024 at 5:25 PM UTC, Gavin-John Noonan wrote:
> +	int isYes = strcmp(tmp_lower, "1") == 0 ||
> +		strcmp(tmp_lower, "yes") == 0 ||
Apologies, this must've got messed up during the rebase splitting the 
code. If needed I can send v3, but this is an easy fix when/if you 
apply.

-g