~gjnoonan

England

https://gjnoonan.co.uk

~gjnoonan/test

Last active 3 months ago

~gjnoonan/public-inbox

Last active 4 years ago

~gjnoonan/emacs-pagerduty

Last active 4 years ago
View more

Recent activity

Re: [PATCH gcli] ui: teach gcli when to disable the progress spinner 2 days ago

From Gavin-John Noonan to ~herrhotzenplotz/gcli-devel

On Thu Jun 13, 2024 at 8:43 PM UTC, Nico Sonack wrote:
> This condition is incorrect. When the variable is set to true we do not want 
> to show the spinner (and thus return false). I will fix this up.
Ah yes, I've just looked again and the logic I added in 
src/cmd/gcli.c:main is inverted. I thought I was going crazy for a while 
when the config was set and it worked.

Thanks for fixing up the various mistakes, I would have been happy to 
send v2

-g

Re: [PATCH gcli] gitlab: reverse list of comments 2 days ago

From Gavin-John Noonan to ~herrhotzenplotz/gcli-devel

Applied. Thanks

-g

[PATCH gcli] ui: teach gcli when to disable the progress spinner 2 days ago

From Gavin-John Noonan to ~herrhotzenplotz/gcli-devel

GCLI will display a progress spinner whilst processing, and making
external requests via curl. This can be quite jarring when both not
running in a TTY, or using a dumb terminal. Some people may just wish
to not see it.

gcli has been taught to disable the progress spinenr when configured to
to so. This can be configured in one of three ways.

  1) setting GCLI_NOSPINNER to 1/true in the ENV
  2) passing --no-spinner as an argument to the `gcli` command
  3) in your global .gcli. config you can set `disable-spinner=true` in
     the default section

Signed-off-by: Gavin-John Noonan <mail@gjnoonan.co.uk>
[message trimmed]

Re: [PATCH] Fix CI distcheck 11 days ago

From Gavin-John Noonan to ~herrhotzenplotz/gcli-devel

Applied and pushed To All remotes. Thanks!

The CI step for FreeBSD is still failing on gitlab, I think this is due 
to a caching issue which I can look into later. You can see a successful 
FreeBSD build here: https://builds.sr.ht/~gjnoonan/job/1242643

-g

Re: [PATCH] Gitlab: Improve API error message handling 27 days ago

From Gavin-John Noonan to ~herrhotzenplotz/gcli-devel

Nico Sonack, May 17, 2024 at 15:08:
> Somewhat related to b729ac0800b8b0b1ec61b9ac3cc37e78f320c14d.
When referencing other commits, we can ask git to provide some more information
which adds context and is useful for commit message--or indeed just mentioning a
commit in general.

  $ git log -1 --format=reference b729ac0800b8b0b1ec61b9ac3cc37e78f320c14d
  b729ac0 (Prevent segmentation fault in 404 cases on Gitlab, 2023-12-23)

I have applied the patch, and pushed to all remotes. Thanks!

- g

Re: [PATCH] pgen: Remove libsn and manually compile against sn.c 2 months ago

From Gavin-John Noonan to ~herrhotzenplotz/gcli-devel

Nico Sonack, Mar 18, 2024 at 19:41:
> A linker error occurred while testing on Haiku/x86_64 where errx
> was undefined. Use our portability code for errx.
>
> The reason why I removed libsn is that I don't want to have libsn
> as a pre-make-all dependency.
>
> Also it is impossible to build sn.c with and without libtool.
>

Applied and pushed. Thanks