Nico Sonack, Aug 22, 2024 at 14:52:
> BSD Make removes newlines in macros. The call to read was not
> producing the expected result for this reason.
>
> Change it to a shell for-loop which will split on words.
>
> Fixes: dea88294 (docs: Install manual pages into the correct directory, 2024-08-16)
> Signed-off-by: Nico Sonack <nsonack@herrhotzenplotz.de>

Applied. Thanks!

-g

Applied and pushed the whole series. Thanks!

-g

Nico Sonack, Aug 19, 2024 at 18:47:
> gcc 14 introduced a new silly warning flag -Wcalloc-transposed-args
> that is enabled by default.
>
> Fix by swapping all the arguments to calloc causing trouble by this
> new warning.
>
> Signed-off-by: Nico Sonack <nsonack@herrhotzenplotz.de>

Applied. Thanks!

Nico Sonack, Aug 16, 2024 at 19:17:
> We have made this decision after thinking and discussing. Reasons are:
>
>  - C99 is now 25 years old and one can safely assume that any modern system
>    supports it - C11 is now 13 years old and all platforms that we have
>    tested so far have been supporting C11 for years now. This also applies
>    to all the compilers we have been using to build gcli so far.
>  - Compatibility with more optional libraries
>    I plan to integrate the lowdown library for Markdown rendering. It requires
>    C11. I have previously encountered such a case too.
>  - More modern language features:
>    We can now use anonymous unions and static assertions.
>  - gcli is a tool for a modern development workflow:
>    Thus we can assume a reasonably modern system - where C11 is supported.

On Fri Aug 16, 2024 at 4:46 PM UTC, Nico Sonack wrote:
> This optionally integrates the lowdown Markdown library.
>
> It is used for rendering Markdown on the terminal. Colour handling
> has been integrated - for that reason I had to move the pretty_print
> routine into the main gcli code and also removed the test because
> the results would now be different when printed with lowdown.
>
> diff --git a/Makefile.in b/Makefile.in

Can we split this patch up and separate moving the pretty_print code 
and removing the test, from the adding of lowdown support.

What do you think about adding some config for this too,

On Sat Jul 20, 2024 at 3:57 AM UTC, Oliver Lowe wrote:
> -module git.sr.ht~/gjnoonan/patchbot
> +module git.sr.ht/~gjnoonan/patchbot

Thanks for the patch, I have already fixed this locally. I am mid-way 
through rebasing a stack of patches, then got distracted and have not 
pushed up the newer changes.

-g

On Fri Jul 19, 2024 at 10:25 AM UTC, Joshua Callary wrote:
> From: Joshua Callary <62225867+Rinzler1011@users.noreply.github.com>

> +type PcapHeader struct {
We are within the PCAP package, so we can avoid possible stuttering and 
name things as they are here, thus this can become `Header`. This 
comment applies throughout.

> +func ReadPcapFile(filePath string) (*PcapFile, error) {
This func isn't needed, readPcap (as it is currently called) takes 
an io.Reader. It is more idiomatic to open the file then pass to the 
Reader, without a helper.

> +func readPcap(reader io.Reader) (*PcapFile, error) {

On Thu Jul 18, 2024 at 5:25 PM UTC, Gavin-John Noonan wrote:
> +	int isYes = strcmp(tmp_lower, "1") == 0 ||
> +		strcmp(tmp_lower, "yes") == 0 ||
Apologies, this must've got messed up during the rebase splitting the 
code. If needed I can send v3, but this is an easy fix when/if you 
apply.

-g

Throughout the codebase we generally use snake_case for functions.

Signed-off-by: Gavin-John Noonan <mail@gjnoonan.co.uk>
---
 src/cmd/cmdconfig.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/cmd/cmdconfig.c b/src/cmd/cmdconfig.c
index e5628975..df715f26 100644
--- a/src/cmd/cmdconfig.c
+++ b/src/cmd/cmdconfig.c
@@ -433,7 +433,7 @@ ensure_config(struct gcli_ctx *ctx)
 
 /** Check input for a value that indicates yes/true */
[message trimmed]

Currently when parsing config and checking for a truthy value we only
allow a variation of the word "yes" (e.g: yEs, YeS, etc) or the numeral
1, but not actually the word true.

Here we teach the checkyes function to also check for a variation of the
word true (e.g: true, True, TrUe, etc)

Signed-off-by: Gavin-John Noonan <mail@gjnoonan.co.uk>
---
 src/cmd/cmdconfig.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/cmd/cmdconfig.c b/src/cmd/cmdconfig.c
index 4217d567..e5628975 100644
[message trimmed]