Change texture of ATC rail v1 REJECTED

56independent: 1
  Change texture of ATC rail

 2 files changed, 1 insertions(+), 1 deletions(-)

[PATCH] Change texture of ATC rail Export this patch

commit 40ac549f64ac3f88540a8d92b4ea6532ff19e217 (HEAD -> master)
Author: 56independent <emailchecker506@gmail.com>
Date:   Thu Feb 24 13:39:34 2022 +0000

    Change texture of ATC rail

diff --git a/advtrains/textures/advtrains_dtrack_shared_atc_pink.png b/advtrains/textures/advtrains_dtrack_shared_atc_pink.png
new file mode 100755
index 0000000..ba94b79
Binary files /dev/null and b/advtrains/textures/advtrains_dtrack_shared_atc_pink.png differ
diff --git a/advtrains_luaautomation/atc_rail.lua b/advtrains_luaautomation/atc_rail.lua
index 5dde99c..f5819d4 100644
--- a/advtrains_luaautomation/atc_rail.lua
+++ b/advtrains_luaautomation/atc_rail.lua
@@ -186,7 +186,7 @@ advtrains.register_tracks("default", {
        texture_prefix="advtrains_dtrack_atc",
        models_prefix="advtrains_dtrack",
        models_suffix=".b3d",
-       shared_texture="advtrains_dtrack_shared_atc.png",
+       shared_texture="advtrains_dtrack_shared_atc_pink.png",

ywang <yw05@forksworld.de>

2 years ago

This file is not present in the Git repo. Please include the texture
file in the patch.

Next

        description=atltrans("LuaATC Rail"),
        formats={},
        get_additional_definiton = function(def, preset, suffix, rotation)































Use above with my texture at https://i.imgur.com/r4x7Too.png

ywang <yw05@forksworld.de>

2 years ago

This is not appreciated. One of the reasons for sending _everything_ in
a patch file is that it makes it easy to apply patches as certain email
clients (e.g. mu4e) allow you to directly pipe the email (and the patch)
to git-apply. This also means that the result is guranteed to be the
same, as "use with this texture file" can result in the file being put
at different places; this is not important here, but can be significant
in certain cases.

ywang <yw05@forksworld.de>

2 years ago

I will reject the patch for now considering that this patch does not
apply and the relevant issues are not addressed.