~graywolf/public-inbox

2 2

[PATCH acme-client-portable] Fix compatibility with LibreSSL 3.5

Ruud van Asseldonk <ruud@veniogames.com>
Details
Message ID
<78e2881e-05ea-ebe2-6d40-5504041c5c4d@veniogames.com>
DKIM signature
pass
Download raw message
LibreSSL 3.5 now supports the same interface as OpenSSL, so the 
compatibility macros are no longer needed, and in fact they break 
compatibility with LibreSSL 3.5, so we can just delete them.

This breaks compatibility with LibreSSL 3.4, which does not support this 
interface. I think this is acceptable; if you are using a recent 
acme-client, you should probably also be using a recent LibreSSL, but if 
you want to keep compatibility with both, we could keep the macro and 
make it check the version number.


Best,
Ruud
Details
Message ID
<YvA7NkBgS08PteTl@ws>
In-Reply-To
<78e2881e-05ea-ebe2-6d40-5504041c5c4d@veniogames.com> (view parent)
DKIM signature
pass
Download raw message
First, sorry for a bit late response, I did not manage to find a time to
look into this sooner.

On 2022-07-23 12:08:08 +0200, Ruud van Asseldonk wrote:
> LibreSSL 3.5 now supports the same interface as OpenSSL, so the
> compatibility macros are no longer needed, and in fact they break
> compatibility with LibreSSL 3.5, so we can just delete them.
> 
> This breaks compatibility with LibreSSL 3.4, which does not support this
> interface. I think this is acceptable; if you are using a recent
> acme-client, you should probably also be using a recent LibreSSL, but if you
> want to keep compatibility with both, we could keep the macro and make it
> check the version number.

I think it's fine to cut off the 3.4 at this point, 3.5 is old enough to
be reasonable to expect people to use it.

Thank you for the patch, once the tests finish running, I will merge it
into a master and make a patch release.

W.

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
Ruud van Asseldonk <ruud@veniogames.com>
Details
Message ID
<958bf00d-77ef-293a-2c46-8d2b59c3f0e9@veniogames.com>
In-Reply-To
<YvA7NkBgS08PteTl@ws> (view parent)
DKIM signature
pass
Download raw message
Thank you for making the new release!

Wolf wrote:
> First, sorry for a bit late response, I did not manage to find a time to
> look into this sooner.

No need to apologize, nobody is entitled to your time. Iā€™m glad that you 
are maintaining the package at all :)

Best,
Ruud
Reply to thread Export thread (mbox)