Date: Mon, 8 Aug 2022 00:22:46 +0200
From: Wolf <wolf@wolfsden.cz>
To: Ruud van Asseldonk <ruud@veniogames.com>
Cc: ~graywolf/public-inbox@lists.sr.ht
Subject: Re: [PATCH acme-client-portable] Fix compatibility with LibreSSL 3.5
Message-ID: <YvA7NkBgS08PteTl@ws>
Mail-Followup-To: Ruud van Asseldonk <ruud@veniogames.com>,
	~graywolf/public-inbox@lists.sr.ht
References: <78e2881e-05ea-ebe2-6d40-5504041c5c4d@veniogames.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="T3zZrrhJeyUfvzRo"
Content-Disposition: inline
In-Reply-To: <78e2881e-05ea-ebe2-6d40-5504041c5c4d@veniogames.com>


--T3zZrrhJeyUfvzRo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

First, sorry for a bit late response, I did not manage to find a time to
look into this sooner.

On 2022-07-23 12:08:08 +0200, Ruud van Asseldonk wrote:
> LibreSSL 3.5 now supports the same interface as OpenSSL, so the
> compatibility macros are no longer needed, and in fact they break
> compatibility with LibreSSL 3.5, so we can just delete them.
>=20
> This breaks compatibility with LibreSSL 3.4, which does not support this
> interface. I think this is acceptable; if you are using a recent
> acme-client, you should probably also be using a recent LibreSSL, but if =
you
> want to keep compatibility with both, we could keep the macro and make it
> check the version number.

I think it's fine to cut off the 3.4 at this point, 3.5 is old enough to
be reasonable to expect people to use it.

Thank you for the patch, once the tests finish running, I will merge it
into a master and make a patch release.

W.

--=20
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

--T3zZrrhJeyUfvzRo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmLwOzYACgkQL7/ufbZ/
wamfIRAApMtGj5g5GL7Qwrw9MfFGqcP5n2KB0sn3VhUhI5/ZhqpF8xJlBGAASXbR
kYbCMoTc4CNc/mpTJP2T6OI4FEmdQPMzl6/2LuGtItplvJ70lrMvMWOeXbIIRC7n
BCpBjkBkywBwuRMTsO5C4WnDGyxk2OzlIQcUUq1nsK8yA/uZdqUc+f89xX/LIDuu
jYM2rHIJc70Ur60TgVirwgMXg5h4vi6SC9PC8eZlZIrmK/TDU4+5khZBcacUCAod
AFa/oxpktRG8WpKEhx5UqCvOn10NYi9zhbImDpyNdJw2ENSbh8e82kcUTq+7BCsV
xyjz4tUrwjUFDFHdALqwevKIyyGRpAcmcDlUoBOdL3cKufF+fJzQrKOvIWAsaobT
ZVpCy3+9TO1CgxrevJsC04DYVqw93kTxWOXF4Od5NhJtOiAjGUe0sQWpCZs+7plo
reFxMTa+Vee6aqRoYEFhvXdYMOLhyZal0POOfe9kxDqR7IdrXCsUcN0I+8mvkDhp
W3fIsZQlEGpxEareFyNNwVglmg0tjcpeqo3QfTCd/AklFsj/ZmdeQxeIlHN6CO6X
cFLfHSwCocCMquCWIo3wNcMuPOnop+lJjL5bsuqldD11T60dBAXjw4wC6SVsa1ZP
WaKhVBhd10wN5KDzovKNnIdHhs0rSdnmginkvhvDW2+RsW8rUt0=
=kxCU
-----END PGP SIGNATURE-----

--T3zZrrhJeyUfvzRo--