On Mon May 27, 2024 at 11:49 AM BST, Drew DeVault wrote:
> Everyone listed here is in the CC. Please reply with your consent to
> relicense your work under the GNU FDL.

I consent.

favicon.svg is copied from core.sr.ht's srht/static/logo.svg.
---
Changes since v1:
- Rolled up the changes into the existing branding patch

 ...Add-sourcehut-branding-to-chat.sr.ht.patch | 27 ++++++++++++++-----
 sr.ht/gamja/APKBUILD                          |  4 +--
 2 files changed, 22 insertions(+), 9 deletions(-)

diff --git a/sr.ht/gamja/0001-Add-sourcehut-branding-to-chat.sr.ht.patch b/sr.ht/gamja/0001-Add-sourcehut-branding-to-chat.sr.ht.patch
index e0d34e7..c9d9bd4 100644
--- a/sr.ht/gamja/0001-Add-sourcehut-branding-to-chat.sr.ht.patch
+++ b/sr.ht/gamja/0001-Add-sourcehut-branding-to-chat.sr.ht.patch
@@ -1,4 +1,4 @@
[message trimmed]

---
Can merge this into the other favicon patch on request.

 ...ake-favicon-visible-in-a-light-theme.patch | 33 +++++++++++++++++++
 sr.ht/gamja/APKBUILD                          |  4 ++-
 2 files changed, 36 insertions(+), 1 deletion(-)
 create mode 100644 sr.ht/gamja/0002-Make-favicon-visible-in-a-light-theme.patch

diff --git a/sr.ht/gamja/0002-Make-favicon-visible-in-a-light-theme.patch b/sr.ht/gamja/0002-Make-favicon-visible-in-a-light-theme.patch
new file mode 100644
index 0000000..d26c6a7
--- /dev/null
+++ b/sr.ht/gamja/0002-Make-favicon-visible-in-a-light-theme.patch
@@ -0,0 +1,33 @@
[message trimmed]

---
 v1.0.0.myco | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/v1.0.0.myco b/v1.0.0.myco
index 04213f2..b9a11c6 100644
--- a/v1.0.0.myco
+++ b/v1.0.0.myco
@@ -21,7 +21,7 @@ See the [[installation.html | installation guide]]. If you are using any older r
 
 == Developers
 * [[https://links.bouncepaw.com | bouncepaw]] did most of the work.
-* [[https://links.handlerug.me | handlerug]] implemented the bookmarklet.
+* [[https://handlerug.me | handlerug]] implemented the bookmarklet.
[message trimmed]

On Fri Jun 30, 2023 at 8:28 PM +03, Simon Ser wrote:
> On Friday, June 30th, 2023 at 19:13, Umar Getagazov <umar@handlerug.me> wrote:
> > On Fri Jun 30, 2023 at 8:11 PM +03, Simon Ser wrote:
> > > Note, this means that the new pattern syntax will become part of our API.
> > > 
> > > Looks fine to me.
> > 
> > But it's not documented anywhere. Shouldn't it be treated the same as
> > before?
>
> What do you mean?

I'm not sure what you meant by "the new pattern syntax will become part 
of our API" if the only change is to the implementation, not

On Fri Jun 30, 2023 at 8:11 PM +03, Simon Ser wrote:
> Note, this means that the new pattern syntax will become part of our API.
>
> Looks fine to me.

But it's not documented anywhere. Shouldn't it be treated the same as 
before?

Now thinking if glob should've been left as is and instead regular 
expression matching should've been added...

On Fri Jun 30, 2023 at 7:54 PM +03, Umar Getagazov wrote:
> This is fully backwards-compatible, AFAIC. The only change the usage of
> this library brings is the addition of '/**/'.

Oh and this is somewhat incorrect, it also adds alternatives (e.g. 
"*.{txt,rtf,doc}" for matching "abc.txt", "abc.rtf", "abc.doc"). I don't 
think this is a huge deal, though.

This allows to use recursive patterns like "**/*.txt". Go's path.Match
only allows explicit nesting, so to accomplish the same thing you'd need
to duplicate the same pattern multiple times with different amount of
asterisks ("*.txt", "*/*.txt", "*/*/*.txt"), depending on how deep your
site's directory structure is.
---
This is fully backwards-compatible, AFAIC. The only change the usage of
this library brings is the addition of '/**/'.

Changes since v1:
- Fixed the library version (was unspecified i.e. v1, now v4)

 go.mod                    | 1 +
 go.sum                    | 2 ++
[message trimmed]

On Fri Jun 30, 2023 at 7:51 PM +03, Simon Ser wrote:
> This uses doublestar v1. We probably want to use the latest version, v4.

Damn, I think I ran go get with the correct version but then added an 
import line without the version specified. Thanks for pointing this out, 
will send a revision!

This allows to use recursive patterns like "**/*.txt". Go's path.Match
only allows explicit nesting, so to accomplish the same thing you'd need
to duplicate the same pattern multiple times with different amount of
asterisks ("*.txt", "*/*.txt", "*/*/*.txt"), depending on how deep your
site's directory structure is.
---
This is fully backwards-compatible, AFAIC. The only change the usage of
this library brings is the addition of '/**/'.

 go.mod                    | 1 +
 go.sum                    | 2 ++
 graph/schema.resolvers.go | 3 ++-
 3 files changed, 5 insertions(+), 1 deletion(-)
[message trimmed]