> If SXMO_MIN_BRIGHTNESS > 5, and the brightness gets set to
> SXMO_MIN_BRIGHTNESS, it won't be possible to raise. The down function
> can set the brightness to SXMO_MIN_BRIGHTNESS, which means brightness
> will get stuck at 5 if SXMO_MIN_BRIGHTNESS > 5.
> 
> Should this be SXMO_MIN_BRIGHTNESS rounded up to the nearest 5 or
> something... I'm not sure I see a clear way to do this without some edge
> cases. I guess we could go up to the nearest 5 rather than adding 5?
> 
> Is this really worth the extra code? Are there cases where it's possible
> to tell between say 23% and 25% brightness?
You make a good point there aren, I revered my changes and it makes no difference.

Happy if you want to reject this patch

This keeps the increments from 5-100% the same

Signed-off-by: hazardchem <hazardchem@disroot.org>
---
 scripts/core/sxmo_brightness.sh | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/scripts/core/sxmo_brightness.sh b/scripts/core/sxmo_brightness.sh
index 4bee2dc1..f20c57e9 100755
--- a/scripts/core/sxmo_brightness.sh
+++ b/scripts/core/sxmo_brightness.sh
@@ -21,7 +21,14 @@ setvalue() {
 }
 
[message trimmed]

This patch also adds the relevant icon to sxmo_hook_icons.sh

Signed-off-by: hazardchem <hazardchem@disroot.org>
---
 configs/default_hooks/sxmo_hook_icons.sh     | 1 +
 configs/default_hooks/sxmo_hook_statusbar.sh | 7 ++++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/configs/default_hooks/sxmo_hook_icons.sh b/configs/default_hooks/sxmo_hook_icons.sh
index 014cb26d..375622db 100755
--- a/configs/default_hooks/sxmo_hook_icons.sh
+++ b/configs/default_hooks/sxmo_hook_icons.sh
@@ -63,6 +63,7 @@ icon_fbw=""
 icon_ffw="" #fast forward
[message trimmed]

Signed-off-by: hazardchem <hazardchem@disroot.org>
---
 configs/default_hooks/sxmo_hook_contextmenu.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/default_hooks/sxmo_hook_contextmenu.sh b/configs/default_hooks/sxmo_hook_contextmenu.sh
index e2f2318b..f2079e5b 100755
--- a/configs/default_hooks/sxmo_hook_contextmenu.sh
+++ b/configs/default_hooks/sxmo_hook_contextmenu.sh
@@ -41,7 +41,7 @@ case "$WMCLASS" in
 				superd_service_isrunning sxmo_modemmonitor &&
 				printf %b "$icon_ton ^ 1 ^ superctl stop sxmo_modemmonitor" ||
 				printf %b "$icon_tof ^ 1 ^ superctl start sxmo_modemmonitor"
-			) && sxmo_hook_statusbar.sh modem_monitor
[message trimmed]

Signed-off-by: hazardchem <hazardchem@disroot.org>
---
 configs/appcfg/i3_template   | 4 ++++
 configs/appcfg/sway_template | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/configs/appcfg/i3_template b/configs/appcfg/i3_template
index 24f9f96c..a33b1ca3 100644
--- a/configs/appcfg/i3_template
+++ b/configs/appcfg/i3_template
@@ -218,6 +218,10 @@ for_window [class="megapixels"] inhibit_idle open
 for_window [class="ep[yr].*"] inhibit_idle visible
 for_window [class="tabbed"] border pixel 0
 no_focus [class="svkbd"]
[message trimmed]

Signed-off-by: hazardchem <hazardchem@disroot.org>
---
 scripts/core/sxmo_proximitylock.sh | 39 ++++++++++++++++--------------
 1 file changed, 21 insertions(+), 18 deletions(-)

diff --git a/scripts/core/sxmo_proximitylock.sh b/scripts/core/sxmo_proximitylock.sh
index 863f7bb2..16d6cd88 100755
--- a/scripts/core/sxmo_proximitylock.sh
+++ b/scripts/core/sxmo_proximitylock.sh
@@ -11,7 +11,7 @@
 finish() {
 	sxmo_wakelock.sh unlock sxmo_proximity_lock_running
 	sxmo_state.sh restore "$storeid"
-	exit
[message trimmed]

I just sent through a v4 for some bug fixes and optimisations:
https://lists.sr.ht/~mil/sxmo-devel/%3C20250515112837.18048-1-hazardchem%40disroot.org%3E

This will achieve 2 things:

1 - Reduce pidof calls (which are taxing on the system from what Aren has informed
me.

2 - Allow more than just the keyboard program to be set via $KEYBOARD. This will
be useful for i3 using svkbd as it needs the -d switch to dock.

Signed-off-by: hazardchem <hazardchem@disroot.org>
Signed-off-by: Aren Moynihan <aren@peacevolution.org>
---

v4 - Fixes for toggle state would only close the keyboard.
Also reduced the isopen checks for running toggle as open checks for open keyboard
[message trimmed]

Signed-off-by: hazardchem <hazardchem@disroot.org>
---

v2 - corrected location as it was noticed that this was added under g apps.

 configs/default_hooks/sxmo_hook_apps.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configs/default_hooks/sxmo_hook_apps.sh b/configs/default_hooks/sxmo_hook_apps.sh
index 161236e7..82860eb2 100755
--- a/configs/default_hooks/sxmo_hook_apps.sh
+++ b/configs/default_hooks/sxmo_hook_apps.sh
@@ -108,6 +108,8 @@ write_line_app itinerary "$icon_map Itinerary" "itinerary"
 write_line_app jami-qt "$icon_msg Jami" "jami-qt"
[message trimmed]

Signed-off-by: hazardchem <hazardchem@disroot.org>
---
 configs/default_hooks/sxmo_hook_apps.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configs/default_hooks/sxmo_hook_apps.sh b/configs/default_hooks/sxmo_hook_apps.sh
index 161236e7..d4221315 100755
--- a/configs/default_hooks/sxmo_hook_apps.sh
+++ b/configs/default_hooks/sxmo_hook_apps.sh
@@ -81,6 +81,8 @@ write_line_app gnome-calls "$icon_phn Gnome Calls" "gnome-calls"
 write_line_app gnome-characters "$icon_emj Gnome Characters" "gnome-characters"
 write_line_app gnome-chess "$icon_chs Gnome Chess" "gnome-chess"
 write_line_app gnome-clocks "$icon_clk Gnome Clocks" "gnome-clocks"
+write_line_app kid3-cli "$icon_mus Kid3 Cli" "sxmo_terminal.sh kid3-cli"
[message trimmed]