This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

[PATCH v2] Heartrate not updated after initial connect.

Message ID
DKIM signature
Download raw message
Patch: +2 -2
Broken by 30eca31.
No, that is still wrong.  It is glbthr-heart-rate that could be nil.

Fix a docstring function reference while we are at it.

 glbt-heartrate.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/glbt-heartrate.el b/glbt-heartrate.el
index d62cb14..88b9bd4 100644
--- a/glbt-heartrate.el
+++ b/glbt-heartrate.el
@@ -381,7 +381,7 @@ https://www.bluetooth.com/specifications/specs/."
        (glbt-debug "glbthr--handle-characteristic-changes: lost contact with %S"
        (alert "Heart rate sensor contact lost."))
      (when (and hr (= 0 glbthr-heart-rate))
      (when (and glbthr-heart-rate (= hr glbthr-heart-rate))
        (setq glbthr-heart-rate hr)

@@ -420,7 +420,7 @@ This is invoked automatically by the command ‘glbthr-start-heart-rate’"
Argument PATH is the D-Bus object name of the heart rate monitor
device.  Ignore the request if the heart rate monitor is not
currently connected.  This is automatically called by the command
  (glbt-debug "glbthr--disconnect-hr-monitor: %S" path)
  (when (not (glbt-is-connected-p path))
    (glbt-debug "glbthr--disconnect-hr-monitor: Not connected."))
Reply to thread Export thread (mbox)