~herrhotzenplotz/gcli-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] Fix compilation failure of tests on NetBSD sparc64 w/ gcc13

Details
Message ID
<20240603194319.11044-1-nsonack@herrhotzenplotz.de>
DKIM signature
pass
Download raw message
Patch: +2 -2
I don't know why this hasn't shown up elsewhere yet:

The value checked to be greater-or-equal to 0 is unsigned. No need
for the comparison.

Signed-off-by: Nico Sonack <nsonack@herrhotzenplotz.de>
---
 tests/gitlab-parse-tests.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/gitlab-parse-tests.c b/tests/gitlab-parse-tests.c
index cc77b39..ae3b754 100644
--- a/tests/gitlab-parse-tests.c
+++ b/tests/gitlab-parse-tests.c
@@ -321,7 +321,7 @@ ATF_TC_BODY(gitlab_error_token_expired, tc)
	buffer.length = sn_read_file(TESTSRCDIR"/samples/gitlab_token_expired.json",
	                             &buffer.data);

	ATF_REQUIRE(buffer.length >= 0);
	ATF_REQUIRE(buffer.length);
	errmsg = gitlab_api_error_string(ctx, &buffer);

	ATF_CHECK_STREQ(errmsg, "Token has expired.");
@@ -337,7 +337,7 @@ ATF_TC_BODY(gitlab_error_unauthorised, tc)
	buffer.length = sn_read_file(TESTSRCDIR"/samples/gitlab_error_unauthorised.json",
	                             &buffer.data);

	ATF_REQUIRE(buffer.length >= 0);
	ATF_REQUIRE(buffer.length);
	errmsg = gitlab_api_error_string(ctx, &buffer);

	ATF_CHECK_STREQ(errmsg, "401 Unauthorized");
-- 
2.44.0
Details
Message ID
<D1QN9GVRBJUP.3V6WEUC2WXIFX@gjnoonan.co.uk>
In-Reply-To
<20240603194319.11044-1-nsonack@herrhotzenplotz.de> (view parent)
DKIM signature
pass
Download raw message
Applied. Thanks!
Reply to thread Export thread (mbox)