~herrhotzenplotz/gcli-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] Makefile.am: Fix linker errors when supplying explicit prefix for libreadline/libedit

Details
Message ID
<20240613090056.19763-1-nsonack@herrhotzenplotz.de>
DKIM signature
pass
Download raw message
Patch: +4 -4
When using --with-libedit=/usr we used to get linker errors because
the linker flags didn't contain -ledit and some flags were passed
along incorrectly.

This now includes -ledit or -lreadline and updates CFLAGS instead
of CPPFLAGS.

Signed-off-by: Nico Sonack <nsonack@herrhotzenplotz.de>
---
 configure.ac | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index 2810e30..474f19d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -88,8 +88,8 @@ if test "x$OPT_LIBEDIT" = "xyes" || test "x$OPT_LIBEDIT" = "xcheck"; then
elif ! test "x$OPT_LIBEDIT" = "xno"; then
	HAVE_LIBEDIT=1

	CPPFLAGS="-I$OPT_LIBEDIT/include $CPPFLAGS"
	LDFLAGS="-L$OPT_LIBEDIT/lib $LDFLAGS"
	CFLAGS="-I$OPT_LIBEDIT/include $CFLAGS"
	LDFLAGS="-L$OPT_LIBEDIT/lib -ledit $LDFLAGS"
fi

if test $HAVE_LIBEDIT -eq 1; then
@@ -124,8 +124,8 @@ if ! test $HAVE_LIBEDIT -eq 1; then
	elif ! test "x$OPT_READLINE" = "xno"; then
		HAVE_READLINE=1

		CPPFLAGS="-I$OPT_READLINE/include $CPPFLAGS"
		LDFLAGS="-L$OPT_READLINE/lib $LDFLAGS"
		CFLAGS="-I$OPT_READLINE/include $CFLAGS"
		LDFLAGS="-L$OPT_READLINE/lib -lreadline $LDFLAGS"
	fi

	if test $HAVE_READLINE -eq 1; then
-- 
2.44.0
Details
Message ID
<D1YSB51E0VJH.1P387XV6BRTZC@gjnoonan.co.uk>
In-Reply-To
<20240613090056.19763-1-nsonack@herrhotzenplotz.de> (view parent)
DKIM signature
pass
Download raw message
Applied. Thanks!

-g
Reply to thread Export thread (mbox)