~herrhotzenplotz/gcli-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH gcli] Makefile.in: fix makefile installation yet again

Details
Message ID
<20240822145251.73182-1-nsonack@herrhotzenplotz.de>
DKIM signature
pass
Download raw message
Patch: +13 -2
BSD Make removes newlines in macros. The call to read was not
producing the expected result for this reason.

Change it to a shell for-loop which will split on words.

Fixes: dea88294 (docs: Install manual pages into the correct directory, 2024-08-16)
Signed-off-by: Nico Sonack <nsonack@herrhotzenplotz.de>
---
 Makefile.in | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/Makefile.in b/Makefile.in
index 756271ed..545f110a 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -410,5 +410,16 @@ install-auto: manpages gcli
	$(INSTALL) -d $(MANDIR)/man5
	$(INSTALL) -d $(MANDIR)/man1
	# TODO: compress manual pages
	echo $(MANPAGES) | grep '\.1$$' | while read -r PAGE; do $(INSTALL) -m 644 $$PAGE $(MANDIR)/man1; done
	echo $(MANPAGES) | grep '\.5$$' | while read -r PAGE; do $(INSTALL) -m 644 $$PAGE $(MANDIR)/man5; done
	for PAGE in $(MANPAGES); do                               \
		case $$PAGE in                                    \
		*.1)                                              \
			$(INSTALL) -m 644 $$PAGE $(MANDIR)/man1   \
			;;                                        \
		*.5)                                              \
			$(INSTALL) -m 644 $$PAGE $(MANDIR)/man5   \
			;;                                        \
		*)                                                \
			echo error installing man page $$PAGE >&2 \
			;;                                        \
		esac                                              \
	done
-- 
2.45.2
Details
Message ID
<D3P599VJ4MAR.KVWITRNN02AS@gjnoonan.co.uk>
In-Reply-To
<20240822145251.73182-1-nsonack@herrhotzenplotz.de> (view parent)
DKIM signature
pass
Download raw message
Nico Sonack, Aug 22, 2024 at 14:52:
> BSD Make removes newlines in macros. The call to read was not
> producing the expected result for this reason.
>
> Change it to a shell for-loop which will split on words.
>
> Fixes: dea88294 (docs: Install manual pages into the correct directory, 2024-08-16)
> Signed-off-by: Nico Sonack <nsonack@herrhotzenplotz.de>

Applied. Thanks!

-g
Reply to thread Export thread (mbox)