[PATCH gcli] tables: add printf format hints for compilers and fix resulting bugs
Export this patch
Signed-off-by: Nico Sonack <nsonack@herrhotzenplotz.de>
---
include/gcli/cmd/table.h | 3 ++-
include/gcli/gitlab/snippets.h | 2 +-
templates/gitlab/snippets.t | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/gcli/cmd/table.h b/include/gcli/cmd/table.h
index 5c1d9aa..02a9384 100644
--- a/include/gcli/cmd/table.h
+++ b/include/gcli/cmd/table.h
@@ -92,7 +92,8 @@ int gcli_tbl_add_row(gcli_tbl table, ...);
gcli_dict gcli_dict_begin(void);
int gcli_dict_add(gcli_dict list, char const *key, int flags,
- uint32_t colour_args, char const *fmt, ...);
+ uint32_t colour_args, char const *fmt, ...)
+ PRINTF_FORMAT(5, 6);
int gcli_dict_add_string(gcli_dict list, char const *key, int flags,
uint32_t colour_args, char const *str);
diff --git a/include/gcli/gitlab/snippets.h b/include/gcli/gitlab/snippets.h
index cc5a058..d7a930f 100644
--- a/include/gcli/gitlab/snippets.h
+++ b/include/gcli/gitlab/snippets.h
@@ -37,7 +37,7 @@
#include <gcli/gcli.h>
struct gcli_gitlab_snippet {
- int id;
+ gcli_id id;
char *title;
char *filename;
char *date;
diff --git a/templates/gitlab/snippets.t b/templates/gitlab/snippets.t
index e902519..18e08e9 100644
--- a/templates/gitlab/snippets.t
+++ b/templates/gitlab/snippets.t
@@ -4,7 +4,7 @@ include "gcli/gitlab/snippets.h";
parser gitlab_snippet is
object of struct gcli_gitlab_snippet with
("title" => title as string,
- "id" => id as int,
+ "id" => id as id,
"raw_url" => raw_url as string,
"created_at" => date as string,
"file_name" => filename as string,
--
2.45.2
Acked-by: Gavin-John Noonan <mail@gjnoonan.co.uk>
Applied. Thanks!