From Issam E. Maghni to ~lattis/muon
Well, now that I got muon, I tried it on a port I’m working on, but it segfaults :) Here [1] is a reproducible build. [1] https://builds.sr.ht/~iemaghni/job/672519
From Issam E. Maghni to ~lattis/muon
Hi, can you provide the instructions on how to build muon with pkgconf support? I tried to bootstrap it, and build itself with libpkgconf=enabled. I added the subproject, and I get: > info subproject: pkgconf > info detected compiler gcc 11.2.1 (cc) > info configuring 'pkgconf', version: 1.8.0 > info have function strlcat: NO > info have function strlcpy: NO > info have function strndup: YES > info string.h has header symbol strndup: YES > /home/iemaghni/code/tmp/muon/subprojects/pkgconf/meson.build:26:64: error: undefined option > 26 | default_path += [join_paths(get_option('prefix'), get_option(f), 'pkgconfig')]
From Issam E. Maghni to ~mcf/libtls-bearssl
How about adding this to tls_conninfo.c, tls_keypair.c an compat/freezero.c: /* explicit_bzero */ #define _GNU_SOURCE To tls_config.c and bearssl.c: /* strsep */ #define _GNU_SOURCE I find that using global _GNU_SOURCE is a bad idea because you are forced to add it into all the build system. I prefer to keep the compile arguments minimal, and compilation units self sufficient. WDYT?
From Issam E. Maghni to ~mcf/libtls-bearssl
On Thu Oct 15, 2020 at 7:09 PM Michael Forney wrote: > Sorry for the huge delay. Don’t worry, I don’t mind. > I don't quite understand the motivation for this change. Could you > explain what problem this solves? Well, it cleans the repository by having a clear cut between source code, headers, documentation, build systems, etc. I maintain a forked version where I added Meson build system to ease the development (e.g. auto generation of compile_commands.json) and fixed some defines. See https://git.sr.ht/~iemaghni/libtls-bearssl. Feel free
From Issam E. Maghni to ~mcf/libtls-bearssl
_GNU_SOURCE is also used by musl. https://git.musl-libc.org/cgit/musl/tree/include/stdio.h?h=v1.2.1#n166 Signed-off-by: Issam E. Maghni <issam.e.maghni@mailbox.org> --- src/tls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/tls.c b/src/tls.c index 8595ecd..a81c3b2 100644 --- a/src/tls.c +++ b/src/tls.c @@ -15,6 +15,8 @@ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. [message trimmed]
From Issam E. Maghni to ~mcf/libtls-bearssl
Signed-off-by: Issam E. Maghni <issam.e.maghni@mailbox.org> --- Makefile | 38 +++++++++++----------- compat.h => include/compat.h | 0 tls.h => include/tls.h | 0 tls_internal.h => include/tls_internal.h | 0 bearssl.c => src/bearssl.c | 0 {compat => src/compat}/freezero.c | 0 {compat => src/compat}/reallocarray.c | 0 {compat => src/compat}/timingsafe_memcmp.c | 0 tls.c => src/tls.c | 0 tls_bio_cb.c => src/tls_bio_cb.c | 0 tls_client.c => src/tls_client.c | 0 tls_config.c => src/tls_config.c | 0 [message trimmed]
From Issam E. Maghni to ~mcf/libtls-bearssl
Signed-off-by: Issam E. Maghni <issam.e.maghni@mailbox.org> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 8b0f7fd..f0979ec 100644 --- a/Makefile +++ b/Makefile @@ -8,7 +8,7 @@ PREFIX?=/usr/local INCDIR?=$(PREFIX)/include LIBDIR?=$(PREFIX)/lib MANDIR?=$(PREFIX)/share/man CFLAGS+=-Wall -Wpedantic -D _DEFAULT_SOURCE -I include [message trimmed]