From: boringcactus <boringcactus@gmail.com>
To: ~int80h/public-inbox@lists.sr.ht
Cc: Melody Horn <melody@boringcactus.com>
Subject: [PATCH gemserv] don't round-trip CGI response through UTF-8
Date: Wed, 11 Nov 2020 16:06:28 -0700
Message-Id: <20201111230628.7980-1-boringcactus@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

From: Melody Horn <melody@boringcactus.com>

this fixes sending binary files from a CGI script
---
Sent this directly to int80h, but it's probably wise to put it on the
mailing list as well, just in case.

 src/cgi.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/cgi.rs b/src/cgi.rs
index a5dd900..1605d53 100644
--- a/src/cgi.rs
+++ b/src/cgi.rs
@@ -137,13 +137,13 @@ pub async fn cgi(
         con.send_status(Status::CGIError, None).await?;
         return Ok(());
     }
-    let cmd =3D String::from_utf8(cmd.stdout).unwrap();
-    if !check(cmd.as_bytes()[0], con.peer_addr, url) {
+    let cmd =3D cmd.stdout;
+    if !check(cmd[0], con.peer_addr, url) {
         con.send_status(Status::CGIError, None).await?;
         return Ok(());
     }
=20
-    con.send_raw(cmd.as_bytes()).await?;
+    con.send_raw(&cmd).await?;
     return Ok(());
 }
=20
--=20
2.20.1.windows.1