~inwit

Recent activity

Re: [PATCH aerc] doc: rename bindings help page 2 days ago

From inwit to ~rjarry/aerc-devel

On Sun Nov 27, 2022 at 10:48 PM CET, Robin Jarry wrote:
> Actually, now this will be even more confusing with :help binds (which
> runs `man aerc-binds`).
Oh! I didn't apply your patch so I totally oversaw this.

> This :help keys command should probably be another command since it does
> not run any man page at all. There is clearly a special case for it.
+1

> How about renaming `:help keys` to `:binds` or `:show-binds` with the
> same default binding to `?`. To avoid breaking existing configs, we
> would need to support fallback with an explicit warning.
I'm all for :show-binds. However if I'm to do this change, which is a bit more
complicated than my 2 line patch, I'll need some more time.

[PATCH aerc] doc: rename bindings help page 3 days ago

From inwit to ~rjarry/aerc-devel

Bindings were called "keys" in the :help command. Rename it to "bindings"
to keep coherence with the rest of the documentation.

Signed-off-by: inwit <inwit@sindominio.net>
---
 commands/help.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/commands/help.go b/commands/help.go
index 498f9bc..45876a6 100644
--- a/commands/help.go
+++ b/commands/help.go
@@ -19,7 +19,7 @@ var pages = []string{
	"stylesets",
[message trimmed]

Maildir/notmuch integration 3 days ago

From inwit to ~rjarry/aerc-devel

Since the addition of maildir capabilities to the notmuch interface, I've been
running it in parallel with the maildir interface, which highlighted some
differences that made me think that maybe the approach taken in that
integration is not optimal. I'm not a coder, so please take all this with a
pinch of salt and correct me if I'm wrong, which is likely.

The situation now is that since Julian Pidancet's patch series [0], the notmuch
interface has access to the underlying maildir file structure, listing maildir
folders along notmuch queries (aka virtual folders). This is absolutely great,
and I'm really thankful for this.

There are some conceptual issues implied in that change, however, since in
maildir a message is a file, and message duplications are permitted whereas
notmuch has a more abstract approach in which all duplicated files are

[PATCH aerc v2] notmuch: allow moving single file messages 4 days ago

From inwit to ~rjarry/aerc-devel

In notmuch, a message can be represented by several identical files across the
maildir structure, which makes the operation of moving a message from a virtual
folder (showing a notmuch query) to a maildir folder problematic if the number
of files for that message is greater than 1. Since the move operation is
unambiguous when the message is represented by a single file, allow moving
messages in such cases.

Signed-off-by: inwit <inwit@sindominio.net>
---
v1->v2
  - Return an explicit error instead of aborting and logging an error
    message. 

 worker/notmuch/worker.go | 23 ++++++++++++++---------
[message trimmed]

Re: [PATCH aerc v2 4/6] doc: homogenize scdoc markup 6 days ago

From inwit to ~rjarry/aerc-devel

On Thu Nov 24, 2022 at 12:07 AM CET, Robin Jarry wrote:
> For consistent rendering, it is best if every man page uses the same
> conventions. These are completely arbitrary and I only did some trial
> & error until I found something that looked visually OK.
>
> Update CONTRIBUTING.md with guidelines for scdoc markup conventions.
>
> Update all man pages according to these guidelines.
>
> Suggested-by: Inwit <inwit@sindominio.net>
> Signed-off-by: Robin Jarry <robin@jarry.cc>
> ---
> v1 -> v2:
>

Re: [PATCH aerc 4/4] doc: homogenize scdoc markup 7 days ago

From inwit to ~rjarry/aerc-devel

On Tue Nov 22, 2022 at 10:37 PM CET, Robin Jarry wrote:
> For consistent rendering, it is best if every man page uses the same
> conventions. These are completely arbitrary and I only did some trial
> & error until I found something that looked visually OK.
>
> Update CONTRIBUTING.md with guidelines for scdoc markup conventions.
>
> Update all man pages according to these guidelines.
>
> Suggested-by: Inwit <inwit@sindominio.net>
> Signed-off-by: Robin Jarry <robin@jarry.cc>
> ---
>  CONTRIBUTING.md          |  27 ++
>  doc/aerc-config.5.scd    | 565 ++++++++++++++++++++-------------------

[PATCH aerc] notmuch: allow moving single file messages 7 days ago

From inwit to ~rjarry/aerc-devel

In notmuch, a message can be represented by several identical files across the
maildir structure, which makes the operation of moving a message from a virtual
folder (showing a notmuch query) to a maildir folder problematic if the number
of files for that message is greater than 1. Since the move operation is
unambiguous when the message is represented by a single file, allow moving
messages in such cases.

Signed-off-by: inwit <inwit@sindominio.net>
---

 worker/notmuch/worker.go | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/worker/notmuch/worker.go b/worker/notmuch/worker.go
[message trimmed]

[PATCH aerc v3] notmuch: preserve tags when moving messages 9 days ago

From inwit to ~rjarry/aerc-devel

Keep the original tags when a message is moved from one maildir folder to
another.

Signed-off-by: inwit <inwit@sindominio.net>
---
v1->v2
  - Format fixed and lint tests run.
v2->v3
  - Return nil since errors are already handled.

 worker/notmuch/message.go | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/worker/notmuch/message.go b/worker/notmuch/message.go
[message trimmed]

Re: [PATCH aerc 01/14] commands: remove broken :set command 14 days ago

From inwit to ~rjarry/aerc-devel

While I agree with the rationale behind the removal of :set, I think having a
way to change the configuration while using aerc is a nice thing to have. Maybe
it could be achieved with a :source-config command?

Re: Select line jump over messages 14 days ago

From inwit to ~rjarry/aerc-discuss

On Wed Nov 16, 2022 at 10:19 AM CET, Johnmcenroy wrote:
> So when I make command "rm" all is fine (checked also with notmuch in
> terminal), messages deleted, but the line which highlight messages jump over
> messages, don't highlight message one after another.
This has been solved in a recent patch, but I'm not sure if it made it to
master yet. On which build are you?