From Robin Krahl to ~ireas/public-inbox
> > 1. The patch subject has an additional pair of brackets. > > Yeah... I'm embarrassed, sorry. I'm still new to this style of PR. No worries! I’m aware that this workflow is non-standard and can take some time and experience to get used to. > > 2. Why do we need cfg-if? > > I have never gotten cfg macros to work on a block, I just tested again > and its still a no-go. Here's my rust compiler version, not sure if its > working for you? Hmm, strange. Apparently, you can’t have top-level blocks. This fails
From Robin Krahl to ~ireas/public-inbox
Thanks, Alexander! Unfortunately, I can’t apply the patch due to an error when adding the images: error: git diff header lacks filename information when removing 1 leading pathname component (line 268) See also: https://builds.sr.ht/~ireas/job/362435 Does `git am` work for you? At first glance, the code looks good to me. I’ll have a closer look later today or tomorrow. Some general remarks:
From Robin Krahl to ~ireas/public-inbox
Thanks for the patch! Looks good. I plan to release a new minor version this week. Let me know if you need an earlier release of this bug fix. Merged into master: To git.sr.ht:~ireas/genpdf-rs 831a5ac..da11d39 master -> master
From Robin Krahl to ~ireas/public-inbox
Thanks! I don’t know why it is so hard for me to type this word correctly. To git.sr.ht:~ireas/genpdf-rs 3ff5cf9..c0333f6 master -> master
From Robin Krahl to ~sircmpwn/sr.ht-discuss
On 2020-09-29 19:01:14, Jonas Platte wrote: > I'm wondering what the full set of supported filter for the search bar on > builds.sr.ht is. I couldn't find this mentioned anywhere in the > documentation. > Is it just `status`, `image` and `tags` (the ones mentioned in the > placeholder text)? Yes: https://git.sr.ht/~sircmpwn/builds.sr.ht/tree/master/buildsrht/search.py#L18 /Robin
From Robin Krahl to ~ireas/nitrokey-rs-dev
nitrokey-rs v0.8.0 has been released. It is available as a signed tag in the nitrokey-rs Git repository: https://git.sr.ht/~ireas/nitrokey-rs/refs/v0.8.0 Or on crates.io: https://crates.io/crates/nitrokey/0.8.0 This minor release updates the nitrokey-sys-rs/libnitrokey dependency to v3.6.0 and adds support for the Librem model. Note that with this release, the main Git repository has moved to sourcehut. Thanks to Daniel Müller for many contributions and reviews!
From Robin Krahl to ~ireas/nitrokey-rs-dev
nitrokey-sys-rs v3.6.0 has been released. It is available as a signed tag in the nitrokey-sys-rs Git repository: https://git.sr.ht/~ireas/nitrokey-sys-rs/refs/v3.6.0 Or on crates.io: https://crates.io/crates/nitrokey-sys/3.6.0 This release updates the libnitrokey dependency to version 3.6.0 and refactors the bindings generation. It adds the bindgen feature that enables generating the bindings during build instead of using the pre-generated bindings. Note that with this release, the main Git repository has moved to sourcehut. As always, thanks to Daniel Müller for contributions, ideas and reviews.
From Robin Krahl to ~ireas/public-inbox
On 2020-09-23 16:15:20, Joshua Nelson wrote: > That looks really good! My one nit is that it should mention that CI > won't run unless the patches start with a subject of '[PATCH > merge-rs]'. Right now it looks like '[merge-rs]' will work fine, and > there's nothing clearly tying it to builds. Thanks for the review! True, this section is not very precise. I didn’t want to mention the prefix again because it only applies for the shared mailing lists. But I’ll see whether I can somehow improve this section. Ideally, I’d link to the sourcehut documentation for this feature, but as it was added rather recently, so there is not yet much documentation to refer to. ^^ Also, the PATCH prefix is not only necessary for triggering the builds.
From Robin Krahl to ~sircmpwn/sr.ht-discuss
On 2020-09-24 11:23:39, Bastien wrote: > For multiple-licensing, the practise that seems okay to me is to have > multiples files like LICENSE-X.* LICENSE-Y.* for multiple licenses. Another option is to put the license files in a LICENSES directory. This is accepted by the git.sr.ht checker and it is required by the FSFE’s REUSE specification [0] for unambigous human- and machine-readable copyright information. [0] https://reuse.software/spec/ /Robin
From Robin Krahl to ~ireas/public-inbox
Hi Joshua, I wrote a general contributing guide for my projects on Sourcehut that I’d like to link in the merge-rs readme. Could you please have a look and check whether anything is unclear or missing? Thanks! https://man.sr.ht/~ireas/guides/contributing.md /Robin