Hi Erik,

On 2021-04-22 16:00:37, fundererik@gmail.com wrote:
> Do you have any plans to continue with this, or could I take a shot?

it’s my fault that this has not been merged yet.  I’ll take care of that
soon.

/Robin

Hi Daniel,

I’m not completely opposed to patching nitrokey-sys but I’d rather avoid
it for non-critical issues.  I think there will be a new libnitrokey
release rather soon, so my suggestion would be to wait until next week.
Would that be okay for you?

/Robin

On 2021-04-08 17:41:54, Evan Lloyd New-Schmidt wrote:
> Unfortunately, when I tried implementing this version I got "error: lifetime
> may not live long enough". I tried specifying some manually, but it appears
> that the *_by_key methods don't allow key functions that return references
> to the slice's items - this question on S.O. has some more info:
> https://stackoverflow.com/a/56106352

That’s a bummer.  Maybe it is possible to use a key function together
with sort_by?  E. g. something like this (where get_tuple is the
function I outlined previously):

    vec.sort_by(|l, r| get_tuple(l).cmp(&get_tuple(r)))
    vec.dedup_by(|l, r| get_tuple(l).eq(&get_tuple(r)))

Hi Evan,

On 2021-04-06 16:51:04, Evan Lloyd New-Schmidt wrote:
> Hi! I came across this lovely project when I was looking at the cursive
> docs, and #17 was one of the first things I found I was missing, so I
> decided to try implementing it.

Great!  Please let me know if you have any other issues.  I haven’t
worked on this project in a while, but I’m still interested in
continuing its development and improving its usability.

Thank you for the patch!  It looks very good to me.  I have some
questions and comments:

nitrokey-rs v0.9.0 has been released.  It is available as a signed tag in
the nitrokey-rs Git repository:
	https://git.sr.ht/~ireas/nitrokey-rs/refs/v0.9.0
Or on crates.io:
	https://crates.io/crates/nitrokey/0.9.0

This minor release refactors the password safe access.

Changelog
---------

- Refactor the PWS slot access to clearly distinguish unprogrammed slots and
  empty name, login or password values:
  - Add the `get_slots`, `get_slot` and `get_slot_unchecked` methods to the

This patch adds links to the GraphQL schemes in the Git repositories to
the graphql.md pages for {git,meta,todo}.sr.ht.  The playground also
contains the schemes, but it is only available for logged-in users.
And the source file makes it easier to jump to specific locations, to
share links and to track changes.
---
 git.sr.ht/graphql.md  | 1 +
 meta.sr.ht/graphql.md | 1 +
 todo.sr.ht/graphql.md | 1 +
 3 files changed, 3 insertions(+)

diff --git a/git.sr.ht/graphql.md b/git.sr.ht/graphql.md
index 3d43cb2..7d4c830 100644
--- a/git.sr.ht/graphql.md
[message trimmed]

todo.sr.ht has a GraphQL API and a page describing it, but neither the
index page nor the api page linked to it.  This patch updates both pages
to link to the GraphQL documentation, as is already the case for
{meta,git}.sr.ht.
---
 index.html        | 2 +-
 todo.sr.ht/api.md | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/index.html b/index.html
index 72db369..39d4be5 100644
--- a/index.html
+++ b/index.html
@@ -121,7 +121,7 @@ dt {
[message trimmed]

curl does not support separating long options and their values by an
equals sign (only by spaces), see curl(1):
	https://curl.se/docs/manpage.html
---
 graphql.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/graphql.md b/graphql.md
index 4009ae3..d18fef7 100644
--- a/graphql.md
+++ b/graphql.md
@@ -98,7 +98,7 @@ Here is a simple request:
 ```sh
 oauth_token=your oauth token
[message trimmed]

The example queries were missing the outer query { ... } element (or
just { ...  })
---
 graphql.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/graphql.md b/graphql.md
index e842e85..4009ae3 100644
--- a/graphql.md
+++ b/graphql.md
@@ -85,7 +85,7 @@ query which is supported on all APIs is:
 
 ```json
 {
[message trimmed]

There also is a GraphQL playground for todo.sr.ht that was not mentioned
in the documentaion.
---
 graphql.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/graphql.md b/graphql.md
index 58302c5..e842e85 100644
--- a/graphql.md
+++ b/graphql.md
@@ -29,6 +29,7 @@ queries you perform will affect your real data!
 
 - [meta.sr.ht playground](https://meta.sr.ht/graphql)
 - [git.sr.ht playground](https://git.sr.ht/graphql)
[message trimmed]