On 2022-04-30 15:20:15, Daniel Müller wrote:
> Great stuff, thanks for the quick turnaround Robin! I noticed that the> https://git.ireas.org/ repositories (mentioned below) are outdated.> Should we reference the ones on sourcehut instead? Can we delete them to> prevent confusion?
You’re right, I noticed that too. I forgot to update my mail generation
script. Will do so before the next release. I want to keep the
git.ireas.org repositories as a backup, and I have a cron script that
automatically pulls in changes. Maybe I forgot to add this repository
to that script – I will have a look at that.
/Robin
On 4/30/22 10:46 AM, Robin Krahl wrote:
> On 2022-04-30 15:20:15, Daniel Müller wrote:>> Great stuff, thanks for the quick turnaround Robin! I noticed that the>> https://git.ireas.org/ repositories (mentioned below) are outdated.>> Should we reference the ones on sourcehut instead? Can we delete them to>> prevent confusion?> > You’re right, I noticed that too. I forgot to update my mail generation> script. Will do so before the next release. I want to keep the> git.ireas.org repositories as a backup, and I have a cron script that> automatically pulls in changes. Maybe I forgot to add this repository> to that script – I will have a look at that.
Sounds good. By the way, I just noticed that we may have inadvertently
introduced a backwards compatibility breaking change by using Rust
features that are only supported in more resent versions of the
toolchain. See here:
https://github.com/d-e-s-o/nitrocli/runs/6241530957?check_suite_focus=true
It's not an issue for nitrocli (because we pin everything and I manually
have to bump), but it's not great in general. At the same time, I recall
you wanted to keep nitrokey-sys versions in sync with libnitrokey. So
perhaps the best way out is to explicitly state that the former does not
follow semver? In which case you'd probably want to pin nitrokey-sys in
nitrokey-rs.
Daniel
Good catch! I didn’t check the compatibility because the changes seemed
pretty unsuspicious … Currently, the versioning policy is to sync only
the major and minor version, so we can easily release a v3.7.1 version
that fixes backwards compatibility. I’ll have a look at it in the next
days.
/Robin