Hi Robin,

In the process of enabling nitrokey-test to work with a Librem stick I 
noticed that I could not actually connect to mine as intended. The 
reason being that it is recognized as a pro device by nitrokey-rs.

The reason for that, in turn, seems to be that it actually *is* a Pro:

Here is the lsusb data for my Librem Key:
$ lsusb -s 001:020 -vvvv

Bus 001 Device 020: ID 20a0:4108 Clay Logic Nitrokey Pro
Device Descriptor:
   bLength                18
   bDescriptorType         1
   bcdUSB               1.10
   bDeviceClass            0
   bDeviceSubClass         0
   bDeviceProtocol         0
   bMaxPacketSize0        64
   idVendor           0x20a0 Clay Logic
   idProduct          0x4108
   bcdDevice            1.01
   iManufacturer           1 Nitrokey
   iProduct                2 Nitrokey Pro
   iSerial                 3 000000000000000000006BAC


Here is it for the actual Pro:
$ lsusb -s 001:019 -vvvv

Bus 001 Device 019: ID 20a0:4108 Clay Logic Nitrokey Pro
Device Descriptor:
   bLength                18
   bDescriptorType         1
   bcdUSB               1.10
   bDeviceClass            0
   bDeviceSubClass         0
   bDeviceProtocol         0
   bMaxPacketSize0        64
   idVendor           0x20a0 Clay Logic
   idProduct          0x4108
   bcdDevice            1.01
   iManufacturer           1 Nitrokey
   iProduct                2 Nitrokey Pro
   iSerial                 3 000000000000000000006F06


Here are the expected IDs from the libnitrokey source:

const uint16_t nitrokey::device::NITROKEY_VID = 0x20a0;
const uint16_t nitrokey::device::NITROKEY_PRO_PID = 0x4108;
const uint16_t nitrokey::device::NITROKEY_STORAGE_PID = 0x4109;

const uint16_t nitrokey::device::PURISM_VID = 0x316d;
const uint16_t nitrokey::device::LIBREM_KEY_PID = 0x4c4b;

So basically, my Librem Key is not one, according to everything I see. 
Have you verified that yours is actually advertising itself as a Librem 
Key? Did they just send me garbage?

Daniel

Hi Daniel,

that’s very strange.  My Librem Key is identifying itself correctly with
VID 316d and PID 4c4b:

idVendor           0x316d
idProduct          0x4c4b
bcdDevice            1.01
iManufacturer           1 Purism, SPC
iProduct                2 Librem Key

Looks like you got a bad key.  Let me know if you want me to run any
other tests.

/Robin

Hi Robin,

On 3/8/21 12:48 AM, Robin Krahl wrote:
> Hi Daniel,
> 
> that’s very strange.  My Librem Key is identifying itself correctly with
> VID 316d and PID 4c4b:
> 
> idVendor           0x316d
> idProduct          0x4c4b
> bcdDevice            1.01
> iManufacturer           1 Purism, SPC
> iProduct                2 Librem Key

Thanks for checking. I will contact them again and see if there is a way 
to rectify the issue.

> Looks like you got a bad key.  Let me know if you want me to run any
> other tests.

Problem is, I'd need to do a lot of testing for nitrocli as well. If you 
wanted to, you could start integrating nitrokey-rs with 
https://github.com/d-e-s-o/nitrokey-test/tree/topic/librem-key and check 
if everything is working. Not sure if you planned to test the Librem Key 
specifically.

Daniel

Hi Daniel,

On 2021-03-08 08:19:43, Daniel Müller wrote:
> > Looks like you got a bad key.  Let me know if you want me to run any
> > other tests.
> 
> Problem is, I'd need to do a lot of testing for nitrocli as well. If you
> wanted to, you could start integrating nitrokey-rs with
> https://github.com/d-e-s-o/nitrokey-test/tree/topic/librem-key and check if
> everything is working. Not sure if you planned to test the Librem Key
> specifically.

There are some other things I’d like to fix first, but maybe I can have
a look at the weekend.  I don’t plan any Librem-specific tests other
than the identification (tests/device.rs).

/Robin