~ireas/public-inbox

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 2

[PATCH merge-rs] Update readme with instructions for submitting patches

Details
Message ID
<20200920224906.849844-1-jyn514@gmail.com>
DKIM signature
pass
Download raw message
Patch: +8 -0
---
 README.md | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/README.md b/README.md
index 1bdb16a..322491e 100644
--- a/README.md
+++ b/README.md
@@ -82,6 +82,14 @@ For bug reports, patches, feature requests and other messages, please send a
mail to [~ireas/public-inbox@lists.sr.ht][] using the `[merge-rs]` prefix in
the subject.

You can submit patches using
[`git send-email --to=~ireas/public-inbox@lists.sr.ht`][git-send-email].
 Please prefix the subject with `PATCH merge-rs` so that CI will be
automatically run. You can configure git to do this automatically with
`git config format.subjectPrefix "PATCH merge-rs"`.

[git-send-email]: https://git-send-email.io

## License

This project is dual-licensed under the [Apache-2.0][] and [MIT][] licenses.
-- 
2.25.1
Details
Message ID
<20200920231121.GB609@ireas.org>
In-Reply-To
<20200920224906.849844-1-jyn514@gmail.com> (view parent)
DKIM signature
pass
Download raw message
Thank you!  Merged into master.

/Robin
Details
Message ID
<20200923201119.GE1574@ireas.org>
In-Reply-To
<20200920224906.849844-1-jyn514@gmail.com> (view parent)
DKIM signature
pass
Download raw message
Hi Joshua,

I wrote a general contributing guide for my projects on Sourcehut that
I’d like to link in the merge-rs readme.  Could you please have a look
and check whether anything is unclear or missing?  Thanks!

	https://man.sr.ht/~ireas/guides/contributing.md

/Robin
Details
Message ID
<CAJ+j++UG11DCsHWasLg9BEiri8sLio=CPxM=RPKPQtrJk4vJ_w@mail.gmail.com>
In-Reply-To
<20200923201119.GE1574@ireas.org> (view parent)
DKIM signature
pass
Download raw message
That looks really good! My one nit is that it should mention that CI
won't run unless the patches start with a subject of '[PATCH
merge-rs]'. Right now it looks like '[merge-rs]' will work fine, and
there's nothing clearly tying it to builds.

Joshua
Details
Message ID
<20200924193454.GC1523@ireas.org>
In-Reply-To
<CAJ+j++UG11DCsHWasLg9BEiri8sLio=CPxM=RPKPQtrJk4vJ_w@mail.gmail.com> (view parent)
DKIM signature
pass
Download raw message
On 2020-09-23 16:15:20, Joshua Nelson wrote:
> That looks really good! My one nit is that it should mention that CI
> won't run unless the patches start with a subject of '[PATCH
> merge-rs]'. Right now it looks like '[merge-rs]' will work fine, and
> there's nothing clearly tying it to builds.

Thanks for the review!  True, this section is not very precise.  I
didn’t want to mention the prefix again because it only applies for the
shared mailing lists.  But I’ll see whether I can somehow improve this
section.  Ideally, I’d link to the sourcehut documentation for this
feature, but as it was added rather recently, so there is not yet much
documentation to refer to. ^^

Also, the PATCH prefix is not only necessary for triggering the builds.
It also enables the patch view in the web interface:
	https://lists.sr.ht/~ireas/public-inbox/patches
Maybe I should explain this in the Submitting Patches section.

/Robin
Reply to thread Export thread (mbox)