~ireas/public-inbox

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 2

[PATCH] Replace vector instead of appending to it

Details
Message ID
<20220404085810.892796-1-rene.kijewski@fu-berlin.de>
DKIM signature
missing
Download raw message
Patch: +2 -2
This eliminates the need to move the inner elements.
---
 src/lib.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib.rs b/src/lib.rs
index ab9b4ab..011f3e6 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -243,9 +243,9 @@ pub mod ord {
#[cfg(feature = "std")]
pub mod vec {
    /// Overwrite left with right if left is empty.
    pub fn overwrite_empty<T>(left: &mut Vec<T>, mut right: Vec<T>) {
    pub fn overwrite_empty<T>(left: &mut Vec<T>, right: Vec<T>) {
        if left.is_empty() {
            left.append(&mut right);
            *left = right;
        }
    }

-- 
2.35.1
Details
Message ID
<20220404090456.2137541f@powerful-l2.k6i>
In-Reply-To
<20220404085810.892796-1-rene.kijewski@fu-berlin.de> (view parent)
DKIM signature
missing
Download raw message
Hi Robin,

sorry, I did not notice that my version of git-send-email does not seem to understand "--subject-prefix".
Should I re-send my two patches with a proper subject line?

Cheers
René

-- 
There is no room for "2" in the world of 1's and 0's,
no place for "mayhap" in a house of trues and falses,
and no "green with envy" in  a black-and-white world.
Details
Message ID
<20220404091817.GA1292@ireas.org>
In-Reply-To
<20220404090456.2137541f@powerful-l2.k6i> (view parent)
DKIM signature
missing
Download raw message
Hi René,

thanks for the patches!  You don’t have to resend them, I’ll have a look
at them later today or tomorrow.

Best,
Robin
Details
Message ID
<20220423123542.3c8fc97e@powerful-l2.k6i>
In-Reply-To
<20220404091817.GA1292@ireas.org> (view parent)
DKIM signature
missing
Download raw message
Hi Robin,

I hope you had a happy Easter!
Could you have a look at my PRs if you find the time? :)

Cheers
René
Reply to thread Export thread (mbox)