~jackmordaunt

Australia

~jackmordaunt/audiotube-devel

Last active 21 days ago

~jackmordaunt/audiotube-announce

Last active 21 days ago
View more

Recent activity

[PATCH] widget: delete whole words with key modifier a day ago

From to ~eliasnaur/gio-patches

From: Jack Mordaunt <jackmordaunt@gmail.com>

Delete entire words with key modifier, ie "ctrl + delete".

Signed-off-by: Jack Mordaunt <jackmordaunt@gmail.com>
---
 widget/editor.go      | 59 +++++++++++++++++++++++++++++++++++++++++--
 widget/editor_test.go | 55 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 112 insertions(+), 2 deletions(-)

diff --git a/widget/editor.go b/widget/editor.go
index 3399a2c..69b8796 100644
--- a/widget/editor.go
+++ b/widget/editor.go
[message trimmed]

[PATCH] feat: ctrl-click to open url (only) replies a day ago

From to ~whereswaldon/arbor-dev

From: Jack Mordaunt <jackmordaunt@gmail.com>

Sketch for link-opening with ctr-click. 
Used best guess for browser opening (only desktops considered atm).

I wasn't sure the best way to access reply content, so I added it to 
the `sprigWidget.Reply`, which gets set during layouting, as a hack. 

While this gets the job done; 
 - it doesn't handle Android or iOS platforms
 - layout should probably consider hyperlinks and render them differently from standard text
 - perhaps the cursor should change on hover to indicate "interactiveness", similar to vscode
 - doesn't handle inline links, since it attempts to parse the entire reply content
[message trimmed]

[PATCH] feat: scrollbar type and scroll state a day ago

From to ~whereswaldon/public-inbox

From: Jack Mordaunt <jackmordaunt@gmail.com>

Signed-off-by: Jack Mordaunt <jackmordaunt@gmail.com>
---
 scroll.go | 235 ++++++++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 209 insertions(+), 26 deletions(-)

diff --git a/scroll.go b/scroll.go
index 6807320..9d20d2a 100644
--- a/scroll.go
+++ b/scroll.go
@@ -5,11 +5,14 @@ import (
	"image/color"

[message trimmed]

[PATCH] widget: make editor skip words with key modifier a day ago

From to ~eliasnaur/gio-patches

From: Jack Mordaunt <jackmordaunt@gmail.com>

Signed-off-by: Jack Mordaunt <jackmordaunt@gmail.com>
---
 widget/editor.go      | 53 +++++++++++++++++++++++++++++++++++++++++--
 widget/editor_test.go | 48 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 99 insertions(+), 2 deletions(-)

diff --git a/widget/editor.go b/widget/editor.go
index 7e8fddb..3399a2c 100644
--- a/widget/editor.go
+++ b/widget/editor.go
@@ -7,8 +7,10 @@ import (
	"image"
[message trimmed]

Re: [PATCH] widget: make editor skip words with key modifier 2 days ago

From Jack Mordaunt to ~eliasnaur/gio-patches

I'm happy to make the changes.

The "corruption" may be due to pasting the .patch into my email client
(which is in plaintext mode, so idk why it's not happy). I'll use `git
send-email` next time. 

In regards to your comments, the closure initialisation is a stylistic
choice, as far as I know Go inlines the closures so it's moot with
regards to performance. To me it's cleaner but I understand if that's
not a shared opinion. I'll defer to you. 

> I'd expect
> 
> k.Modifiers == modSkip

[PATCH] widget: make editor skip words with key modifier 2 days ago

From Jack Mordaunt to ~eliasnaur/gio-patches

From ee7af9688385dcc66133c3b2a1aa17361bdb7cc5 Mon Sep 17 00:00:00 2001
From: Jack Mordaunt <jackmordaunt@gmail.com>
Date: Wed, 16 Sep 2020 14:05:26 +0800
Subject: [PATCH] widget: make editor skip words with key modifier

---
 widget/editor.go      | 60 +++++++++++++++++++++++++++++++++++++++++--
 widget/editor_test.go | 49 +++++++++++++++++++++++++++++++++++
 2 files changed, 107 insertions(+), 2 deletions(-)

Make editor skip words with key modifier (default ModCtrl, darwin ModAlt).
Added test harness for the `moveWord` method specifically, as well as
adding a call in the consistency test.
Behaviour modelled on common text editors: eats initial whitespace,

[PATCH] widget: make editor skip words with ctrl key modifier 3 days ago

From Jack Mordaunt to ~eliasnaur/gio-patches

From 276298f20ac87c8bdea5126ba6ea0deecee4e396 Mon Sep 17 00:00:00 2001
From: Jack Mordaunt <jackmordaunt@gmail.com>
Date: Tue, 15 Sep 2020 20:49:30 +0800
Subject: [PATCH] widget: make editor skip words with ctrl key modifier

Signed-off-by: Jack Mordaunt <jackmordaunt@gmail.com>
---
 widget/editor.go      | 53 +++++++++++++++++++++++++++++++++++++++++--
 widget/editor_test.go | 49 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 100 insertions(+), 2 deletions(-)

Skip words in the direction of the arrow key when `ctrl` modifier is
active. 
Added test harness for the `moveWord` method specifically, as well as

[PATCH] feat(editor): skip words with ctrl key modifier 3 days ago

From to ~eliasnaur/gio-patches

From: Jack Mordaunt <jackmordaunt@gmail.com>

---
 widget/editor.go | 52 ++++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 50 insertions(+), 2 deletions(-)

Adds word skip functionality common to text editors.
Holding down `ctrl+arrow` navigates the caret to the next/previous word.

diff --git a/widget/editor.go b/widget/editor.go
index 7e8fddb..8ab229d 100644
--- a/widget/editor.go
+++ b/widget/editor.go
@@ -9,6 +9,7 @@ import (
[message trimmed]

Re: [PATCH sprig 0/1] feat: capture scrolling behaviour with ScrollBar type 18 days ago

From Jack Mordaunt to ~whereswaldon/arbor-dev

> - add my repo as a remote (if you haven't already)
>  `git remote add upstream <URL>`
> - fetch the latest code from my repo
>  `git fetch upstream`
> - make a copy of the branch that you've been working on
>  `git checkout -b <semantic-name>`
> - reorganize this copy of your branch so that all of the commits are
>  *after* the contents of my master branch:
>  `git rebase upstream/master`
> - push this new branch to your remote and submit patches from it (or
>  use git-send-email):
>  `git push -u origin <semantic-name>`

Thanks for this! I had issues because I merged from upstream into my

Re: [PATCH sprig 3/3] feat: axis-independent scrolling 20 days ago

From Jack Mordaunt to ~whereswaldon/arbor-dev

> I'm sorry if I'm being dumb, but what's the use-case for anchoring to the
> Start? I just can't seem to wrap my head around why you'd anchor the scroll
> indicator to the other end of the content area.

I think you're right. I was attempting to write flexible (TM) code. I'll
hardcode to after-content anchoring and remove the `Anchor` field. Unl

>> +// Axis specifies the scroll bar orientation.
>> +// Default to `Vertical`.
>> +type Axis bool
> 
> Can we use the existing layout.Axis type for this?

The reason I created this type is because `layout.Axis` defaults to