HU (UTC+02:00, EU DST applicable and applied to TZ)
I do things on the computer.
From Jackson Chen to ~sircmpwn/sr.ht-dev
seems like firefox 117.0.1 sends the file input field with an empty filename if not file not selected, so do a server side check and return error for requirement if no file provided (presumably from empty filename). --- todosrht/blueprints/settings.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todosrht/blueprints/settings.py b/todosrht/blueprints/settings.py index a9bfd48..740592a 100644 --- a/todosrht/blueprints/settings.py +++ b/todosrht/blueprints/settings.py @@ -378,7 +378,7 @@ def import_POST(owner, name): [message trimmed]
From Jackson Chen to ~sircmpwn/sr.ht-dev
same constraint in editing a comment --- todosrht/blueprints/ticket.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/todosrht/blueprints/ticket.py b/todosrht/blueprints/ticket.py index 0179232..fe9d38b 100644 --- a/todosrht/blueprints/ticket.py +++ b/todosrht/blueprints/ticket.py @@ -164,6 +164,9 @@ def ticket_comment_POST(owner, name, ticket_id): abort(403) else: text = valid.require("comment") valid.expect(not text or 3 <= len(text) <= 16384, [message trimmed]
From Jackson Chen to ~sircmpwn/sr.ht-dev
--- Given that editing comments require a minimum and maximum number of characters, probably doesn't make sense to allow empty comments that isn't a resolve comment. todosrht/blueprints/ticket.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/todosrht/blueprints/ticket.py b/todosrht/blueprints/ticket.py index bb38c03..0179232 100644 --- a/todosrht/blueprints/ticket.py +++ b/todosrht/blueprints/ticket.py @@ -159,8 +159,11 @@ def ticket_comment_POST(owner, name, ticket_id): reopen = valid.optional("reopen") [message trimmed]
From Jackson Chen to ~sircmpwn/sr.ht-dev
it's possible to create a tracker with an empty description, but not edit a tracker to have an empty description. the rewrite lambda turns empty strings into None, resulting in descriptions being never updated if it's empty. --- Don't understand why the rewrite lambda is there, or what purpose it serves. It broke a specific case of editing trackers details. todosrht/blueprints/settings.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/todosrht/blueprints/settings.py b/todosrht/blueprints/settings.py index 5c1abc5..a9bfd48 100644 [message trimmed]
From Jackson Chen to ~sircmpwn/sr.ht-dev
matches server side validation behavior --- todosrht/templates/edit_ticket.html | 3 ++- todosrht/templates/ticket.html | 1 + todosrht/templates/tracker-access.html | 1 + todosrht/templates/tracker-create.html | 3 ++- todosrht/templates/tracker-import-export.html | 3 ++- todosrht/templates/tracker-label-edit.html | 6 ++++-- todosrht/templates/tracker-labels.html | 6 ++++-- todosrht/templates/tracker.html | 3 ++- 8 files changed, 18 insertions(+), 8 deletions(-) diff --git a/todosrht/templates/edit_ticket.html b/todosrht/templates/edit_ticket.html index 692823b..2472844 100644 [message trimmed]
From Jackson Chen to ~sircmpwn/sr.ht-dev
I noticed a lack of client side validation, plus some server side validation differences. This patch fixes most of those tiny issues. Jackson Chen (5): add client side checks for required form fields make empty descriptions on tracker edit work require comment except for close/reopen limit length of new comments check for empty filename on tracker import todosrht/blueprints/settings.py | 5 ++--- todosrht/blueprints/ticket.py | 10 ++++++++-- todosrht/templates/edit_ticket.html | 3 ++- todosrht/templates/ticket.html | 1 +
From Jackson Chen to ~sircmpwn/sr.ht-dev
--- listssrht/templates/user-lists.html | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/listssrht/templates/user-lists.html b/listssrht/templates/user-lists.html index 6cd9896..02ad81d 100644 --- a/listssrht/templates/user-lists.html +++ b/listssrht/templates/user-lists.html @@ -54,10 +54,14 @@ </div> {{pagination()}} {% else %} {% if search %} <p>Nothing found.</p> [message trimmed]
From Jackson Chen to ~sircmpwn/sr.ht-dev
a search result which returns nothing will also hide the search bar, which can be annoying as it requires navigating back to access it again. --- listssrht/templates/user-lists.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/listssrht/templates/user-lists.html b/listssrht/templates/user-lists.html index bd9f71a..6cd9896 100644 --- a/listssrht/templates/user-lists.html +++ b/listssrht/templates/user-lists.html @@ -21,7 +21,6 @@ {% endif %} </div> <div class="col-md-8"> [message trimmed]
From Jackson Chen to ~sircmpwn/sr.ht-dev
fixes low contrast link for oauth legacy link in meta.sr.ht/oauth2 and the confirmation link in user page for user admin. retroactively applies the same CSS selector to other types of alerts, hopefully this doesn't break something existing. --- I'm not aware of anything that requires :not(.btn), so if there is some page that requires it, let me know and I'll check. srht/scss/dark.scss | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/srht/scss/dark.scss b/srht/scss/dark.scss index d923315..42d4d39 100644 [message trimmed]
From Jackson to ~sircmpwn/sr.ht-discuss
I stopped the VM and came back some time later. For some reason, cross-service sourcehut works now. (Although one thing I changed is making unbound (my DNS resolver) respond with actual DNS data for the domains)