Vancouver, BC
From William Casarin to ~andir/nixpkgs-dev
On Sun, Feb 21, 2021 at 09:38:15AM +0100, Matthias Beyer wrote: > Hi, > > On 16-02-2021 17:08:13, Matthias Beyer wrote: > > this is v2 of that patchset as it didn't land yet. > > Rebased to latest master. > > It seems that this is not yet submitted to nixpkgs. > > I'm not blaming anyone here, but maybe this is an indicator that we need better > tooling? :-P I purposely didn't submit it this time since I didn't want to be the bottleneck for all future patches and to give others the chance to do
From William Casarin to ~andir/nixpkgs-dev
Tested-by: William Casarin <jb55@jb55.com>
From William Casarin to ~andir/nixpkgs-dev
Tested-by: William Casarin <jb55@jb55.com>
From William Casarin to ~andir/nixpkgs-dev
On Tue, Feb 16, 2021 at 05:58:12PM +0100, Matthias Beyer wrote: > Am 16. Februar 2021 17:52:17 MEZ schrieb William Casarin <jb55@jb55.com>: > > > >On Tue, Feb 16, 2021 at 05:08:13PM +0100, Matthias Beyer wrote: > >> Matthias Beyer (2): > >> taskwarrior-tui: 0.9.10 -> 0.9.15 > >> taskwarrior-tui: 0.9.15 -> 0.10.3 > > > >This might be an older cover letter since this looks wrong, I'm > >guessing > >it should be: > > > > taskwarrior-tui: 0.9.15 -> 0.10.3 > > taskwarrior-tui: 0.9.10 -> 0.9.15
From William Casarin to ~andir/nixpkgs-dev
Hey Matthias, On Tue, Feb 16, 2021 at 05:08:13PM +0100, Matthias Beyer wrote: > Hi, > > this is v2 of that patchset as it didn't land yet. > Rebased to latest master. > > Closes #112536 > > > Matthias Beyer (2): > taskwarrior-tui: 0.9.10 -> 0.9.15 > taskwarrior-tui: 0.9.15 -> 0.10.3
From William Casarin to ~andir/nixpkgs-dev
On Thu, Feb 11, 2021 at 07:00:47PM +0100, Matthias Beyer wrote: > On 11-02-2021 09:58:16, William Casarin wrote: > > Built but haven't tested since it looks like I need another piece of > > software that I don't have installed: > > > > > [taskwarrior-tui error]: Unable to find executable `task`: No such file > > > or directory (os error 2). Check that taskwarrior is installed correctly > > > and try again. > > Yep, that's taskwarrior missing. Taskwarrior is a runtime dependency of this > package, but is not included in the dependencies of the package. > > I'm open for discussion (or patches!) whether this would be an idea, but I'd > submit such a change in a new patchset.
From William Casarin to ~andir/nixpkgs-dev
Built but haven't tested since it looks like I need another piece of software that I don't have installed: > [taskwarrior-tui error]: Unable to find executable `task`: No such file > or directory (os error 2). Check that taskwarrior is installed correctly > and try again. Reviewed-by: William Casarin <jb55@jb55.com>
From William Casarin to ~andir/nixpkgs-dev
Hey Matthias, Will test this out soon. On Thu, Feb 11, 2021 at 05:40:43PM +0100, Matthias Beyer wrote: > If someone can do a more sophisticated test then nix-building this, > feel free to send me your results and how you produced them. > Otherwise, suggestions and review welcome of course! One thing I recently turned on was in nixpkgs/config.nix: checkMeta = true This catches meta evaluation issues which we were missing before
From William Casarin to ~andir/nixpkgs-dev
thanks! pushed to git://jb55.com/nixpkgs-ml-tools 24cd0c7..f8b4125 master -> master
From William Casarin to ~andir/nixpkgs-dev
Matthias Beyer <mail@beyermatthias.de> writes: > Signed-off-by: Matthias Beyer <mail@beyermatthias.de> > --- > default.nix | 52 ++++++++++++++++++++++++++++++++-------------------- > 1 file changed, 32 insertions(+), 20 deletions(-) > > diff --git a/default.nix b/default.nix > index 6b4d0cc..1f85fe4 100644 > --- a/default.nix > +++ b/default.nix > @@ -1,28 +1,40 @@ > { pkgs ? import <nixpkgs> {} }: >