From Jason Cox to ~rockorager/tcell-term
The caller may have already set the command's environment; don't clobber it when setting TERM. Signed-off-by: Jason Cox <me@jasoncarloscox.com> --- vt.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/vt.go b/vt.go index b824208..f15dbb8 100644 --- a/vt.go +++ b/vt.go @@ -135,7 +135,12 @@ func (vt *VT) Start(cmd *exec.Cmd) error { if vt.TERM == "" { [message trimmed]
From Jason Cox to ~rjarry/aerc-discuss
On Wed Aug 30, 2023 at 12:16 PM EDT, Tim Culverhouse wrote: > This would be a bug in go-message. The email is valid MIME (RFC2045 doesn't > require boundaries to be different). Looks like it's even already reported there: https://github.com/emersion/go-message/issues/164 Thanks! -- Jason Cox jasoncarloscox.com
From Jason Cox to ~rjarry/aerc-discuss
Hi everyone,
I got an email this morning -- looks like spam to me -- that doesn't
display properly in the message list. I see the beginning of an error
message ("template: column-...") in the subject field and nothing in any
other field. It also gives me an error when I try to open it: "could not
get structure: could not parse child entity structure: multipart:
NextPart: EOF". My webmail client is able to show the email just fine.
I've attached the aerc log, and a redacted version of the email, which
still causes the above beahvior, is available at
https://paste.sr.ht/~jcc/c9214baadb716abe57abcedea32995b3eb688920. I'm
on version 0.15.2-18-g8dca1171c7c4, but testing out the latest master
gives the same result.
From Jason Cox to ~rjarry/aerc-discuss
> > How can I disable the default tw=80 hard line breaks? When I just open > > vim in the terminal, it's not enabled. Couldn't find anything in the > > config file. I suppose that aerc somehow passes this as an option to > > $EDITOR? > > I don't think aerc does _anything_ with your editor, unless you configured > something yourself. Try opening vim and setting `:set ft=mail` and see if you > also have hard wrapping there. I think that should be the case. In that case > you need to configure vim not to do that for email, e.g, in > ~/.vim/after/ftplugin/mail.vim: > > https://github.com/ferdinandyb/dotfiles/blob/b95ebf3fa5d86783eda2a6b6a085bd5b3df43029/.vim/after/ftplugin/mail.vim#L5 Yep, this is default Vim behavior for emails, which it detects based on
From Jason Cox to ~rjarry/aerc-discuss
Hey Tim, On Sat May 27, 2023 at 7:30 PM EDT, Timothy Hume wrote: > I'm puzzing over how to view just one message that I get each day in my > INBOX. The message is PGP encrypted. When decrypted, there is a message > which is encoded in base64. Other Email clients display this correctly. > But aerc displays it like this (see below - the headers appear in the > body of the message too). I've tried various filters to no avail. I can > of course cut and paste the base64 portion and decode it on the command > line with base64 -d , but there surely must be a way to get it to > display in aerc? Not really an ideal or permanent solution, but you could write a custom filter that strips the headers and then decodes the body. If it's always
From Jason Cox to ~rjarry/aerc-devel
Ask user whether they want to abort before sending if the subject header is empty and they have enabled the warn-empty-subject config option. Signed-off-by: Jason Cox <me@jasoncarloscox.com> --- v2->v3: Still show attachment warning on error. CHANGELOG.md | 5 +++++ commands/compose/send.go | 17 +++++++++++------ config/aerc.conf | 5 +++++ config/compose.go | 1 + doc/aerc-config.5.scd | 5 +++++ widgets/compose.go | 22 +++++++++++++++++----- [message trimmed]
From Jason Cox to ~rjarry/aerc-devel
On Wed May 10, 2023 at 9:43 AM EDT, Tim Culverhouse wrote: > On Wed Apr 26, 2023 at 1:31 PM CDT, Jason Cox wrote: > > Ask user whether they want to abort before sending if the subject header > > is empty and they have enabled the warn-empty-subject config option. > > > > Signed-off-by: Jason Cox <me@jasoncarloscox.com> > > --- > > Hey Jason - > > Thanks for the patch! A few comments below > > > -func (c *Composer) ShouldWarnAttachment() (bool, error) { > > +func (c *Composer) ShouldWarnAttachment() bool {
From Jason Cox to ~rjarry/aerc-devel
It's nice to use a different style for the chunk's function name to make it clear that the name is not necessarily adjacent to the chunk's actual lines. Signed-off-by: Jason Cox <me@jasoncarloscox.com> --- v2 -> v3: Update docs and changelog. (Sorry for the spam!) CHANGELOG.md | 4 ++++ doc/aerc-stylesets.7.scd | 2 ++ filters/colorize.c | 7 ++++++- filters/vectors/colorize-patch.expected | 2 +- 4 files changed, 13 insertions(+), 2 deletions(-) [message trimmed]
From Jason Cox to ~rjarry/aerc-devel
It's nice to use a different style for the chunk's function name to make it clear that the name is not necessarily adjacent to the chunk's actual lines. Signed-off-by: Jason Cox <me@jasoncarloscox.com> --- v1->v2 forgot to sign off because my git hooks weren't properly configured filters/colorize.c | 7 ++++++- filters/vectors/colorize-patch.expected | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/filters/colorize.c b/filters/colorize.c [message trimmed]
From Jason Cox to ~rjarry/aerc-devel
It's nice to use a different style for the chunk's function name to make it clear that the name is not necessarily adjacent to the chunk's actual lines. --- I'm open to tweaking the default styles. I just picked something that seems reasonable and allows differentiating between the diff_chunk and the diff_chunk_func in the test. filters/colorize.c | 7 ++++++- filters/vectors/colorize-patch.expected | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/filters/colorize.c b/filters/colorize.c [message trimmed]