~jeffas

Recent activity

Re: [PATCH 6/7] Add threading control path to msglist.Draw() a month ago

From Jeffas to ~sircmpwn/aerc

On Thu Oct 10, 2019 at 3:27 PM Kevin Kuehler wrote:
> @@ -37,7 +37,7 @@ func (trig *TriggersConfig) ExecNewEmail(account *AccountConfig,
>  	err := trig.ExecTrigger(trig.NewEmail,
>  		func(part string) (string, error) {
>  			formatstr, args, err := format.ParseMessageFormat(part,
> -				conf.Ui.TimestampFormat, account.Name, 0, msg)
> +				conf.Ui.TimestampFormat, account.Name, 0, msg, "") // TODO: check with jeffas how to handle this

I think this should be fine to have, I don't think the arrow threading
should be included in the subject for this trigger.

Re: [PATCH 1/7] Start adding thread support a month ago

From Jeffas to ~sircmpwn/aerc

Thank you so much for these patches, a much wanted feature!

Some initial notes:

1. Doesn't seem to work with gmail. I think this is because gmail uses
their own name for the cabability, not sure if it would be best to
address in library or here (if possible).

2. sorting doesn't seem to work at all. Would probably also need to make
sorting aware of the recursive nature of threads and maybe change
sorting so that for example the date used is the most recent of those in
the thread.

3. not sure if this is a problem or not but I just noticed that the

[PATCH v2] Fix tab refocus on remove a month ago

From Jeffas to ~sircmpwn/aerc

Previously removing a tab would always pop from the history of tabs.
This checks to see if the closing tab is the one selected, if it is then
we use the history, otherwise we only need to change the selected tab if
it was after (to the right of) the closing tab, in which case we just
decrement the selected index.
---
 lib/ui/tab.go | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/lib/ui/tab.go b/lib/ui/tab.go
index 9c19cd7..07ed256 100644
--- a/lib/ui/tab.go
+++ b/lib/ui/tab.go
@@ -62,25 +62,31 @@ func (tabs *Tabs) invalidateChild(d Drawable) {
[message trimmed]

[PATCH] Fix pushing invalid tabs to history a month ago

From Jeffas to ~sircmpwn/aerc

A tab can now only be pushed onto the history if it is a selectable tab.
---
 lib/ui/tab.go | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/ui/tab.go b/lib/ui/tab.go
index 9c19cd7..ef9fcd8 100644
--- a/lib/ui/tab.go
+++ b/lib/ui/tab.go
@@ -107,7 +107,10 @@ func (tabs *Tabs) Select(index int) {
 	}

 	if tabs.Selected != index {
-		tabs.pushHistory(tabs.Selected)
[message trimmed]

[PATCH] Fix tab refocus on remove a month ago

From Jeffas to ~sircmpwn/aerc

Previously removing a tab would always pop from the history of tabs.
This checks to see if the closing tab is the one selected, if it is then
we use the history, otherwise we don't need to change the currently
selected tab.
---
 lib/ui/tab.go | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/lib/ui/tab.go b/lib/ui/tab.go
index 9c19cd7..5e64c41 100644
--- a/lib/ui/tab.go
+++ b/lib/ui/tab.go
@@ -63,10 +63,12 @@ func (tabs *Tabs) invalidateChild(d Drawable) {
[message trimmed]

Re: [PATCH] Add Templates a month ago

From Jeffas to ~sircmpwn/aerc

On Tue Oct 8, 2019 at 1:16 PM Srivathsan Murali wrote:
> I was wondering about this. But I was unsure about how to handle for
> some options for reply and forward.
> For example, should templates be available for quoted replies and
> or for when messages are forwarded as body.

Hmm, I'm not immediately sure how this should work so seems good to just
keep this to compose for now.

[PATCH v4 4/4] Add documentation for edit command a month ago

From Jeffas to ~sircmpwn/aerc

---
 doc/aerc.1.scd | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/aerc.1.scd b/doc/aerc.1.scd
index f534f05..cbe8e1f 100644
--- a/doc/aerc.1.scd
+++ b/doc/aerc.1.scd
@@ -96,6 +96,10 @@ message list, the message in the message viewer, etc).
 *delete*
 	Deletes the selected message.

+*recall*
+	Opens the selected message for re-editing. Messages can only be
[message trimmed]

[PATCH v4 3/4] Add recall command a month ago

From Jeffas to ~sircmpwn/aerc

This command allows recalling the selected postponed email to edit in
the composer. The command only allows recalling from the postpone
directory.
---
 commands/msg/recall.go | 121 +++++++++++++++++++++++++++++++++++++++++
 widgets/account.go     |   4 ++
 2 files changed, 125 insertions(+)
 create mode 100644 commands/msg/recall.go

diff --git a/commands/msg/recall.go b/commands/msg/recall.go
new file mode 100644
index 0000000..116d489
--- /dev/null
+++ b/commands/msg/recall.go
[message trimmed]

[PATCH v4 2/4] Add documentation for postpone a month ago

From Jeffas to ~sircmpwn/aerc

Adds docs for the postpone command and the Postpone accounts.conf config
option. A default for the postpone config option is provided of: Drafts.
---
 config/binds.conf     | 1 +
 config/config.go      | 9 +++++----
 doc/aerc-config.5.scd | 5 +++++
 doc/aerc.1.scd        | 4 ++++
 4 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/config/binds.conf b/config/binds.conf
index ac49bd0..ea6b99e 100644
--- a/config/binds.conf
+++ b/config/binds.conf
@@ -87,6 +87,7 @@ $ex = <C-x>
[message trimmed]

[PATCH v4 1/4] Add postpone command a month ago

From Jeffas to ~sircmpwn/aerc

This command uses the Postpone folder from the account config to save
messages to. Messages are saved as though they were sent so have a valid
'to' recipient address and should be able to be read back in for later
editing.
---

This revision checks the list of directories for an existing one and
only creates a new one if not present.

 commands/account/compose.go  |   2 +-
 commands/compose/postpone.go | 113 +++++++++++++++++++++++++++++++++++
 commands/msg/forward.go      |   2 +-
 commands/msg/reply.go        |   2 +-
 commands/msg/unsubscribe.go  |   1 +
[message trimmed]