Recent activity

[PATCH] Check account's from value is not empty 1 year, 9 months ago

From Andrew Jeffery to ~sircmpwn/aerc

This leads to a nasty 'mail: no address' message for each email if left
empty so the user really should enter it.
---
 config/config.go | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/config/config.go b/config/config.go
index bb83579..87d183a 100644
--- a/config/config.go
+++ b/config/config.go
@@ -216,6 +216,9 @@ func loadAccountConfig(path string) ([]AccountConfig, error) {
		if account.Source == "" {
			return nil, fmt.Errorf("Expected source for account %s", _sec)
		}
[message trimmed]

[PATCH] Only send directory info once from maildir 2 years ago

From Andrew Jeffery to ~sircmpwn/aerc

The directory info only needs to be sent once for all the messages, this
reduces unnecessary messages being sent which could lock up the ui.
---
 worker/maildir/worker.go | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/worker/maildir/worker.go b/worker/maildir/worker.go
index 467f2aa..ce548ff 100644
--- a/worker/maildir/worker.go
+++ b/worker/maildir/worker.go
@@ -498,11 +498,12 @@ func (w *Worker) handleFlagMessages(msg *types.FlagMessages) error {
			Message: types.RespondTo(msg),
			Info:    info,
		}, nil)
[message trimmed]

[PATCH] Remove deleted messages from search/filter results 2 years ago

From Andrew Jeffery to ~sircmpwn/aerc

This ensures that when moving/deleting messages with a filter active the
view gets updated properly.
---
 lib/msgstore.go | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/lib/msgstore.go b/lib/msgstore.go
index dda15d3..d823fa5 100644
--- a/lib/msgstore.go
+++ b/lib/msgstore.go
@@ -248,6 +248,15 @@ func (store *MessageStore) Update(msg types.WorkerMessage) {
			}
		}
		store.uids = uids
[message trimmed]

[PATCH v2] Allow open to be asynchronous 2 years ago

From Andrew Jeffery to ~sircmpwn/aerc

This stops the ui being blocked while the resource is opened. The wait
ensures that resources are reclaimed when the process finishes while
aerc is still running.
---

- Moved the error handling to a func so it works with the async error

 commands/msg/unsubscribe.go |  2 +-
 commands/msgview/open.go    |  5 ++---
 lib/open.go                 | 15 +++++++++++++--
 lib/open_darwin.go          | 15 +++++++++++++--
 4 files changed, 29 insertions(+), 8 deletions(-)

diff --git a/commands/msg/unsubscribe.go b/commands/msg/unsubscribe.go
[message trimmed]

Re: [PATCH] Allow open to be asynchronous 2 years ago

From Andrew Jeffery to ~sircmpwn/aerc

On Sun Jul 5, 2020 at 11:58 PM BST, Simon Ser wrote:
> No need to start a goroutine if we're going to ignore the error
> returned by Wait.

Hmm, I initially included it as the docs say it releases any underlying
resources associated with the command. I'd rather not swallow the error
and show it to the user, I'll work on that and send a v2, thanks!

[PATCH] Allow open to be asynchronous 2 years ago

From Andrew Jeffery to ~sircmpwn/aerc

This stops the ui being blocked while the resource is opened. The wait
ensures that resources are reclaimed when the process finishes while
aerc is still running.
---
 lib/open.go        | 10 +++++++++-
 lib/open_darwin.go | 10 +++++++++-
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/lib/open.go b/lib/open.go
index ad6533e..7c85ae5 100644
--- a/lib/open.go
+++ b/lib/open.go
@@ -8,5 +8,13 @@ import (
[message trimmed]

[PATCH] Fix a nil Envelope when getting the format 2 years ago

From Andrew Jeffery to ~sircmpwn/aerc

When getting the format for a message the envelope can be nil and this
shouldn't crash the program.
---
 lib/format/format.go | 48 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/lib/format/format.go b/lib/format/format.go
index b66a180..5f45e58 100644
--- a/lib/format/format.go
+++ b/lib/format/format.go
@@ -76,6 +76,10 @@ func ParseMessageFormat(
		case '%':
			retval = append(retval, '%')
		case 'a':
[message trimmed]

[PATCH] Fix nil pointer deref on Envelope 2 years ago

From Andrew Jeffery to ~sircmpwn/aerc

The Envelope was nil but being deref'ed for the Subject. This was
experienced when switching tabs on IMAP.
---
 widgets/msglist.go | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/widgets/msglist.go b/widgets/msglist.go
index 626f4c9..1ed6bb1 100644
--- a/widgets/msglist.go
+++ b/widgets/msglist.go
@@ -123,11 +123,15 @@ func (ml *MessageList) Draw(ctx *ui.Context) {
		}

		ctx.Fill(0, row, textWidth, 1, ' ', style)
[message trimmed]

[PATCH] Add optional percentage to select command 2 years ago

From Jeffas to ~sircmpwn/aerc

This allows users to jump to messages by percentage, e.g. select 50%.
---

Also fixes a bug in the msgstore select function going off the end.

 commands/account/select.go | 31 ++++++++++++++++++++++++++++---
 doc/aerc.1.scd             |  7 ++++---
 lib/msgstore.go            |  4 ++--
 widgets/msglist.go         |  4 ++++
 4 files changed, 38 insertions(+), 8 deletions(-)

diff --git a/commands/account/select.go b/commands/account/select.go
index b41b234..dd930cb 100644
--- a/commands/account/select.go
[message trimmed]

[PATCH] Sort command completions 2 years ago

From Jeffas to ~sircmpwn/aerc

Previously the completions weren't sorted which led to a difficult to
navigate list, especially for the command names as it would randomly
jump through the alphabet.
---
 aerc.go | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/aerc.go b/aerc.go
index 12d9453..17b3c57 100644
--- a/aerc.go
+++ b/aerc.go
@@ -6,6 +6,7 @@ import (
	"io/ioutil"
	"log"
[message trimmed]