~jeffas

Recent activity

Re: [PATCH v2 1/4] Add postpone command a day ago

From Jeffas to ~sircmpwn/aerc

Regarding the recall from mail folders. Should recall only permit
recalling messages from the configured location? Otherwise it could be
used like a general "edit" still.

Re: [PATCH v2 1/4] Add postpone command a day ago

From Jeffas to ~sircmpwn/aerc

On Fri Sep 20, 2019 at 3:10 PM Drew DeVault wrote:
> I would rather not support writing to a file here, yet.

No problem, I can remove those parts.

> I also presume :edit is included for the purpose of recalling your
> drafts?

Yes, :edit was for recalling the selected message for editing.
Essentially meant for the drafts.

> I would prefer a dedicated :recall command and to address editing
> emails later, and somewhat differently.

[PATCH] Sort path completions a day ago

From Jeffas to ~sircmpwn/aerc

---
 commands/util.go | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/commands/util.go b/commands/util.go
index 81d2da6..a5c30af 100644
--- a/commands/util.go
+++ b/commands/util.go
@@ -6,6 +6,7 @@ import (
 	"os"
 	"os/exec"
 	"path/filepath"
+	"sort"
 	"strings"
[message trimmed]

[PATCH] Change sorting flags a day ago

From Jeffas to ~sircmpwn/aerc

This changes the sorting flags for maildir and imap backends.

They now no longer use -t for searching all text. This seems to make
more sense as being the targeted recipient. I have similarly added Cc
for -c. The text search now resides under -a for all text.
---
 doc/aerc-search.1.scd    | 12 ++++++++++--
 worker/imap/search.go    |  8 ++++++--
 worker/maildir/search.go |  8 ++++++--
 3 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/doc/aerc-search.1.scd b/doc/aerc-search.1.scd
index fae241a..614a2bd 100644
--- a/doc/aerc-search.1.scd
[message trimmed]

[PATCH] Make commands join args with spaces a day ago

From Jeffas to ~sircmpwn/aerc

This patch ensures the following commands join their arguments with
spaces to make it easier to interact with:

- cf
- mkdir
- cd
- attach
- detach
- ct
- copy
- move
- save
---
 commands/account/cf.go     | 10 ++++------
[message trimmed]

[PATCH v2 4/4] Add documentation for edit command a day ago

From Jeffas to ~sircmpwn/aerc

---
 doc/aerc.1.scd | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/aerc.1.scd b/doc/aerc.1.scd
index e89f5e7..05e23f6 100644
--- a/doc/aerc.1.scd
+++ b/doc/aerc.1.scd
@@ -96,6 +96,10 @@ message list, the message in the message viewer, etc).
 *delete*
 	Deletes the selected message.
 
+*edit* [filename]
+	Opens the selected message for editing. If *filename* is provided then
[message trimmed]

[PATCH v2 3/4] Add edit command a day ago

From Jeffas to ~sircmpwn/aerc

This command allows editing any email in the composer. By default the
command uses the selected message to edit again but can optionally take
a filepath and use this to read the email from.
---
 commands/msg/edit.go | 151 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 151 insertions(+)
 create mode 100644 commands/msg/edit.go

diff --git a/commands/msg/edit.go b/commands/msg/edit.go
new file mode 100644
index 0000000..727d941
--- /dev/null
+++ b/commands/msg/edit.go
@@ -0,0 +1,151 @@
[message trimmed]

[PATCH v2 2/4] Add documentation for postpone a day ago

From Jeffas to ~sircmpwn/aerc

Adds docs for the postpone command and the Postpone accounts.conf config
option. A default for the postpone config option is provided of: Drafts.
---
 config/binds.conf     | 1 +
 config/config.go      | 9 +++++----
 doc/aerc-config.5.scd | 5 +++++
 doc/aerc.1.scd        | 5 +++++
 4 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/config/binds.conf b/config/binds.conf
index ac49bd0..ea6b99e 100644
--- a/config/binds.conf
+++ b/config/binds.conf
@@ -87,6 +87,7 @@ $ex = <C-x>
[message trimmed]

[PATCH v2 1/4] Add postpone command a day ago

From Jeffas to ~sircmpwn/aerc

This command uses the Postpone folder from the account config to save
messages to. Alternatively the directory to save to may be provided as
an argument to the command. Messages are saved as though they were sent
so have a valid 'to' recipient address and should be able to be read
back in for later editing.
---

Changed default postpone location to Drafts. Add postpone command to
binds.conf.

 commands/compose/postpone.go | 152 +++++++++++++++++++++++++++++++++++
 config/config.go             |   1 +
 widgets/compose.go           |   2 +-
 3 files changed, 154 insertions(+), 1 deletion(-)
[message trimmed]

Re: [PATCH v3 1/2] Add sorting functionality 2 days ago

From Jeffas to ~sircmpwn/aerc

On Tue Sep 17, 2019 at 11:36 PM Reto wrote:
> I think we can get away with doing this in the FetchDirectoryContents
> event, else you make 2 round trips instead of a single one if you can do it
> server side (only IMAP can do that). Or do I misunderstand?
> For the on the fly config change, we could simply emit the same event again.

Thanks for this suggestion, it sounds like a great idea and have made
this change. It should particularly help IMAP out as that is over the
network but also aids and simplifies the other backends!

> ## Can we extract the implementation of the sorting from the maildir worker?

Done!