From Jeff Martin to ~rjarry/aerc-devel
On Sat Oct 15, 2022 at 11:33 PM PDT, Moritz Poldrack wrote: > I: I think the default behaviour should be kept as-is. I agree. aerc was sending EHLO localhost by before and still is with this patch. My change only adds a config var with the same value to allow for it to be overridden. FWIW, this is the default value of net/smtp and emersion/go-smtp as well. Left a link to some discussion about this among the go authors for reference below. > There are valid > reasons to wish to hide one's hostname, but I don't think it should > be the default. I would prefer an approach where by default the > system's hostname is used and if the user does not want that, they > are free to set this configuration to send a different string
From Jeff Martin to ~rjarry/aerc-devel
Hi, On Tue Oct 18, 2022 at 12:09 PM PDT, Robin Jarry wrote: > Please avoid this and prefer git-send-email -vN. will do in the future > > > Signed-off-by: Jeff Martin <jeff@jeffrom.co> > > Cc: Moritz Poldrack <moritz@poldrack.dev> > > --- > > commands/compose/send.go | 40 ++++++++++++++++++++++++++-------------- > > config/config.go | 1 + > > 2 files changed, 27 insertions(+), 14 deletions(-)
From Jeff Martin to ~rjarry/aerc-devel
On Tue Oct 18, 2022 at 12:04 PM PDT, Robin Jarry wrote: > Please avoid adding such references. It is best to use git-send-email > -v/--reroll-count flag to indicate that this patch is a follow up on > a previous version. Apologies, wasn't sure what the right thing to do was as the previous patch was an rfc and the functionality changed pretty significantly from one to the next. Jeff
From Jeff Martin to ~emersion/soju-dev
This change introduces support for the palaver push notifications
extension. It requires no additional user configuration, as the required
data comes from the CAP negotiation and subsequent commands described
in the palaver capability spec.
This is an exploratory RFC patch to give a sense of what an
implementation of this feature could look like. The patch enables
sending push notifications that, when tapped on the device, route to the
correct buffer in palaver. Nothing beyond that is implemented (ie no
proper badge management, no checking palaver notification preferences).
Only the sqlite database interface is implemented.
The implementation is at a high level is: At the beginning of each
connection to soju, Palaver sends "PALAVER IDENTIFY" along with its the
[message trimmed]
From Jeff Martin to ~emersion/soju-dev
This change uses string formatting for the output of debug.Stack. The output of debug.Stack is []byte, which isn't human readable. Also use the '%s' verb instead of '%v' for the stacktrace, since we know what type it is. --- server.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server.go b/server.go index 48cfc7c..e2b502a 100644 --- a/server.go +++ b/server.go @@ -393,7 +393,7 @@ func (s *Server) addUserLocked(user *database.User) *user { [message trimmed]
From Jeff Martin to ~emersion/soju-dev
after sending this, i noticed that the issue is actually that sometimes entry is a pointer, other times a value. sorry for the spam. On 22/06/05 01:18PM, Jeff Martin wrote: > --- > noticed this when deploying HEAD today > downstream.go | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/downstream.go b/downstream.go > index 26032eb..4992546 100644 > --- a/downstream.go > +++ b/downstream.go > @@ -3331,8 +3331,8 @@ func sendNames(dc *downstreamConn, ch *upstreamChannel) {
From Jeff Martin to ~emersion/soju-dev
--- noticed this when deploying HEAD today downstream.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/downstream.go b/downstream.go index 26032eb..4992546 100644 --- a/downstream.go +++ b/downstream.go @@ -3331,8 +3331,8 @@ func sendNames(dc *downstreamConn, ch *upstreamChannel) { var members []string for _, entry := range ch.Members.innerMap { nick := entry.originalKey memberships := entry.value.(*xirc.MembershipSet) [message trimmed]
From Jeff Martin to ~sircmpwn/aerc
This change handles message parse errors by printing the error when the
user tries to view the message. Specifically only handling unknown
charset errors in this patch, but there are many types of invalid
messages that can be handled in this way.
aerc currently leaves certain messages in the msglist in the pending
(spinner) state, and I'm unable to view or modify the message. aerc also
only prints parse errors with message when they are initially loaded.
This UX is a little better, because you can still see the header info
about the message, and if you try to view it, you will see the specific
error.
Thanks to the folks who exposed IsUnknownCharset in emersion/go-message!
---
[message trimmed]
From Jeff Martin to ~sircmpwn/aerc
Write panic error and stacktrace to the apps logger. Panics that occur while the ui is running leave the terminal in a garbled state, making it difficult to read the stacktrace. The app log is the logical place to write it. --- wups, shadowed err in the last patch -_- aerc.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/aerc.go b/aerc.go index 17b3c57..964d6bf 100644 --- a/aerc.go +++ b/aerc.go [message trimmed]
From Jeff Martin to ~sircmpwn/aerc
Write panic error and stacktrace to the apps logger. Panics that occur while the ui is running leave the terminal in a garbled state, making it difficult to read the stacktrace. The app log is the logical place to write it. --- aerc.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/aerc.go b/aerc.go index 17b3c57..41e30b5 100644 --- a/aerc.go +++ b/aerc.go @@ -6,6 +6,7 @@ import ( "io/ioutil" [message trimmed]