From jack gleeson to ~sircmpwn/sr.ht-dev
Fixing issue on low resolutions / narrow screens where the breadcrumb menu items overlap under the reference items to the right. This is closer to the hg.sr.ht layout which wraps on narrow screens. --- scss/main.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/scss/main.scss b/scss/main.scss index 4aacbda..0f251d6 100644 --- a/scss/main.scss +++ b/scss/main.scss @@ -414,7 +414,6 @@ img { display: flex; [message trimmed]
From to ~sircmpwn/sr.ht-discuss
We can fix this by removing the white-space: nowrap; value that applies to breadcrumb in the css. Happy to submit a patch for this if that's acceptable. Image here showing this change. https://jpgleeson.com/content/srht-nowrap.png Jack
From to ~sircmpwn/sr.ht-dev
Screenshots below. I find the contrast between the two colours a bit too close for easy reading. Maybe a better solution is to change the link colour in the alert-info box, but this seemed a smaller change in terms of consistency with everything else. Original: https://jpgleeson.com/content/srht-darktheme-originalcrop.png Patched: https://jpgleeson.com/content/srht-darktheme-modifiedcrop.png December 19, 2020 9:30 AM, "Drew DeVault" <sir@cmpwn.com> wrote: > Do you have a before/after screenshot to share?
From jack gleeson to ~sircmpwn/sr.ht-dev
Variables have been scoped to dark as per previous email. I find the contrast between the links and the alert-info boxes to be low, making them hard to read on some of my screens. This is a change to make them a bit more readable but feedback from others to confirm it's not just me having a hard time reading it would be useful. --- srht/scss/dark.scss | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/srht/scss/dark.scss b/srht/scss/dark.scss index 8749fc4..b207d66 100644 [message trimmed]
From jack gleeson to ~sircmpwn/sr.ht-dev
--- srht/scss/dark.scss | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/srht/scss/dark.scss b/srht/scss/dark.scss index 8749fc4..a9f1a9f 100644 --- a/srht/scss/dark.scss +++ b/srht/scss/dark.scss @@ -1,7 +1,10 @@ $primary-dark: darken($primary, 10); $success-dark: #2bb34b; $danger-dark: #ff3e3e; $muted-dark: $gray-400; [message trimmed]
From to ~sircmpwn/sr.ht-discuss
Would using the notes box when entering the manifest work for you here? It puts the text just below the id of the job, not as immediately readable as the headers above, but definitely apparent.
From to ~sircmpwn/sr.ht-discuss
November 14, 2020 10:20 PM, "Tim Allen" <st@thristian.org> wrote: > > EF BB BF is the UTF-8 encoding of the Unicode Byte Order Mark, which is > some applications use to detect Unicode content, and to detect which > encoding it uses: > > I say "some applications", but in practice it's almost always Windows > applications, and specifically Windows Notepad that use a byte-order > mark, horribly confusing Unix tools that examine the first bytes of a > file and not the first printable character. Thanks for this. That clears everything up. I can’t remember if either file was created in visual studio or sublime text, but both were definitely from windows.
From to ~sircmpwn/sr.ht-discuss
I know you use Jinja for markup parsing for the README files in the repos. Is there an issue with this where the first line can't start on a header markup? I've noticed this in a number of my own repositories, as well as some others, e.g. https://git.sr.ht/~jpgleeson/piaine/ https://git.sr.ht/~jpgleeson/spawsh/ https://sr.ht/~bhowell/quatch-express/ Is this an issue with files that were created on Windows possibly?
From to ~sircmpwn/sr.ht-discuss
Patch submitted last night, #14863 on the sr.ht-dev mailing list. The ArchLinux build job failed because the keyserver was unreachable, but the other builds succeeded, and the CSS change should not require this anyway. Let me know if you want me to resubmit this or if that is sufficient. Thanks, Jack November 10, 2020 11:24 AM, "Drew DeVault" <sir@cmpwn.com> wrote: > Can you send a patch?
From jack gleeson to ~sircmpwn/sr.ht-dev
--- Intended to fix the clipping issue in the breadcrumb menu where latest commit is drawn over the log tab. scss/main.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/scss/main.scss b/scss/main.scss index 1ea668d..05a528c 100644 --- a/scss/main.scss +++ b/scss/main.scss @@ -342,6 +342,7 @@ img { .breadcrumb { white-space: nowrap; [message trimmed]
