DomainKey-Signature: a=rsa-sha1; c=nofws; d=typed-hole.org; h=
	mime-version:content-transfer-encoding:content-type:from:to
	:subject:date:message-id:in-reply-to; q=dns; s=20190925; b=vYan4
	FNZsVoCOingAlihnObw+AQMLmBCpfF+F0iNQZZyUWpimltxc0j7yps2bjiovYS/3
	K7SF/pKlxILbOBTJpAQn0w0ZHjZZaYnNJ2cDlXkr87Dtu6H0soBRAT6+zHXSdcW2
	8PmdJxOpFp7u0qAdmAjtLCnsTafh6OlMs/D4Ve+Y1v9BbNhibaUoLOqnQgHLsv0r
	TP1lhv9cn9q8+K1T0bkUd8y7i0D5vYvSq4gw86NDHbe1aMjwZL7iLpivM9NxH2LE
	/QP2DMEtqveipOa6ZT6mGX9sGwxfyegYZ5V3CZOuDqIa7fZpcGoIeGTU5xyTg4BY
	mLHLj+bxs3KHsI3yA==
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
From: "Julien Blanchard" <julien@typed-hole.org>
To: <johann.galle@protonmail.com>, <~julienxx/asuka@lists.sr.ht>
Subject: Re: [PATCH] add secret input capability
Date: Mon, 09 Nov 2020 12:38:04 +0100
Message-Id: <C6YPBR9W9O1P.317ZSNIXYMACC@t495.typed-hole.org>
In-Reply-To: <20201108152659.4676-1-johann.galle@gmx.net>

Thanks for the patch! How about creating a new Status::Secret that would
be using a prompt_for_secret_answer method?

On Sun Nov 8, 2020 at 4:27 PM CET, Johann150 wrote:
> From: Johann150 <johann.galle@protonmail.com>
>
> This adds the secret input capability as specified for status code 11.
> ---
> Tested.
>
> src/main.rs | 24 ++++++++++++++----------
> src/status.rs | 5 +++--
> 2 files changed, 17 insertions(+), 12 deletions(-)
>
> diff --git a/src/main.rs b/src/main.rs
> index a8c2087..2f67844 100644
> --- a/src/main.rs
> +++ b/src/main.rs
> @@ -98,20 +98,24 @@ fn prompt_for_url(s: &mut Cursive) {
> );
> }
>
> -fn prompt_for_answer(s: &mut Cursive, url: Url, message: String) {
> +fn prompt_for_answer(s: &mut Cursive, url: Url, message: String,
> secret: bool) {
> s.add_layer(
> Dialog::new()
> .title(message)
> // Padding is (left, right, top, bottom)
> .padding((1, 1, 1, 0))
> .content(
> - EditView::new()
> - .on_submit(move |s, response| {
> - let link =3D format!("{}?{}", url.to_string(), response);
> - s.pop_layer();
> - follow_link(s, &link);
> - })
> - .fixed_width(60),
> + if secret {
> + EditView::new().secret()
> + } else {
> + EditView::new()
> + }
> + .on_submit(move |s, response| {
> + let link =3D format!("{}?{}", url.to_string(), response);
> + s.pop_layer();
> + follow_link(s, &link);
> + })
> + .fixed_width(60),
> )
> .with_id("url_query"),
> );
> @@ -239,8 +243,8 @@ fn handle_response_status(
> ));
> None
> }
> - Status::Input(message) =3D> {
> - prompt_for_answer(s, url_copy, message);
> + Status::Input(message, secret) =3D> {
> + prompt_for_answer(s, url_copy, message, secret);
> None
> }
> other_status =3D> {
> diff --git a/src/status.rs b/src/status.rs
> index 2b70940..d6aad96 100644
> --- a/src/status.rs
> +++ b/src/status.rs
> @@ -5,7 +5,7 @@ use std::str::FromStr;
>
> #[derive(Debug)]
> pub enum Status {
> - Input(String),
> + Input(String, bool),
> Success(String),
> SuccessEndOfClientCertificateSession(String),
> RedirectTemporary(String),
> @@ -58,7 +58,8 @@ impl FromStr for Status {
>
> fn make_status(code: i16, meta: String) -> Status {
> match code {
> - 10 =3D> Status::Input(meta),
> + 10 =3D> Status::Input(meta, false),
> + 11 =3D> Status::Input(meta, true),
> 20 =3D> Status::Success(meta),
> 21 =3D> Status::SuccessEndOfClientCertificateSession(meta),
> 30 =3D> Status::RedirectTemporary(meta),
> --
> 2.20.1