~kennylevinsen/greetd-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH greetd] fakegreet: reset state on errors

Details
Message ID
<20220817153110.380790-1-alebastr89@gmail.com>
DKIM signature
missing
Download raw message
Patch: +4 -0
Some greeters were sending CancelSession in response to Error, likely
because it was necessary for a consistent internal state of fakegreet.

Change fakegreet to comply with the protocol doc, which states that the
sessions are automatically cancelled on error, and remove the need for
the redundant CancelSession.
---
 fakegreet/src/main.rs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fakegreet/src/main.rs b/fakegreet/src/main.rs
index 187551e..89aa05b 100644
--- a/fakegreet/src/main.rs
+++ b/fakegreet/src/main.rs
@@ -141,6 +141,10 @@ async fn client_handler(ctx: &Context, mut s: UnixStream) -> Result<(), Error> {
            Request::CancelSession => wrap_result(ctx.cancel().await),
        };

        if let Response::Error { .. } = resp {
            ctx.cancel().await?;
        }

        println!("resp: {:?}", resp);
        resp.write_to(&mut s).await?;
    }
-- 
2.37.2

[greetd/patches] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CM8EWPEL0ZEC.2Y525PYUQ64U4@cirno>
In-Reply-To
<20220817153110.380790-1-alebastr89@gmail.com> (view parent)
DKIM signature
missing
Download raw message
greetd/patches: SUCCESS in 3m5s

[fakegreet: reset state on errors][0] from [Aleksei Bavshin][1]

[0]: https://lists.sr.ht/~kennylevinsen/greetd-devel/patches/34740
[1]: alebastr89@gmail.com

✓ #825464 SUCCESS greetd/patches/archlinux.yml https://builds.sr.ht/~kennylevinsen/job/825464
✓ #825463 SUCCESS greetd/patches/alpine.yml    https://builds.sr.ht/~kennylevinsen/job/825463
Details
Message ID
<KQ55IR.3V08SMBCTSXZ@kl.wtf>
In-Reply-To
<20220817153110.380790-1-alebastr89@gmail.com> (view parent)
DKIM signature
missing
Download raw message
Applied, thanks!

(Apologies for the delay.)
Reply to thread Export thread (mbox)