greetd-docs: Quote array expansion v1 APPLIED

Sertonix: 1
 Quote array expansion

 1 files changed, 3 insertions(+), 3 deletions(-)

[PATCH greetd-docs] Quote array expansion Export this patch

See https://www.shellcheck.net/wiki/SC2068
---
 I forgot to add the patch in the last mail.

Kenny Levinsen <kl@kl.wtf>

6 months ago

The blank mail was confusing indeed. :)

Next

 index.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/index.md b/index.md
index 931ea52..d27207f 100644
--- a/index.md
+++ b/index.md
@@ -164,13 +164,13 @@ export QT_QPA_PLATFORM=wayland
 export SDL_VIDEODRIVER=wayland
 export _JAVA_AWT_WM_NONREPARENTING=1
 
-exec sway $@
+exec sway "$@"

Kenny Levinsen <kl@kl.wtf>

6 months ago

The original form is intentional and not a bug.

For a wrapper script like this, you want `sway-run -c config -d` to 
ultimately call `sway -c config -d` - each original argument passed 
individually. With quotes, it becomes `sway "-c config -d"`, which is a 
single argument that sway would not understand.

SC2068 is for when the behavior is accidental, passing multiple 
arguments when only one was intended.

 
 #
 # If you use systemd and want sway output to go to the journal, use this
-# instead of the `exec sway $@` above:
+# instead of the `exec sway "$@"` above:
 #
-#    exec systemd-cat --identifier=sway sway $@
+#    exec systemd-cat --identifier=sway sway "$@"
 #
 ```
 
-- 
2.44.0

Kenny Levinsen <kl@kl.wtf>

6 months ago

Apologies for my confusion, applied. Thanks!