~kennylevinsen/seatd-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] link with rt

Simeon Schaub
Details
Message ID
<20210620140118.894445-1-simeondavidschaub99@gmail.com>
DKIM signature
pass
Download raw message
Patch: +2 -1
Since seatd uses `clock_gettime`, this is needed when cross-compiling.
This came up in https://github.com/JuliaPackaging/Yggdrasil/pull/3193.
---
 meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 6299f4e..9f9de0b 100644
--- a/meson.build
+++ b/meson.build
@@ -164,7 +164,7 @@ lib = library(
	link_with: private_lib,
	include_directories: [include_directories('.', 'include')],
	install: true,
	link_args: symbols_flag,
	link_args: ['-lrt', symbols_flag],
	link_depends: symbols_file,
)

@@ -198,6 +198,7 @@ if with_server
		[ server_files, 'seatd/seatd.c' ],
		include_directories: [include_directories('.', 'include')],
		install: true,
		link_args: ['-lrt'],
	)
endif

-- 
2.32.0
Details
Message ID
<SW90VQ.67F7MWURZND3@kl.wtf>
In-Reply-To
<20210620140118.894445-1-simeondavidschaub99@gmail.com> (view parent)
DKIM signature
pass
Download raw message
Thank you for you patch!

On Sun, Jun 20 2021 at 04:01:18 PM +0200, Simeon Schaub 
<simeondavidschaub99@gmail.com> wrote:
> 
> +	link_args: ['-lrt', symbols_flag],

We should tell meson about the dependency instead of bypassing it with 
link_args.

Should you need inspiration, then see mako's meson.build which contains 
exactly this dependency: 
https://github.com/emersion/mako/blob/445bf2d28d162007507580c40c9265978736f148/meson.build#L28
Reply to thread Export thread (mbox)