seatd: don't log errno on EVENT_ERROR v1 APPLIED

Simon Ser: 1
 seatd: don't log errno on EVENT_ERROR

 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH] seatd: don't log errno on EVENT_ERROR Export this patch

errno won't be set when poll returns EVENT_ERROR.
---
 seatd/server.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/seatd/server.c b/seatd/server.c
index 03840fdd1343..5d7b84d20dc0 100644
--- a/seatd/server.c
+++ b/seatd/server.c
@@ -152,7 +152,7 @@ int server_handle_connection(int fd, uint32_t mask, void *data) {
 	if (mask & (EVENT_ERROR | EVENT_HANGUP)) {
 		shutdown(fd, SHUT_RDWR);
 		server->running = false;
-		log_errorf("Server socket received an error: %s", strerror(errno));
+		log_errorf("Server socket received an error");

Kenny Levinsen <kl@kl.wtf>

8 months ago

Well:

```
../seatd/server.c: In function �server_handle_connection�:
../seatd/server.c:149:61: error: ISO C99 requires at least one argument 
for the "..." in a variadic macro [-Werror]
  149 | log_errorf("Server socket received an error");
      | ^
In file included from ../seatd/server.c:15:
../include/log.h:26:91: error: expected expression before �)� token
   26 | _logf(LIBSEAT_LOG_LEVEL_ERROR, "[%s:%d] " fmt, __FILENAME__, 
__LINE__, __VA_ARGS__)
      | ^
../seatd/server.c:149:17: note: in expansion of macro �log_errorf�
  149 | log_errorf("Server socket received an error");
      |
```

I'll just amend with s/log_errorf/log_error/ locally before pushing 
though.

 		return -1;
 	}
 
-- 
2.33.1

Kenny Levinsen <kl@kl.wtf>

8 months ago

Applied (after adjustment), thanks!