From Trey Peacock to ~pkal/public-inbox
"Philip Kaludercic" <philipk@posteo.net> writes: > Hi, > > Trey Peacock <git@treypeacock.com> writes: > >> I currently use a modified versions of the keybinding macros that use >> `keymap-set` and other functions found in `keymap.el`. This resulted in >> an error thrown when trying to use the new `kbd` ensure keyword. "C-=" >> can be set with `keymap-set`, but it will result an error in >> `setup--ensure` with `(kbd "C-=")`. >> >> So, I figured it may be useful to allow for custom ENSURE-SPECs. The >> implementation below uses `cl-defgeneric` to allow for custom methods;
From Trey Peacock to ~pkal/public-inbox
"Philip Kaludercic" <philipk@posteo.net> writes:
> I get the impression that cl-defmacro is too great of an overhead here
> -- especially when we consider loading the necessary files during
> initialisation. `Setup' is relatively fast, and if there is a more
> efficient/lightweight way then I think it would be preferable.
> Dispatching ensure-specs could also be done using an alist mapping
> symbols to functions.
That makes sense. There should be a new patch attached below. I'm not
extremely familiar with the email patch workflow, so I hope that is okay
> That being said, I wonder if this is really so
> much potential for extending `setup--ensure' or if simply extending it
[message trimmed]
From Trey Peacock to ~pkal/public-inbox
I currently use a modified versions of the keybinding macros that use
`keymap-set` and other functions found in `keymap.el`. This resulted in
an error thrown when trying to use the new `kbd` ensure keyword. "C-="
can be set with `keymap-set`, but it will result an error in
`setup--ensure` with `(kbd "C-=")`.
So, I figured it may be useful to allow for custom ENSURE-SPECs. The
implementation below uses `cl-defgeneric` to allow for custom methods;
however, if you do not want to rely on the `cl-lib` library, I have a
patch that uses an alist variable instead. This seemed a bit cleaner to
me.
For example, this is the spec that I use for by custom `:bind` macros:
[message trimmed]
From Trey to ~l3kn/org-fc-devel
This may be useful for those who use evil and still wish to see their mapped keys echoed in the minibuffer. --- org-fc-keymap-hint.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/org-fc-keymap-hint.el b/org-fc-keymap-hint.el index c910b22..93c32f9 100644 --- a/org-fc-keymap-hint.el +++ b/org-fc-keymap-hint.el @@ -30,6 +30,9 @@ (require 'org-fc) (require 'edmacro) [message trimmed]
From Trey Peacock to ~l3kn/org-fc-devel
--- org-fc-dashboard.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org-fc-dashboard.el b/org-fc-dashboard.el index e9d593c..b898d0c 100644 --- a/org-fc-dashboard.el +++ b/org-fc-dashboard.el @@ -265,7 +265,7 @@ environment without svg support." (defun org-fc-dashboard (context) "Open a buffer showing the dashboard view for CONTEXT." (interactive (list (org-fc-select-context))) (setq org-fc-context-dashboard context) (setq org-fc-dashboard-context context)[message trimmed]