Hi Jason

On Fri Aug 23, 2024 at 8:06 PM CEST, Jason Cox wrote:
> Hi Koni,
>
> On Fri Aug 23, 2024 at 5:14 AM EDT, Koni Marti wrote:
> > Add a -n flag to :search to select the immediate next search result from
> > the current position in the messsage list. If not set, the (current)
> > default behavior for :search is to jump to the very first search result.
>
> In my opinion, it makes more sense to have this -n behavior be the
> default and add a separate flag for the current default behavior. If
> we're opposed to changing the default then I definitely think this flag
> is a good addition.

Fix the content encoding for GPG-signed messages.

To remove the Mime-Version header field for the signed message part, the
raw message is parsed with go-message. go-message.Read(), however,
decodes the message body as well (i.e. from quoted-printable to UTF8
depending on the Content-Transfer-Encoding header). This means that the
msg.Body field now contains the decoded message (it is no longer encoded
as quoted-printable). We never encode the message back to the proper
Content-Transfer-Encoding.

To fix this, use net/mail.ReadMessage() to parse the headers and to not
decode the message body.

To verify the issue, send a signed message with the following text:
[message trimmed]

Add an auto-switch option that changes the project of the patch manager
based on the subject line of a message if it contains a '[PATCH
<project>]' segment.

A subject line with '[PATCH aerc v2]' would switch to the 'aerc' project
if that project is available in the patch manager.

The auto switching can be activated per account by adding
'pama-auto-switch = true' to your account config.

Implements: https://todo.sr.ht/~rjarry/aerc/226
Changelog-added: Auto-switch projects based on the message subject
 for the :patch command.
Signed-off-by: Koni Marti <koni.marti@gmail.com>
[message trimmed]

Add a -n flag to :search to select the immediate next search result from
the current position in the messsage list. If not set, the (current)
default behavior for :search is to jump to the very first search result.

The following example will select the immediate next unread message:

	:search -nu

Fixes: https://todo.sr.ht/~rjarry/aerc/168
Signed-off-by: Koni Marti <koni.marti@gmail.com>
---
 commands/account/search.go |  3 +-
 doc/aerc-search.1.scd      |  3 ++
 lib/msgstore.go            | 84 +++++++++++++++++---------------------
[message trimmed]

Fix a runtime error in the SeqMap.Pop function causing a
index-out-of-range panic:

Version: 0.18.2.r22.gfff69046 (go1.22.6 amd64 linux 2024-08-10)
Error: runtime error: index out of range [487] with length 487

goroutine 24430 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:24 +0x5e
git.sr.ht/~rjarry/aerc/lib/log.PanicHandler()
	git.sr.ht/~rjarry/aerc/lib/log/panic-logger.go:49 +0x66a
panic({0x5dbf5a688020?, 0xc002ab0d80?})
	runtime/panic.go:770 +0x132
git.sr.ht/~rjarry/aerc/worker/imap.(*SeqMap).Pop(0xc0003d4940, 0x1e8)
[message trimmed]

On Fri Aug 23, 2024 at 4:35 AM CEST, Jason Cox wrote:
> Currently, the :reload command silently does nothing if no flags are
> provided. Eliminate this confusion by reloading all reloadable configs
> in the absence of flags.
>
> Signed-off-by: Jason Cox <me@jasoncarloscox.com>
> ---
>  commands/reload.go | 6 ++++++
>  doc/aerc.1.scd     | 3 +++
>  2 files changed, 9 insertions(+)

Thanks! Makes sense and looks good.

Reviewed-by: Koni Marti <koni.marti@gmail.com>

On Tue Aug 13, 2024 at 11:13 PM CEST, Bence Ferdinandy wrote:
> The default of {{.AccountFrom}} is currently nil. During startup, if
> index-columns has something like {{.AccountFrom.Address}} then startup
> will fail due to nil pointer evaluation. Instead of returning a pointer
> set to nil for a default value, return a mail.Address struct and use an
> empty struct as a default.
>
> Fixes: 1d4eafb011f4 ("templates: add {{.AccountFrom}} template")
> Cc: skejg <grolleman@zoho.com>
> Signed-off-by: Bence Ferdinandy <bence@ferdinandy.com>
> ---

Thanks, Bence! LGTM.

Hi Bence

I can confirm that this fixes the issue. Two minor comments below.

On Tue Aug 13, 2024 at 10:13 PM CEST, Bence Ferdinandy wrote:
> The default of {{.AccountFrom}} is currently nil. During startup, if
> index-columns has something like {{.AccountFrom.Address}} then startup
> will fail due to nil pointer evaluation. Instead of returning a pointer
> set to nil for a default value, return a mail.Address struct and use an
> empty struct as a default.
>
> Fixes: 1d4eafb

The Fixes trailer should be the commit id and its title:

On Thu Aug 8, 2024 at 5:55 PM CEST, Willow Barraco wrote:
> But to close this thread: This patch works and fix the pinentry problem
> with outgoing-cred-cmd :)

Thanks for digging into this! Great to hear it works. Let's investigate
how we could detect this double-encoding. Thanks again!

-- 
Koni

On Thu Aug 8, 2024 at 11:52 AM CEST, Willow Barraco wrote:
> On Thu Aug 8, 2024 at 11:41 AM CEST, Koni Marti wrote:
> > On Thu Aug 8, 2024 at 11:25 AM CEST, Willow Barraco wrote:
> > > Same thing here. Both aren't the same?
> >
> > Cool, glad it works! You could also keep $TTY in the script and just start
>
> No sorry, still failing. Same thing

Ah, sorry I misunderstood. I wonder why it works on my side. Maybe the
logs can help: Can you grep them for any 'pinentry' entries?

There should also be be a 'send config uri:' line in the logs where the
password is (currently) shown as plaintext. Does that match what you've