On Tue Dec 31, 2024 at 4:49 AM CET, Avid Seeker wrote:
> It'd be awesome to have expand-collapse feature for threads. Some
> long discussions get too-nested to navigate.

There are the :fold and :unfold commands that might be what you want:

https://git.sr.ht/~rjarry/aerc/tree/master/item/doc/aerc.1.scd#L743-750

Ignore and log a charset error when fetching a message part.

Reported-by: Matěj Cepl <mcepl@cepl.eu>
Signed-off-by: Koni Marti <koni.marti@gmail.com>
---
 worker/jmap/fetch.go | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/worker/jmap/fetch.go b/worker/jmap/fetch.go
index 3b3a8460..de32ee99 100644
--- a/worker/jmap/fetch.go
+++ b/worker/jmap/fetch.go
@@ -134,9 +134,10 @@ func (w *JMAPWorker) handleFetchMessageBodyPart(msg *types.FetchMessageBodyPart)
 	if strings.HasPrefix(part.Type, "text/") && part.Charset != "" {
[message trimmed]

Hi Robin 

thanks for your input. I understand that this is a bit of a
"workaround", but it shows a "possible" approach to deal with malformed
multipart messages. We can also let that patch sit around a bit and try
to come up with a better solution.

A proper fix would probably be to write our own multipart parser, try to
detect errors (missing or wrong boundaries) and correct them?

Anyways, I've tried to answer your remarks below.

On Sat Nov 9, 2024 at 7:02 PM CET, Robin Jarry wrote:
> Koni Marti, Nov 08, 2024 at 17:07:

Hi Markus

thanks for the fast v2 and the fix. :compose -f works now correctly.

On Fri Nov 8, 2024 at 6:39 PM CET, Markus Unkel wrote:
> diff --git a/commands/msg/recall.go b/commands/msg/recall.go
> index 53a0de34..99e5b832 100644
> --- a/commands/msg/recall.go
> +++ b/commands/msg/recall.go
> @@ -20,9 +20,10 @@ import (
>  )
>  
>  type Recall struct {
> -	Force  bool `opt:"-f" desc:"Force recall if not in postpone directory."`

Parse multipart messages on a best-efforts basis. Allow the user to see
as much of the message as possible, but log the errors.

If a charset or encoding error is encountered for a message part of a
multipart message, the error is logged and ignored. In those cases, we
still get a valid message body but the content is just not decoded or
converted. No error will be propagated.

If a multipart message cannot be parsed, ParseEntityStructure will
return a multipart error. This error indicates that the message is
malformed and there is nothing more we can do. The caller is then
advised to use a single text/plain body structure using
CreateTextPlainPart() to provide the entire message content to the user.
[message trimmed]

Hi Markus

thanks for your patch. I've made a few remarks below.

On Tue Nov 5, 2024 at 4:36 PM CET, Markus Unkel wrote:
> diff --git a/commands/account/compose.go b/commands/account/compose.go
> index 5e5d3e0f..08bf9475 100644
> --- a/commands/account/compose.go
> +++ b/commands/account/compose.go
> @@ -16,11 +16,12 @@ import (
>  )
>  
>  type Compose struct {
> -	Headers  string `opt:"-H" action:"ParseHeader" desc:"Add the specified header to the message."`

Fix the commands.GetTemplates() and types.StrategyStrs() completion
functions to avoid showing empty entries.

Reported-by: pam79
Reported-by: inwit <inwit@sindominio.net>
Signed-off-by: Koni Marti <koni.marti@gmail.com>
---
 commands/commands.go | 2 +-
 worker/types/mfs.go  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/commands/commands.go b/commands/commands.go
index a06e8ef9..19bb5d66 100644
--- a/commands/commands.go
[message trimmed]

Parse multipart messages on a best-efforts basis. Allow the user to see
as much of the message as possible, but log the errors.

If a charset or encoding error is encountered for a message part of a
multipart message, the error is logged and ignored. In those cases, we
still get a valid message body but the content is just not decoded or
converted. No error will be propagated.

If a multipart message cannot be parsed, ParseEntityStructure will
return a multipart error. This error indicates that the message is
malformed and there is nothing more we can do. The caller is then
advised to use a single text/plain body structure using
CreateTextPlainPart() to provide the entire message content to the user.
[message trimmed]

Fix GetTemplates completion function to prevent showing empty entries.

Reported-by: pam79
Signed-off-by: Koni Marti <koni.marti@gmail.com>
---
 commands/commands.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/commands.go b/commands/commands.go
index a06e8ef9..19bb5d66 100644
--- a/commands/commands.go
+++ b/commands/commands.go
@@ -308,7 +308,7 @@ func GetTemplates(arg string) []string {
 			}
[message trimmed]

On Thu Nov 7, 2024 at 5:46 PM CET, Tianhao Wang wrote:
> nit: IMO [aerc: multipart parsing error] in the title is too verbose and
> I can hardly read the subject in the message list when the window is not
> wide enough.

I'm open for a better prefix, if one at all.
Maybe "aerc: malformed message" or something even shorter.

> Tested-by: Tianhao Wang <shrik3@mailbox.org>

Thanks for testing!