~konimarti

Recent activity

[PATCH aerc] forward,recall: fix charsets in part attachment a day ago

From Koni Marti to ~rjarry/aerc-devel

Fix charset to UTF-8 in part attachments. The forward and recall
commands fetch message parts with the go-message package which decodes
to UTF-8. Hence, we should set the charset of the part attachment to
utf-8 and not just copying over the one from the original message.

Reported-by: Bence Ferdinandy <bence@ferdinandy.com>
Signed-off-by: Koni Marti <koni.marti@gmail.com>
---
 commands/msg/forward.go |  5 +++--
 commands/msg/recall.go  |  5 +++--
 lib/attachment.go       | 17 +++++++++++++++++
 3 files changed, 23 insertions(+), 4 deletions(-)

diff --git a/commands/msg/forward.go b/commands/msg/forward.go
[message trimmed]

Re: [PATCH aerc] imap: fix flags update 2 days ago

From Koni Marti to ~rjarry/aerc-devel

On Tue Oct 4, 2022 at 10:12 AM CEST, Jens Grassel wrote:
> Hi,
>
> On Tue Oct 4, 2022 at 10:08 AM CEST, Koni Marti wrote:
> > Fixes updating the flags in the imap backend. Before, the silent flag
> > was set incorrectly by 75fc42e ("imap: send message info updates for
> > bulk flag ops") which caused some imap servers to not send the updated
> > flags. By disabling the silent flag, the flag update will return a
> > corrsponding value that we can send back to the message store to update
> > the flags correctly.
> >
> > Fixes: 75fc42e ("imap: send message info updates for bulk flag ops")
> > Reported-by: Jens Grassel <jens@wegtam.com>
> > Signed-off-by: Koni Marti <koni.marti@gmail.com>

[PATCH aerc] imap: fix flags update 2 days ago

From Koni Marti to ~rjarry/aerc-devel

Fixes updating the flags in the imap backend. Before, the silent flag
was set incorrectly by 75fc42e ("imap: send message info updates for
bulk flag ops") which caused some imap servers to not send the updated
flags. By disabling the silent flag, the flag update will return a
corrsponding value that we can send back to the message store to update
the flags correctly.

Fixes: 75fc42e ("imap: send message info updates for bulk flag ops")
Reported-by: Jens Grassel <jens@wegtam.com>
Signed-off-by: Koni Marti <koni.marti@gmail.com>
---
 worker/imap/flags.go | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
[message trimmed]

Re: Setting imap flags broken? 2 days ago

From Koni Marti to ~rjarry/aerc-devel

On Tue Oct 4, 2022 at 8:56 AM CEST, Jens Grassel wrote:
> Hi,
>
> I just wanted to toggle some flags on my imap account (read, unread) and
> it doesn't seem to work any longer. Viewing an email still marks it read
> but using the flag commands seems to not have an effect anymore.
>
> Anyone else having these issues?

Hi Jens,

Thanks for the report. I think this could be related to this patch:
75fc42e ("imap: send message info updates for bulk flag ops").

Re: [PATCH aerc v6 0/5] One loop to rule them all 3 days ago

From Koni Marti to ~rjarry/aerc-devel

On Mon Oct 3, 2022 at 5:16 PM CEST, Tim Culverhouse wrote:
> Hey all -
>
> Taking RFC off this one. I've been using it since I've been working on it and
> have not had a panic since, so I am considering it ready.
>
> This series takes care of (nearly) all remaining data races. There is one
> straggler I still know about (:archive), but I will put in a separate patch for
> that. I haven't come across any others in my testing, but we should be at a
> point that we have very few race conditions after this series.
>
> Since v5, I've added the QueueRedraw function, which does exactly what it says:
> queue's a redraw in the main loop when called. This is needed for TextInput,
> Spinner,  and Terminal, all of which need to request a draw independant of a

[PATCH aerc v2 2/2] view: add peek flag and propagate 3 days ago

From Koni Marti to ~rjarry/aerc-devel

Add a peek flag -p to the view commands to open the message viewer
without setting the "seen" flag. If the flag is set, it would ignore the
"auto-mark-read" config.

The SetSeen flag will be propagated in case the message viewer moves on
to other messages, i.e. with the delete or archive commands.

Signed-off-by: Koni Marti <koni.marti@gmail.com>
---
v1->v2:

 * the seen flag is set by the message viewer by default; with a
   flag to the view command, the user could peek a message without
   having to change the auto-mark-read config variable.
[message trimmed]

[PATCH aerc v2 1/2] viewer: option to not mark message as seen 3 days ago

From Koni Marti to ~rjarry/aerc-devel

Add option to open a message in the message viewer without setting the
seen flag. Enables the message viewer to be used as a preview pane
without changing the message flags unintentionally. Before, the message
viewer would set the seen flag by default. The IMAP backend will now
always fetch the message body with the peek option enabled (same as we
fetch the headers).

An "auto-mark-read" option is added to the ui config which is set to
true by default. If set the false, the seen flag is not set by the
message viewer.

Co-authored-by: "James Cook" <falsifian@falsifian.org>
Signed-off-by: Koni Marti <koni.marti@gmail.com>
---
[message trimmed]

Re: [PATCH aerc 3/3] mbox,maildir,notmuch: set seen flag in the backend 3 days ago

From Koni Marti to ~rjarry/aerc-devel

On Mon Oct 3, 2022 at 4:11 PM CEST, Tim Culverhouse wrote:
> On Mon Oct 3, 2022 at 8:45 AM CDT, kt programs wrote:
> > Wouldn't it be better to have the timer in the preview?
>
> Yep...good idea!

Everyone,

I implemented the proposed changes and noticed that my v2 looks almost
*exactly* as James' original patch. I feel bad submitting the patch of
someone else just with a minor modification.

So, I'm not going to send a v2 but I encourage James to resubmit his
original patch according to the contribution guidelines and with a minor

Re: [PATCH aerc 3/3] mbox,maildir,notmuch: set seen flag in the backend 3 days ago

From Koni Marti to ~rjarry/aerc-devel

On Mon Oct 3, 2022 at 4:11 PM CEST, Tim Culverhouse wrote:
> On Mon Oct 3, 2022 at 8:45 AM CDT, kt programs wrote:
> > Wouldn't it be better to have the timer in the preview?
>
> Yep...good idea!

Sounds good to me, too.

Re: [PATCH aerc 3/3] mbox,maildir,notmuch: set seen flag in the backend 3 days ago

From Koni Marti to ~rjarry/aerc-devel

On Sun Oct 2, 2022 at 7:44 PM CEST, Robin Jarry wrote:
> Koni Marti, Oct 02, 2022 at 01:44:
> > Set the "seen" flag in the backends instead of the message viewer. When
> > handling a FetchFullMessage or FetchMessageBodyPart with the SetSeen
> > field set to true, the backend worker will set the "seen" flag
> > accordingly. This harmonizes the fetching behavior among the mentioned
> > backends with the imap one.
> >
> > Signed-off-by: Koni Marti <koni.marti@gmail.com>
>
> I would prefer doing it the other way around to be honest: Change the
> IMAP worker to always use PEEK and explicitly set the \Seen flag after
> a configurable timeout. That way it is easier to disable for all workers
> with a single option at a single place without modification of the