On Thu May 12, 2022 at 12:49 PM CEST, inwit wrote:
> I've found out that these settings suggested by Koni make aerc much more
> responsive and I'm not observing #28 since I applied them:
>
> connection-timeout = 5s
> keepalive-period = 5s
> keepalive-probes = 1
> keepalive-interval = 1s
>
> I can't really tell what exactly do they imply, but so far they, erm, just work
> (tm). I'll test longer, just in case. However, if I don't apply them, upon
> waking up after a period I'm getting a previously unseen error: "(account-name):
> idle mode hangs; waiting to reconnect".
>

On Mon May 9, 2022 at 5:44 PM CEST, inwit wrote:
> Unfortunately, I must report that #28 is still here. It took much longer to
> appear, since for several days after this commit I couldn't reproduce it. Today
> it's back, and I still don't know what causes it. I'll keep an eye for any
> clues.

That's a bummer. Please do keep an eye out and please send a log snippet
of the error when it happens again.

Fix panic when resizing the terminal by dynamically adjusting the width
of the option selector. The selector does not check the width of the
terminal before printing. This can lead to a panic in the account wizard
when reducing the terminal width.

If the terminal width is not large enough, the space between the options
is reduced. If this is still not enough, then the selector will only
show the focused option and arrows indicating the alternatives.

Fixes: https://lists.sr.ht/~rjarry/aerc-devel/%3C3C0445YFB4K4X.33HV0Q07DOX4R%40venera%3E
Signed-off-by: Koni Marti <koni.marti@gmail.com>
---
 widgets/selector.go | 68 +++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 63 insertions(+), 5 deletions(-)
[message trimmed]

On Thu May 5, 2022 at 7:53 PM CEST, Tim Culverhouse wrote:
> Add compose command ("attach-key") to attach the public key associated
> with the sending account. Public key is attached in ascii armor format,
> with the mimetype set according to RFC 3156 ("application/pgp-keys").
>
> Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
> ---
> v2: fix: show key attachment when attached at reviewMessage view

Tested-by: Koni Marti <koni.marti@gmail.com>

>
>  commands/compose/attach-key.go | 32 ++++++++++++++
>  doc/aerc.1.scd                 |  3 ++

On Thu May 5, 2022 at 4:04 PM CEST, Tim Culverhouse wrote:
> On Thu May 5, 2022 at 8:53 AM CDT, Koni Marti wrote:
> > Is there a reason why you didn't call it 'pgp-auto-encrypt' (in line
> > with the 'pgp-auto-sign')? 
>
> Only because it's a generally known phrase (see [1],[2],[3]). I'm
> open to changing it - it's not an easy-to-spell word, which makes it
> prone to mistakes.

Perfect, thanks for the links. I also had the ease-of-use in mind, but
if this is a known phrase, this is fine. Thanks!

>
> [1]: https://en.wikipedia.org/wiki/Opportunistic_encryption

On Wed May 4, 2022 at 5:29 PM CEST, Tim Culverhouse wrote:
> Add compose command ("attach-key") to attach the public key associated
> with the sending account. Public key is attached in ascii armor format,
> with the mimetype set according to RFC 3156 ("application/pgp-keys").
>
> Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
> ---

This is also very nice. Only thing I noticed was that when I run the
attach-key command it does not show the key attachement right away. But
when I add another attachement it will show the key and the other file.
Did you notice this too?

With this, we could now simply import keys by defining a filter for this

On Wed May 4, 2022 at 5:29 PM CEST, Tim Culverhouse wrote:
> Add account level config options for auto-sign and opportunistic
> encryption.
>
> Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
> ---

This works great and is a neat feature. 

>  config/config.go      | 44 ++++++++++++++++++++++++-------------------
>  doc/aerc-config.5.scd | 13 +++++++++++++
>  widgets/compose.go    |  7 +++++++
>  3 files changed, 45 insertions(+), 19 deletions(-)
>

Unmark deleted messages and remove pending headers in the callback
function when an error in the backend occurs (e.g. due to connection
issues).

The message store marks messages that should be deleted. If the delete
operation in the backend fails, messages are never unmarked and will
remain rendered as empty lines in the message list. This also affects
the move and archive commands that rely on a copy and delete operation.

A similar issue occurs with the pending headers when the operation to
fetch them fails. In this case, messages will appear as loading
indefinitely in the message list and are never re-fetched because the
corresponding pending headers from the failed operations are still
present.
[message trimmed]

Extract the tcp connection details and timeout the tcp connect functions
(net.ResolveTCPAddr and net.DialTCP). If timed out, ensure that the
connection is properly closed.

Signed-off-by: Koni Marti <koni.marti@gmail.com>
---
 worker/imap/connect.go | 178 +++++++++++++++++++++++++++++++++++++++++
 worker/imap/worker.go  | 130 +++---------------------------
 2 files changed, 188 insertions(+), 120 deletions(-)
 create mode 100644 worker/imap/connect.go

diff --git a/worker/imap/connect.go b/worker/imap/connect.go
new file mode 100644
index 0000000..9cc394b
[message trimmed]

Add a debouncer to the idle mode. Avoid unnecessary idling when another
job arrives within a certain time frame.

For example, the ui sends three messages to the worker at the same time
when we open a message (FlagMessage, FetchMessageBodyPart, and the
FetchMessageHeaders). The debouncer prevents the unnecessary entering
and leaving of the idle mode between those messages.

Signed-off-by: Koni Marti <koni.marti@gmail.com>
---
 worker/imap/configure.go | 11 +++++++++++
 worker/imap/idler.go     | 34 +++++++++++++++++++++++-----------
 worker/imap/worker.go    |  1 +
 3 files changed, 35 insertions(+), 11 deletions(-)
[message trimmed]