From Gabriel Krisman Bertazi to ~lkcamp/patches
David Gow <davidgow@google.com> writes: > From: Gabriela Bittencourt <gbittencourt@lkcamp.dev> > > Change utf8 kunit test filename and path to follow the style > convention on Documentation/dev-tools/kunit/style.rst > > Co-developed-by: Pedro Orlando <porlando@lkcamp.dev> > Signed-off-by: Pedro Orlando <porlando@lkcamp.dev> > Co-developed-by: Danilo Pereira <dpereira@lkcamp.dev> > Signed-off-by: Danilo Pereira <dpereira@lkcamp.dev> > Signed-off-by: Gabriela Bittencourt <gbittencourt@lkcamp.dev> > Reviewed-by: David Gow <davidgow@google.com> > [Rebased, fixed module build (Gabriel Krisman Bertazi)]
From Gabriel Krisman Bertazi to ~lkcamp/patches
David Gow <davidgow@google.com> writes: > From: Gabriela Bittencourt <gbittencourt@lkcamp.dev> > > Refactoring 'test' functions into kunit tests, to test utf-8 support in > unicode subsystem. > > This allows the utf8 tests to be run alongside the KUnit test suite > using kunit-tool, quickly compiling and running all desired tests as > part of the KUnit test suite, instead of compiling the selftest module > and loading it. > > The refactoring kept the original testing logic intact, while adopting a > testing pattern across different kernel modules and leveraging KUnit's
From Gabriel Krisman Bertazi to ~lkcamp/patches
Pedro Orlando <porlando@lkcamp.dev> writes: > From: Gabriela Bittencourt <gbittencourt@lkcamp.dev> > > Refactoring 'test' functions into kunit tests, to test utf-8 support in > unicode subsystem. > > This allows the utf8 tests to be run alongside the KUnit test suite > using kunit-tool, quickly compiling and running all desired tests as > part of the KUnit test suite, instead of compiling the selftest module > and loading it. > > The refactoring kept the original testing logic intact, while adopting a > testing pattern across different kernel modules and leveraging KUnit's
From Gabriel Krisman Bertazi to ~lkcamp/patches
Pedro Orlando <porlando@lkcamp.dev> writes: > From: Gabriela Bittencourt <gbittencourt@lkcamp.dev> > > Change utf8 kunit test filename and path to follow the style > convention on Documentation/dev-tools/kunit/style.rst > > Co-developed-by: Pedro Orlando <porlando@lkcamp.dev> > Signed-off-by: Pedro Orlando <porlando@lkcamp.dev> > Co-developed-by: Danilo Pereira <dpereira@lkcamp.dev> > Signed-off-by: Danilo Pereira <dpereira@lkcamp.dev> > Signed-off-by: Gabriela Bittencourt <gbittencourt@lkcamp.dev> > --- > fs/unicode/Makefile | 2 +-
From Gabriel Krisman Bertazi to ~lkcamp/patches
André Almeida <andrealmeid@riseup.net> writes: > Hey! > > On 9/23/24 19:34, Gabriela Bittencourt wrote: >> Instead of creating 'test' functions, use kunit functions to test >> utf-8 support in unicode subsystem. > > I think it would be nice to explain in the commit message what are the > benefits of this change, why refactoring into KUnit is a good idea? TBH, I wouldn't mind dropping this code altogether. We have similar coverage in fstests already. It was useful when developing fs/unicode but nowadays, it seems moot.