~krystianch

Warsaw, Poland

https://krystianch.com/

~krystianch/public-inbox

Last active 1 year, 2 months ago
View more

Recent activity

[PATCH kimchi v2] Fix stripping trailing slash when forwarding 6 months ago

From Krystian Chachuła to ~emersion/public-inbox

path.Join strips trailing slashes. This leads to redirection loops when
the backend enforces trailing slashes by redirecting. This commit adds
the trailing slashes back.

---
Thanks for the review of v1. I looked up how URL.JoinPath deals with
trailing slashes. It adds them back like this.

 directives.go | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/directives.go b/directives.go
index 94258d3..5ec62a2 100644
--- a/directives.go
[message trimmed]

[PATCH kimchi] Fix stripping trailing slash when forwarding 6 months ago

From Krystian Chachuła to ~emersion/public-inbox

path.Join strips trailing slashes. This leads to redirection loops when
the backend enforces trailing slashes by redirecting. This commit
replaces path.Join with URL.JoinPath, which doesn't strip trailing
slashes.

---
The additional req.URL.Path != "" condition is for cases where target
URL ends with a slash and request path is / (""). Then, the final
request path will end with a slash.

 directives.go | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/directives.go b/directives.go
[message trimmed]

[PATCH] Add handling of SIGINT and SIGTERM 7 months ago

From Krystian Chachuła to ~sircmpwn/tokidoki-devel

Handle exit signals so that deferred calls are executed. It's mainly
to unlink the socket before exiting.
---
 cmd/tokidoki/main.go | 28 +++++++++++++++++++++-------
 1 file changed, 21 insertions(+), 7 deletions(-)

diff --git a/cmd/tokidoki/main.go b/cmd/tokidoki/main.go
index 06b817c..9d706fd 100644
--- a/cmd/tokidoki/main.go
+++ b/cmd/tokidoki/main.go
@@ -8,7 +8,9 @@ import (
	"net"
	"net/http"
	"os"
[message trimmed]

[PATCH] Add Unix socket support 7 months ago

From Krystian Chachuła to ~sircmpwn/tokidoki-devel

---
 cmd/tokidoki/main.go | 22 ++++++++++++++++++++--
 doc/tokidoki.8.scd   |  2 +-
 2 files changed, 21 insertions(+), 3 deletions(-)

diff --git a/cmd/tokidoki/main.go b/cmd/tokidoki/main.go
index 3b982f7..06b817c 100644
--- a/cmd/tokidoki/main.go
+++ b/cmd/tokidoki/main.go
@@ -5,8 +5,10 @@ import (
	"encoding/base64"
	"flag"
	"fmt"
	"net"
[message trimmed]

[PATCH] Set IRC, WS and HTTP Unix sockets' mode to 775 7 months ago

From Krystian Chachuła to ~emersion/soju-dev

It was 755 before, so a reverse proxy running as a different user didn't
have permission to connect.
---
 cmd/soju/main.go | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/cmd/soju/main.go b/cmd/soju/main.go
index 8958cec..1718f9e 100644
--- a/cmd/soju/main.go
+++ b/cmd/soju/main.go
@@ -223,6 +223,9 @@ func main() {
				log.Fatalf("failed to start listener on %q: %v", listen, err)
			}
			ln = proxyProtoListener(ln, srv)
[message trimmed]

[PATCH todo.sr.ht] Disable 'Assign myself' button if already assigned 1 year, 2 months ago

From Krystian Chachuła to ~sircmpwn/sr.ht-dev

Closes: https://todo.sr.ht/~sircmpwn/todo.sr.ht/275
---
 todosrht/templates/ticket.html | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/todosrht/templates/ticket.html b/todosrht/templates/ticket.html
index 3a138e6..7ff34d5 100644
--- a/todosrht/templates/ticket.html
+++ b/todosrht/templates/ticket.html
@@ -182,6 +182,10 @@
                <button
                  name="myself"
                  class="btn btn-default"
                  {% if current_user in ticket.assigned_users %}
[message trimmed]

[PATCH todo.sr.ht] Fix error when assigning already assigned user 1 year, 2 months ago

From Krystian Chachuła to ~sircmpwn/sr.ht-dev

Assigning user that is already assigned causes unhandled GraphQLError.
This commit adds validation that the user is not assigned.

References: https://todo.sr.ht/~sircmpwn/todo.sr.ht/275
---
 todosrht/blueprints/ticket.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/todosrht/blueprints/ticket.py b/todosrht/blueprints/ticket.py
index fe9d38b..0d73bfa 100644
--- a/todosrht/blueprints/ticket.py
+++ b/todosrht/blueprints/ticket.py
@@ -487,6 +487,8 @@ def ticket_assign(owner, name, ticket_id):
    valid = Validation(request)
[message trimmed]

Re: Bug: obs-time-source: fails to build on several architectures 1 year, 3 months ago

From Krystian Chachuła to ~krystianch/public-inbox

Unfortunately, I cannot reproduce this issue. On aarch64, which is the
same as arm64, I get a successful build using instructions from the
README. Please see the log below. I'm unfamiliar with Debian packaging.
Is it possible that the problem is because the build is performed via
the dh command and not by invoking meson/ninja directly?


$ meson setup build
The Meson build system
Version: 1.2.3
Source dir: /home/krystianch/obs-time-source
Build dir: /home/krystianch/obs-time-source/build
Build type: native build
Project name: obs-time

Re: Bug: obs-time-source: fails to build on several architectures 1 year, 3 months ago

From Krystian Chachuła to ~krystianch/public-inbox

Hi Eriberto,

thanks for reporting this. I think the problem is the compiler warning
about strncpy in combination with the -Werror=format-security option.

I pushed a fix. Would you please test the latest commit?

Re: obs-time-source - translation to pt-BR 1 year, 4 months ago

From Krystian Chachuła to ~krystianch/public-inbox

Thanks!

To git@git.sr.ht:~krystianch/obs-time-source
   4bc3b3a..d1483f3  master -> master