~kvo

https://kvo.envs.net

Programming is about solving problems, not creating new ones.

~kvo/taskcollect-devel

Last active 2 months ago

~kvo/websys

Last active 7 months ago

~kvo/taskcollect-announce

Last active 8 months ago

~kvo/taskcollect-discuss

Last active 11 months ago

~kvo/public

Last active 1 year, 8 months ago
View more

Recent activity

Re: [PATCH] src/site/myadelaide/lessons.go: fixed an issue where listResp would not return a correctly sorted list of lessons. 2 months ago

From kvo to ~kvo/taskcollect-devel

Thanks!

To ssh://git@git.sr.ht/~kvo/taskcollect
   cead44b..a8a9aba  main -> main

Re: [PATCH v2] src/server/timetable.go: added ical generation 2 months ago

From kvo to ~kvo/taskcollect-devel

Thanks!

To ssh://git@git.sr.ht/~kvo/taskcollect
   31950bf..593186f  main -> main

Re: [PATCH] src/server/timetable.go: added ical generation 2 months ago

From kvo to ~kvo/taskcollect-devel

This is one of the best patches I've reviewed so far! However, there
are some minor issues that need fixing.

You need to make sure your local code compiles before you commit. This
patch unfortunately does not compile. The most notable issue is that
UUID is undefined, and based on GenerateUUID I'm not sure what data
structure UUID should be. Preferably it should simply be a string, not
some other structure.

Re: [PATCH] Fixed an issue where the input fields on the login page would not work properly. Cleaned up some of the html on the launch page. 7 months ago

From kvo to ~kvo/websys

Resources are broken (not preceded with `/res/`). Other than that, the patch is
fine. Please send v2 patch with fixed resource paths.

Re: [PATCH] Updated script to only show loading animation when clicking navigation items and general resource pages. 7 months ago

From kvo to ~kvo/taskcollect-devel

I've merged the patch into main and applied the fixes. Issue #15 can
now be marked as resolved.

[PATCH] Demonstrate that I can use git send-email 8 months ago

From kvo to ~sircmpwn/email-test-drive

---
 kvo | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 kvo

diff --git a/kvo b/kvo
new file mode 100644
index 0000000..6d0ecfd
--- /dev/null
+++ b/kvo
@@ -0,0 +1 @@
I'm about to try git send-email
-- 
2.40.1
[message trimmed]

Re: todo.sr.ht: submitting comment on ticket yields error 500 8 months ago

From kvo to ~sircmpwn/sr.ht-discuss

Never mind, it must have been a temporary issue. I tried again several
times (through the web interface), and after a few minutes it worked.

todo.sr.ht: submitting comment on ticket yields error 500 8 months ago

From kvo to ~sircmpwn/sr.ht-discuss

A few minutes ago I tried sending a comment to
https://todo.sr.ht/~kvo/taskcollect/15 via email. I received an
automated email response with error 550 (Undelivered Mail Returned to
Sender). Specifically, the most relevant error messages seems to be
this one:

	internal system error (in reply to end of DATA command)

And this one:

	Diagnostic-Code: smtp; 550 internal system error

Attempting to submit a comment via the the web interface also fails: I
get "500 Internal Server Error".

Re: [PATCH] Updated script to only show loading animation when clicking navigation items and general resource pages. 8 months ago

From kvo to ~kvo/taskcollect-devel

Content-wise the patch looks good, except the `console.log` statements
that seems to have remained after debugging. Those statements should
be removed.

However, some of the if statements could be made more concise. Seeing
as JavaScript logical expressions evaluate left-to-right, you can
write `if (nav != null && nav.contains(event.target))` because the
second statement after the `&&` will not be evaluated if the first
statement is already false.

Aside from that my only concerns are about styling. This is not a big
issue, and the styling was inconsistent in the JS script before as
well, but it would be nice to resolve the inconsistency now that we're
already in the process of modifying the script.