Programming is about solving problems, not creating new ones.
From kvo to ~kvo/taskcollect-devel
Thanks! To ssh://git@git.sr.ht/~kvo/taskcollect cead44b..a8a9aba main -> main
From kvo to ~kvo/taskcollect-devel
Thanks! To ssh://git@git.sr.ht/~kvo/taskcollect 31950bf..593186f main -> main
From kvo to ~kvo/taskcollect-devel
This is one of the best patches I've reviewed so far! However, there are some minor issues that need fixing. You need to make sure your local code compiles before you commit. This patch unfortunately does not compile. The most notable issue is that UUID is undefined, and based on GenerateUUID I'm not sure what data structure UUID should be. Preferably it should simply be a string, not some other structure.
From kvo to ~kvo/websys
Resources are broken (not preceded with `/res/`). Other than that, the patch is fine. Please send v2 patch with fixed resource paths.
From kvo to ~kvo/taskcollect-devel
I've merged the patch into main and applied the fixes. Issue #15 can now be marked as resolved.
From kvo to ~sircmpwn/email-test-drive
--- kvo | 1 + 1 file changed, 1 insertion(+) create mode 100644 kvo diff --git a/kvo b/kvo new file mode 100644 index 0000000..6d0ecfd --- /dev/null +++ b/kvo @@ -0,0 +1 @@ I'm about to try git send-email -- 2.40.1 [message trimmed]
From kvo to ~sircmpwn/sr.ht-discuss
For me it's #6 but also a #4 that was referenced: https://todo.sr.ht/~kvo/taskcollect/4 https://todo.sr.ht/~kvo/taskcollect/6
From kvo to ~sircmpwn/sr.ht-discuss
Never mind, it must have been a temporary issue. I tried again several times (through the web interface), and after a few minutes it worked.
From kvo to ~sircmpwn/sr.ht-discuss
A few minutes ago I tried sending a comment to https://todo.sr.ht/~kvo/taskcollect/15 via email. I received an automated email response with error 550 (Undelivered Mail Returned to Sender). Specifically, the most relevant error messages seems to be this one: internal system error (in reply to end of DATA command) And this one: Diagnostic-Code: smtp; 550 internal system error Attempting to submit a comment via the the web interface also fails: I get "500 Internal Server Error".
From kvo to ~kvo/taskcollect-devel
Content-wise the patch looks good, except the `console.log` statements that seems to have remained after debugging. Those statements should be removed. However, some of the if statements could be made more concise. Seeing as JavaScript logical expressions evaluate left-to-right, you can write `if (nav != null && nav.contains(event.target))` because the second statement after the `&&` will not be evaluated if the first statement is already false. Aside from that my only concerns are about styling. This is not a big issue, and the styling was inconsistent in the JS script before as well, but it would be nice to resolve the inconsistency now that we're already in the process of modifying the script.