~labrat

Recent activity

[PATCH] notmuch/maildir: remove double emit of the dirinfo 14 days ago

From Reto Brunner to ~sircmpwn/aerc

There was some bug which could be worked around by double emitting an event.
However that proofed to be brittle:

We send the first message here from the worker goroutine:
https://git.sr.ht/~sircmpwn/aerc/tree/a5553438/item/worker/maildir/worker.g=
o#L306

Then Tick() is waked in the main goroutine and calls ProcessMessage:
https://git.sr.ht/~sircmpwn/aerc/tree/a5553438/item/widgets/account.go#L100

ProcessMessage in the main goroutine reads types.Message state with
msg.getId() and msg.InResponseTo():
https://git.sr.ht/~sircmpwn/aerc/tree/a5553438/item/worker/types/worker.go#=
L74-76
[message trimmed]

Re: [PATCH] maildir: fix race condition in openDirectory 15 days ago

From Reto to ~sircmpwn/aerc

Hallo Wagner,

On Mon, Apr 26, 2021 at 12:58:47AM -0300, wagner riffel wrote:
> Hey Reto, friendly pinging, in case you missed my reply, it's been
> over 15 days since your last reply and I'm willing to work on changes
> to get this merged.

Sorry, fell through the cracks.

So...
I can't reproduce the error anymore with the event loop stalling at least in
the notmuch worker.

Can you try what happens if you simply remove the double emit of the event?

Re: [PATCH] widgets/terminal: Only call vterm.ScreenCell.Attrs once in styleFromCell 24 days ago

From Reto to ~sircmpwn/aerc

Hi there,

On Mon, Apr 12, 2021 at 04:24:35PM -0700, Clayton Craft wrote:
> This fixes a substantial performance issue when scrolling emails with
> long/complicated contents, where scrolling down a single line can take
> something like hundreds of ms before the screen is updated to reflect
> the scroll. It's really bad if the email has lots of columns, e.g. like
> if it's an html email that was passed through a filter (w3m, etc) to
> render it.

Merged, thank you :)

Re: [PATCH] show perms error only if config contains secrets 29 days ago

From Reto to ~sircmpwn/aerc

> What if instead we only deactivate the warning when only `*-cred-cmd`
> options are used?

Hm, that might work.
But that means bailing out as soon as even one account doesn't have it.

Cheers,
Reto

Re: [PATCH] show perms error only if config contains secrets 29 days ago

From Reto to ~sircmpwn/aerc

Hi,
Thanks for the patch.

On Thu, Apr 08, 2021 at 07:59:47PM +0200, Bruno BELANYI wrote:
> This patch allows the user to store their configuration file with laxer
> permissions if it does not contain any actual secrets (i.e: paswords or
> OAuth tokens).

Why do you need this in the first place?
Your user has read access, why do other users need to read the config?

> I'm not really familiar with Go or this codebase, so please do give me
> feedback about anything that I might have missed.

Re: [PATCH] maildir: fix race condition in openDirectory 29 days ago

From Reto to ~sircmpwn/aerc

Hi,

On Fri, Apr 09, 2021 at 04:37:32PM -0300, wagner riffel wrote:
> This race condition happens often while aerc is openning a maildir
> directory, deleteing this second PostMessage calls also works, but
> right above there is a comment it has to be sent twice for some
> unknown reason, so i left the second send but using a copy of info
> instead.

Nack, this is a band aid glossing over a problem.
Not sure why it's not enough to only spawn a single event (notmuch has the same
hack in place)

But we certainly shouldn't make a copy of the thing for no reason.

Re: [PATCH] config: proper error handle [filters] config 29 days ago

From Reto to ~sircmpwn/aerc

On Fri, Apr 09, 2021 at 04:26:09PM -0300, wagner riffel wrote:
> Instead of panic when compiling a regular expression, return it up

Thanks for the patch, merged to master.

Cheers,
Reto

Re: Running a script on email load 29 days ago

From Reto to ~sircmpwn/aerc

On Thu, Apr 08, 2021 at 06:41:00PM -0700, Tomasz Tunguz wrote:
> I read the documentation and added this line to aerc.conf
>  new-email=exec khard.sh %a %n
>  but it doesn't trigger the script which creates the khard. manually, it works executing with exec or term. thanks for the help!

> Is there a way to run a script as an email is loaded? I'd like to scrape
> the email address and add to khard to build up my address book?

You're going to have a bad time using the new email trigger for that.
That thing is really only meant to fire off a notification, nothing more.
It only triggers for the active mailbox and only in very specific circumstances
(meaning actually having the recent imap flag).

Better might be to use a specific tool that does the indexing directly from within

Re: Right justify format a month ago

From Reto to ~sircmpwn/aerc

Hi,

On Tue, Apr 06, 2021 at 05:14:36PM -0400, John Zhuang Hui wrote:
> Right now, users can customize the format of each line in the email
> index view using the index-format option. The aerc-config manpage
> claims that it is compatible with mutt's printf-like syntax.

That's the goal, yes.

> However, aerc seems to be missing the padding format specifiers
> described in Mutt's manual:
> <http://www.mutt.org/doc/manual/#formatstrings-padding>

> Does this feature exist? And if not, is anyone working on it?

Re: [PATCH v6] Threading for Notmuch and IMAP a month ago

From Reto to ~sircmpwn/aerc

On 30 March 2021 20:05:02 CEST, inwit <inwit@sindominio.net> wrote:

>Auto-merging lib/msgstore.go 
>CONFLICT (content): Merge conflict in lib/msgstore.go                  
>                                                       
>error: Failed to merge in the changes. 
>Patch failed at 0001 Threading for Notmuch and IMAP 
>
>I am surely doing something wrong, but I can't find what. Should I
>apply                                                       
>other patches before this one? Any help will be appreciated.

The code bases diverged, you'd need to fix the merge conflict. Shouldn't be too hard.