~labrat

Recent activity

[PATCH] dirlist: adapt to dynamic UIconfig a day ago

From Reto Brunner to ~sircmpwn/aerc

---
 widgets/account.go |  2 +-
 widgets/dirlist.go | 30 ++++++++++++++++++++----------
 2 files changed, 21 insertions(+), 11 deletions(-)

diff --git a/widgets/account.go b/widgets/account.go
index 455c28e..f8b6581 100644
--- a/widgets/account.go
+++ b/widgets/account.go
@@ -65,7 +65,7 @@ func NewAccountView(aerc *Aerc, conf *config.AercConfig, acct *config.AccountCon
		}
	}

	dirlist := NewDirectoryList(acct, &acctUiConf, logger, worker)
[message trimmed]

[PATCH] dirlist: remove not needed sort function a day ago

From Reto Brunner to ~sircmpwn/aerc

The docs of strings.Compare state:

> Compare is included only for symmetry with package bytes. It is usually
> clearer and always faster to use the built-in string comparison operators
> ==, <, >, and so on.

So let's do that.
---
 widgets/dirlist.go | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/widgets/dirlist.go b/widgets/dirlist.go
index c0c8917..edc84c6 100644
--- a/widgets/dirlist.go
[message trimmed]

[PATCH v2] config: Strongly type context type 2 days ago

From Reto Brunner to ~sircmpwn/aerc

The go compiler can't help much with untyped int constants.
Even though the only valid constants are 0-3 it will happily accept 4 as input.

Let's let the go compiler worry about correctness here. This also allows people
not very familiar with the code to use it properly via auto completion.
---
 config/config.go   | 11 +++++++----
 widgets/account.go |  4 ++--
 widgets/msglist.go |  2 +-
 3 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/config/config.go b/config/config.go
index 0b46014..0393e46 100644
--- a/config/config.go
[message trimmed]

[PATCH] config: Strongly type context type 2 days ago

From Reto Brunner to ~sircmpwn/aerc

The go compiler can't help much with untyped int constants.
Even though the only valid constants are 0-3 it will happily accept 4 as input.

Let's let the go compiler worry about correctness here. This also allows people
not very familiar with the code to use it properly via auto completion.
---
 config/config.go   | 10 ++++++----
 widgets/account.go |  4 ++--
 widgets/msglist.go |  2 +-
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/config/config.go b/config/config.go
index 0b46014..03a79a6 100644
--- a/config/config.go
[message trimmed]

Re: [PATCH] Fix handling of multiple template-dirs 3 days ago

From Reto to ~sircmpwn/aerc

Thanks Ben, merged.

[PATCH v2] imap: emit messageinfo when changing read state. 3 days ago

From Reto Brunner to ~sircmpwn/aerc

We need to emit the changed msgInfo whenever we modify the state
---
v1 --> v2: fix variable shadowing. Thanks Ben.

Easiest way to do that is to simply emit the fetchHeaders action.
Any objections in doing that?

 worker/imap/flags.go | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/worker/imap/flags.go b/worker/imap/flags.go
index 57211a6..17c9393 100644
--- a/worker/imap/flags.go
+++ b/worker/imap/flags.go
[message trimmed]

Re: [PATCH] imap: emit messageinfo when changing read state. 3 days ago

From Reto to ~sircmpwn/aerc

... I need more coffee apparently.

Thanks a lot for catching that Ben, v2 incoming

[PATCH] imap: emit messageinfo when changing read state. 4 days ago

From Reto Brunner to ~sircmpwn/aerc

We need to emit the changed msgInfo whenever we modify the state
---
Easiest way to do that is to simply emit the fetchHeaders action.
Any objections in doing that?

 worker/imap/flags.go | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/worker/imap/flags.go b/worker/imap/flags.go
index 57211a6..011cf54 100644
--- a/worker/imap/flags.go
+++ b/worker/imap/flags.go
@@ -1,6 +1,7 @@
package imap
[message trimmed]

[PATCH] msgview/open: remove manual decoding 7 days ago

From Reto Brunner to ~sircmpwn/aerc

---
 commands/msgview/open.go | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/commands/msgview/open.go b/commands/msgview/open.go
index 6001d28..b467543 100644
--- a/commands/msgview/open.go
+++ b/commands/msgview/open.go
@@ -1,13 +1,10 @@
package msgview

import (
	"encoding/base64"
	"errors"
[message trimmed]

[PATCH] msgview/save: Adapt to already decoded reader 7 days ago

From Reto Brunner to ~sircmpwn/aerc

The functionality was broken since the decoding changes.
This commit also simplifies the code (in my view) to make the application logic
easier to follow.
The docs are updated accordingly (the feature was poorly documented).

As far as I am aware there should be no breaking changes (and is certainly
still in the spec of the prior documentation)
---

The status message doesn't seem to work though, but I can't do it synchronously
as the callback first needs to happen prior to knowing whether it succeeded or not.

Any ideas why that is and how to fix it?
[message trimmed]