~lattis

Eastern US

https://mochiro.moe

~lattis/muon

Last active 34 minutes ago
View more

Recent activity

Re: [PATCH] Add shell scripts to editorconfig 34 minutes ago

From Stone Tickle to ~lattis/muon

Looks good to me, I will apply this when I am back at my computer.

Stone

Re: [PATCH 1/2] Factor out relativizeing custom target paths 41 minutes ago

From Stone Tickle to ~lattis/muon

> Thanks, I can move it to args.c but do you still want the patch if I use
> arr_to_args() instead?

If you want to fix the patch, I will happily apply it since I think it
is an organizational improvement.  If not, then that's okay too.

Stone

Re: [PATCH 2/2] Add support for alias targets 6 hours ago

From Stone Tickle to ~lattis/muon

> > > diff --git a/src/backend/ninja.c b/src/backend/ninja.c
> > > index e0458ea..23f29d8 100644
> > > --- a/src/backend/ninja.c
> > > +++ b/src/backend/ninja.c
> > > @@ -1,5 +1,6 @@
> > >  #include "posix.h"
> > >
> >
> > keep a blank newline after the initial posix.h include
> 
> It looks like there is already one. Am I missing something?
> 

You are right, I'm sorry about that.  My mail client wasn't displaying

Re: Build with libpkgconf a day ago

From Stone Tickle to ~lattis/muon

> Well, now that I got muon,

Great :)

> I tried it on a port I’m working on, but it segfaults :)

Could you rerun that muon invocation under a debugger or valgrind and
provide the stacktrace?  Also, please add the `-v` flag. That would
really help me debug your issue!

Thanks,
Stone

Re: [PATCH 2/2] Add support for alias targets a day ago

From Stone Tickle to ~lattis/muon

> diff --git a/bootstrap.sh b/bootstrap.sh
> index a371fb6..0ed13e7 100755
> --- a/bootstrap.sh
> +++ b/bootstrap.sh
> @@ -28,6 +28,7 @@ cat \
>  	src/args.c \
>  	src/backend/common_args.c \
>  	src/backend/ninja.c \
> +        src/backend/ninja/alias_target.c \

This file uses tabs for indentation

>  	src/backend/ninja/build_target.c \
>  	src/backend/ninja/custom_target.c \

Re: [PATCH 1/2] Factor out relativizeing custom target paths a day ago

From Stone Tickle to ~lattis/muon

This patch looks good except for one small formatting issue, however, I
think this function would probably fit better into args.c.

> --- a/include/backend/ninja/custom_target.h
> +++ b/include/backend/ninja/custom_target.h
> @@ -2,5 +2,7 @@
>  #define MUON_BACKEND_NINJA_CUSTOM_TARGET_H
>  #include "lang/workspace.h"
> 
> +

Can you remove this extraneous newline?

> +bool ninja_join_and_relativize_paths(struct workspace *wk, obj input_arr, obj *output_str);

Re: [PATCH 0/2] Add Support for alias targets a day ago

From Stone Tickle to ~lattis/muon

Thank you for this patch!  I will be afk until next week, so it will be
hard for me to test your changes. Since muon currently doesn't set the
default ninja build target, I wonder if alias targets work properly?

Stone

Re: Build with libpkgconf 3 days ago

From Stone Tickle to ~lattis/muon

Hello,

> Hi, can you provide the instructions on how to build muon with pkgconf
> support?
> I tried to bootstrap it, and build itself with libpkgconf=enabled.

Unfortunately this won't work, because the bootstrapped muon created
with `./bootstrap.sh` can only really setup itself.  If you don't
already have pkgconf and libpkgconf installed, the full bootstrap
process is:

1.) run `./bootstrap.sh`.  This gets you a muon that can execute `muon
setup build` (but is missing some important features, such as a complete
list of built-in options).

Re: [PATCH] BASENAME and PLANNAME for custom_target command. 5 days ago

From Stone Tickle to ~lattis/muon

This looks good to me!

Thanks,
Stone

Re: [PATCH] Add additional c++ file extensions. 6 days ago

From Stone Tickle to ~lattis/muon

Looks good to me!

Stone