Thanks!


Friendly greetings,
Leon Henrik Plickat

Thanks for working on this!

>  const red = spoon.Attribute{ .fg = .red, .italic = true };
>  const green = spoon.Attribute{ .fg = .green, .blinking = true };
> -const blue = spoon.Attribute{ .fg = .blue, .bold = true };
> -const cyan = spoon.Attribute{ .fg = .cyan, .reverse = true };
> +const blue = spoon.Attribute{ .fg = .{ .rgb = .{ 137, 207, 240 } }, .bold = true };
> +const cyan = spoon.Attribute{ .fg = .{ .@"256" = 123 }, .reverse = true };
>  const reset = spoon.Attribute{};

Instead of changing these colours, I'd prefer a second line below.
Or, maybe create yet another example program, that prints a colour
table of all thejust  256 colours.

Thanks!

This typo has copy-pasted itself into pretty much all my makefiles.
I thought I fixed them all, but apparently I missed some...


Friendly greetings,
Leon Henrik Plickat

On Thu May 5, 2022 at 2:32 PM CEST, Andrea Feletto wrote:
> The std.os.system variable therefore points to
> std.c, which does not have many of the constants used by zig-spoon.
> Some of them are ECHO, ICANON, ISIG and IEXTEN, which are used in
> Term.uncook.

In the C world, those are provided by termios.h, which AFAIK is part
of the POSIX spec. Have you tried including that? (This definitely
needs to be documented, I just haven't gotten around to it yet,
busy semester).

If that does not work, than I'll special case linkin libc in zig-spoon
and include termios.h in there as a temporary workaround.

Thanks!


Friendly greetings,
Leon Henrik Plickat

Thanks!

On Mon Apr 25, 2022 at 1:14 PM CEST, Hugo Machet wrote:
> * Use writeAll() instead of print(), I'm curious to know why?

Just for the sake of explicitness. The print call will evaluate to
effectively the same, but I prefer it explicit.

Final review round!

On Mon Apr 25, 2022 at 12:57 PM CEST, Hugo Machet wrote:
> + try term.setWindowTitle("zig-spoon example: menu");

The input-demo example also deserves a title.

> + try writer.print("\x1b]2;{s}\x1b\\", .{title});

Instead of print, I'd prefer three writer.writeAll() calls.

> - _ = try writer.print(spells.move_cursor_fmt, .{ row + 1, col + 1 });
> + try writer.print(spells.move_cursor_fmt, .{ row + 1, col + 1 });

Thanks for working on this!

On Mon Apr 25, 2022 at 12:11 PM CEST, Hugo Machet wrote:
> ---
> Added it in the menu example to test
>
> Unrelated but writing it, I saw in the function below, moveCursorTo(),
> that it use:
>
> _ = try writer.print()
>
> Since print() return !void, is this an error?

Thanks!


Friendly greetings,
Leon Henrik Plickat

Thanks!


Friendly greetings,
Leon Henrik Plickat