Hi all,

UPDATE: your mailer won't allow me to attach SVG files or configuration files, so I've had to leave out the files required to replicate this bug. Please let me know of an appropriate way to send them over later

I've noticed a bug since upgrading from lavalauncher v2.1.0 to v2.1.1. Namely: a number of the (svg) icons on my launcher disappeared and one of them changed size. On investigation it was found that SVG files without the "viewBox" property were not displaying correctly

Please find attached a sample config and two SVG icons (with and without the viewBox property included, respectively), in order to replicate the issue

Steps to replicate: enter the directory containing the attached files and run `lavalauncher -cv launcher.conf`

Expected behaviour: both icons display in the launcher

Actual behaviour: only one icon displays in the launcher. No error is displayed even with verbose logging enabled

Cause: Due to changes made after bumping the librsvg version in use, a bug was introduced whereby the viewBox property is now used in place of height and width. However, the viewBox property is not always present in an svg file. Additionally, only the height and width were being validated, and then used to calculate the scale for displaying the image - this should have been updated to use the height and width of the viewbox

Fix: I've included a patch which makes the viewbox height and width calculations more forgiving, and uses the correct values when calculating scale

Please further find the file svg-viewbox-fix.patch attached

I hope this report and patch is helpful! Thanks for your work creating such a useful tool :)

Best wishes,
Jessica Alford

Hi!

This bug is caused by a change in the librsvg library.

Please note that unfortunately LavaLauncher is unmaintained
at the moment. I will push your patch upstream anyway.
If you like, you can also checkout the lavalauncher-next
branch on git, which has a few changes and improvements
that never made it into git master.

I hope I can get back into maintaining LavaLauncher,
however my time is stretched a bit thin at the moment.


--
Friendly greetings,
Leon Henrik Plickat